From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v2 hmm 00/11] Various revisions from a locking/code review Date: Thu, 13 Jun 2019 14:50:09 -0300 Message-ID: <20190613175009.GG22901@ziepe.ca> References: <20190606184438.31646-1-jgg@ziepe.ca> <20190611194858.GA27792@ziepe.ca> <5d3b0ae2-3662-cab2-5e6c-82912f32356a@amd.com> <69bb7fe9-98e7-8a49-3e0b-f639010b8991@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <69bb7fe9-98e7-8a49-3e0b-f639010b8991@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Yang, Philip" Cc: "linux-rdma@vger.kernel.org" , "Kuehling, Felix" , "amd-gfx@lists.freedesktop.org" , "linux-mm@kvack.org" , "dri-devel@lists.freedesktop.org" , "Deucher, Alexander" List-Id: amd-gfx.lists.freedesktop.org T24gV2VkLCBKdW4gMTIsIDIwMTkgYXQgMDk6NDk6MTJQTSArMDAwMCwgWWFuZywgUGhpbGlwIHdy b3RlOgo+IFJlYmFzZSB0byBodHRwczovL2dpdGh1Yi5jb20vamd1bnRob3JwZS9saW51eC5naXQg aG1tIGJyYW5jaCwgbmVlZCBzb21lIAo+IGNoYW5nZXMgYmVjYXVzZSBvZiBpbnRlcmZhY2UgaG1t X3JhbmdlX3JlZ2lzdGVyIGNoYW5nZS4gVGhlbiBydW4gYSBxdWljayAKPiBhbWRncHVfdGVzdC4g VGVzdCBpcyBmaW5pc2hlZCwgcmVzdWx0IGlzIG9rLgoKR3JlYXQhIFRoYW5rcwoKSSdsbCBhZGQg eW91ciBUZXN0ZWQtYnkgdG8gdGhlIHNlcmllcwoKPiAgQnV0IHRoZXJlIGlzIGJlbG93IGtlcm5l bCBCVUcgbWVzc2FnZSwgc2VlbXMgaG1tX2ZyZWVfcmN1IGNhbGxzCj4gZG93bl93cml0ZS4uLi4u Cj4gCj4gWyAxMTcxLjkxOTkyMV0gQlVHOiBzbGVlcGluZyBmdW5jdGlvbiBjYWxsZWQgZnJvbSBp bnZhbGlkIGNvbnRleHQgYXQgCj4gL2hvbWUveWFuZ3AvZ2l0L2NvbXB1dGVfc3RhZ2luZy9rZXJu ZWwva2VybmVsL2xvY2tpbmcvcndzZW0uYzo2NQo+IFsgMTE3MS45MTk5MzNdIGluX2F0b21pYygp OiAxLCBpcnFzX2Rpc2FibGVkKCk6IDAsIHBpZDogNTMsIG5hbWU6IAo+IGt3b3JrZXIvMToxCj4g WyAxMTcxLjkxOTkzOF0gMiBsb2NrcyBoZWxkIGJ5IGt3b3JrZXIvMToxLzUzOgo+IFsgMTE3MS45 MTk5NDBdICAjMDogMDAwMDAwMDAxYzdjMTlkNCAoKHdxX2NvbXBsZXRpb24pcmN1X2dwKXsrLisu fSwgYXQ6IAo+IHByb2Nlc3Nfb25lX3dvcmsrMHgyMGUvMHg2MzAKPiBbIDExNzEuOTE5OTUxXSAg IzE6IDAwMDAwMDAwOTIzZjJjZmEgCj4gKCh3b3JrX2NvbXBsZXRpb24pKCZzZHAtPndvcmspKXsr LisufSwgYXQ6IHByb2Nlc3Nfb25lX3dvcmsrMHgyMGUvMHg2MzAKPiBbIDExNzEuOTE5OTU5XSBD UFU6IDEgUElEOiA1MyBDb21tOiBrd29ya2VyLzE6MSBUYWludGVkOiBHICAgICAgICBXIAo+ICAg ICA1LjIuMC1yYzEta2ZkLXlhbmdwICMxOTYKPiBbIDExNzEuOTE5OTYxXSBIYXJkd2FyZSBuYW1l OiBBU1VTIEFsbCBTZXJpZXMvWjk3LVBSTyhXaS1GaSBhYykvVVNCIDMuMSwgCj4gQklPUyA5MDAx IDAzLzA3LzIwMTYKPiBbIDExNzEuOTE5OTY1XSBXb3JrcXVldWU6IHJjdV9ncCBzcmN1X2ludm9r ZV9jYWxsYmFja3MKPiBbIDExNzEuOTE5OTY4XSBDYWxsIFRyYWNlOgo+IFsgMTE3MS45MTk5NzRd ICBkdW1wX3N0YWNrKzB4NjcvMHg5Ygo+IFsgMTE3MS45MTk5ODBdICBfX19taWdodF9zbGVlcCsw eDE0OS8weDIzMAo+IFsgMTE3MS45MTk5ODVdICBkb3duX3dyaXRlKzB4MWMvMHg3MAo+IFsgMTE3 MS45MTk5ODldICBobW1fZnJlZV9yY3UrMHgyNC8weDgwCj4gWyAxMTcxLjkxOTk5M10gIHNyY3Vf aW52b2tlX2NhbGxiYWNrcysweGM5LzB4MTUwCj4gWyAxMTcxLjkyMDAwMF0gIHByb2Nlc3Nfb25l X3dvcmsrMHgyOGUvMHg2MzAKPiBbIDExNzEuOTIwMDA4XSAgd29ya2VyX3RocmVhZCsweDM5LzB4 M2YwCj4gWyAxMTcxLjkyMDAxNF0gID8gcHJvY2Vzc19vbmVfd29yaysweDYzMC8weDYzMAo+IFsg MTE3MS45MjAwMTddICBrdGhyZWFkKzB4MTFjLzB4MTQwCj4gWyAxMTcxLjkyMDAyMV0gID8ga3Ro cmVhZF9wYXJrKzB4OTAvMHg5MAo+IFsgMTE3MS45MjAwMjZdICByZXRfZnJvbV9mb3JrKzB4MjQv MHgzMAoKVGhhbmsgeW91IFBoaWxsaXAsIGl0IHNlZW1zIHRoZSBwcmlvciB0ZXN0cyB3ZXJlIG5v dCBkb25lIHdpdGgKbG9ja2RlcC4uCgpTaWdoLCBJIHdpbGwga2VlcCB0aGlzIHdpdGggdGhlIGdy b3NzIHBhZ2V0YWJsZV9sb2NrIHRoZW4uIEkgdXBkYXRlZAp0aGUgcGF0Y2hlcyBvbiB0aGUgZ2l0 IHdpdGggdGhpcyBtb2RpZmljYXRpb24uIEkgdGhpbmsgd2UgaGF2ZSBjb3ZlcmVkCmFsbCB0aGUg YmFzZXMgc28gSSB3aWxsIHNlbmQgYW5vdGhlciBWIG9mIHRoZSBzZXJpZXMgdG8gdGhlIGxpc3Qg YW5kCmlmIG5vIG1vcmUgY29tbWVudHMgdGhlbiBpdCB3aWxsIG1vdmUgYWhlYWQgdG8gaG1tLmdp dC4gVGhhbmtzIHRvIGFsbC4KCmRpZmYgLS1naXQgYS9tbS9obW0uYyBiL21tL2htbS5jCmluZGV4 IDEzNmM4MTJmYWEyNzkwLi40YzY0ZDRjMzJmNDgyNSAxMDA2NDQKLS0tIGEvbW0vaG1tLmMKKysr IGIvbW0vaG1tLmMKQEAgLTQ5LDE2ICs0OSwxNSBAQCBzdGF0aWMgc3RydWN0IGhtbSAqaG1tX2dl dF9vcl9jcmVhdGUoc3RydWN0IG1tX3N0cnVjdCAqbW0pCiAKIAlsb2NrZGVwX2Fzc2VydF9oZWxk X2V4Y2x1c2l2ZSgmbW0tPm1tYXBfc2VtKTsKIAorCS8qIEFidXNlIHRoZSBwYWdlX3RhYmxlX2xv Y2sgdG8gYWxzbyBwcm90ZWN0IG1tLT5obW0uICovCisJc3Bpbl9sb2NrKCZtbS0+cGFnZV90YWJs ZV9sb2NrKTsKIAlpZiAobW0tPmhtbSkgewotCQlpZiAoa3JlZl9nZXRfdW5sZXNzX3plcm8oJm1t LT5obW0tPmtyZWYpKQorCQlpZiAoa3JlZl9nZXRfdW5sZXNzX3plcm8oJm1tLT5obW0tPmtyZWYp KSB7CisJCQlzcGluX3VubG9jaygmbW0tPnBhZ2VfdGFibGVfbG9jayk7CiAJCQlyZXR1cm4gbW0t PmhtbTsKLQkJLyoKLQkJICogVGhlIGhtbSBpcyBiZWluZyBmcmVlZCBieSBzb21lIG90aGVyIENQ VSBhbmQgaXMgcGVuZGluZyBhCi0JCSAqIFJDVSBncmFjZSBwZXJpb2QsIGJ1dCB0aGlzIENQVSBj YW4gTlVMTCBub3cgaXQgc2luY2Ugd2UKLQkJICogaGF2ZSB0aGUgbW1hcF9zZW0uCi0JCSAqLwot CQltbS0+aG1tID0gTlVMTDsKKwkJfQogCX0KKwlzcGluX3VubG9jaygmbW0tPnBhZ2VfdGFibGVf bG9jayk7CiAKIAlobW0gPSBrbWFsbG9jKHNpemVvZigqaG1tKSwgR0ZQX0tFUk5FTCk7CiAJaWYg KCFobW0pCkBAIC04MSw3ICs4MCwxNCBAQCBzdGF0aWMgc3RydWN0IGhtbSAqaG1tX2dldF9vcl9j cmVhdGUoc3RydWN0IG1tX3N0cnVjdCAqbW0pCiAJfQogCiAJbW1ncmFiKGhtbS0+bW0pOworCisJ LyoKKwkgKiBXZSBob2xkIHRoZSBleGNsdXNpdmUgbW1hcF9zZW0gaGVyZSBzbyB3ZSBrbm93IHRo YXQgbW0tPmhtbSBpcworCSAqIHN0aWxsIE5VTEwgb3IgMCBrcmVmLCBhbmQgaXMgc2FmZSB0byB1 cGRhdGUuCisJICovCisJc3Bpbl9sb2NrKCZtbS0+cGFnZV90YWJsZV9sb2NrKTsKIAltbS0+aG1t ID0gaG1tOworCXNwaW5fdW5sb2NrKCZtbS0+cGFnZV90YWJsZV9sb2NrKTsKIAlyZXR1cm4gaG1t OwogfQogCkBAIC04OSwxMCArOTUsMTQgQEAgc3RhdGljIHZvaWQgaG1tX2ZyZWVfcmN1KHN0cnVj dCByY3VfaGVhZCAqcmN1KQogewogCXN0cnVjdCBobW0gKmhtbSA9IGNvbnRhaW5lcl9vZihyY3Us IHN0cnVjdCBobW0sIHJjdSk7CiAKLQlkb3duX3dyaXRlKCZobW0tPm1tLT5tbWFwX3NlbSk7CisJ LyoKKwkgKiBUaGUgbW0tPmhtbSBwb2ludGVyIGlzIGtlcHQgdmFsaWQgd2hpbGUgbm90aWZpZXIg b3BzIGNhbiBiZSBydW5uaW5nCisJICogc28gdGhleSBkb24ndCBoYXZlIHRvIGRlYWwgd2l0aCBh IE5VTEwgbW0tPmhtbSB2YWx1ZQorCSAqLworCXNwaW5fbG9jaygmaG1tLT5tbS0+cGFnZV90YWJs ZV9sb2NrKTsKIAlpZiAoaG1tLT5tbS0+aG1tID09IGhtbSkKIAkJaG1tLT5tbS0+aG1tID0gTlVM TDsKLQl1cF93cml0ZSgmaG1tLT5tbS0+bW1hcF9zZW0pOworCXNwaW5fdW5sb2NrKCZobW0tPm1t LT5wYWdlX3RhYmxlX2xvY2spOwogCW1tZHJvcChobW0tPm1tKTsKIAogCWtmcmVlKGhtbSk7Cl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==