From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3 hmm 06/12] mm/hmm: Hold on to the mmget for the lifetime of the range Date: Tue, 18 Jun 2019 12:11:00 -0300 Message-ID: <20190618151100.GI6961@ziepe.ca> References: <20190614004450.20252-1-jgg@ziepe.ca> <20190614004450.20252-7-jgg@ziepe.ca> <20190615141435.GF17724@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190615141435.GF17724@infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christoph Hellwig Cc: Andrea Arcangeli , Philip Yang , Ralph Campbell , linux-rdma@vger.kernel.org, John Hubbard , Felix.Kuehling@amd.com, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Jerome Glisse , amd-gfx@lists.freedesktop.org, Ben Skeggs List-Id: amd-gfx.lists.freedesktop.org T24gU2F0LCBKdW4gMTUsIDIwMTkgYXQgMDc6MTQ6MzVBTSAtMDcwMCwgQ2hyaXN0b3BoIEhlbGx3 aWcgd3JvdGU6Cj4gPiAgCW11dGV4X2xvY2soJmhtbS0+bG9jayk7Cj4gPiAtCWxpc3RfZm9yX2Vh Y2hfZW50cnkocmFuZ2UsICZobW0tPnJhbmdlcywgbGlzdCkKPiA+IC0JCXJhbmdlLT52YWxpZCA9 IGZhbHNlOwo+ID4gLQl3YWtlX3VwX2FsbCgmaG1tLT53cSk7Cj4gPiArCS8qCj4gPiArCSAqIFNp bmNlIGhtbV9yYW5nZV9yZWdpc3RlcigpIGhvbGRzIHRoZSBtbWdldCgpIGxvY2sgaG1tX3JlbGVh c2UoKSBpcwo+ID4gKwkgKiBwcmV2ZW50ZWQgYXMgbG9uZyBhcyBhIHJhbmdlIGV4aXN0cy4KPiA+ ICsJICovCj4gPiArCVdBUk5fT04oIWxpc3RfZW1wdHkoJmhtbS0+cmFuZ2VzKSk7Cj4gPiAgCW11 dGV4X3VubG9jaygmaG1tLT5sb2NrKTsKPiAKPiBUaGlzIGNhbiBqdXN0IHVzZSBsaXN0X2VtcHR5 X2NhcmVmdWwgYW5kIGF2b2lkIHRoZSBsb2NrIGVudGlyZWx5LgoKU3VyZSwgaXQgaXMganVzdCBh IGRlYnVnZ2luZyBoZWxwZXIgYW5kIHRoZSBtbXB1dCBzaG91bGQgc2VyaWFsaXplCnRoaW5pZ3Mg ZW5vdWdoIHRvIGJlIHJlbGlhYmxlLiBJIGhhZCB0byBtb3ZlIHRoZSBSQ1UgcGF0Y2ggYWhlYWQg b2YKdGhpcy4gVGhhbmtzCgpkaWZmIC0tZ2l0IGEvbW0vaG1tLmMgYi9tbS9obW0uYwppbmRleCBh OWFjZTI4OTg0ZWE0Mi4uMWVkZGRhNDVjZWZhZTcgMTAwNjQ0Ci0tLSBhL21tL2htbS5jCisrKyBi L21tL2htbS5jCkBAIC0xMjQsMTMgKzEyNCwxMSBAQCBzdGF0aWMgdm9pZCBobW1fcmVsZWFzZShz dHJ1Y3QgbW11X25vdGlmaWVyICptbiwgc3RydWN0IG1tX3N0cnVjdCAqbW0pCiAJaWYgKCFrcmVm X2dldF91bmxlc3NfemVybygmaG1tLT5rcmVmKSkKIAkJcmV0dXJuOwogCi0JbXV0ZXhfbG9jaygm aG1tLT5sb2NrKTsKIAkvKgogCSAqIFNpbmNlIGhtbV9yYW5nZV9yZWdpc3RlcigpIGhvbGRzIHRo ZSBtbWdldCgpIGxvY2sgaG1tX3JlbGVhc2UoKSBpcwogCSAqIHByZXZlbnRlZCBhcyBsb25nIGFz IGEgcmFuZ2UgZXhpc3RzLgogCSAqLwotCVdBUk5fT04oIWxpc3RfZW1wdHkoJmhtbS0+cmFuZ2Vz KSk7Ci0JbXV0ZXhfdW5sb2NrKCZobW0tPmxvY2spOworCVdBUk5fT04oIWxpc3RfZW1wdHlfY2Fy ZWZ1bCgmaG1tLT5yYW5nZXMpKTsKIAogCWRvd25fd3JpdGUoJmhtbS0+bWlycm9yc19zZW0pOwog CW1pcnJvciA9IGxpc3RfZmlyc3RfZW50cnlfb3JfbnVsbCgmaG1tLT5taXJyb3JzLCBzdHJ1Y3Qg aG1tX21pcnJvciwKQEAgLTkzOCw3ICs5MzYsNyBAQCB2b2lkIGhtbV9yYW5nZV91bnJlZ2lzdGVy KHN0cnVjdCBobW1fcmFuZ2UgKnJhbmdlKQogCQlyZXR1cm47CiAKIAltdXRleF9sb2NrKCZobW0t PmxvY2spOwotCWxpc3RfZGVsKCZyYW5nZS0+bGlzdCk7CisJbGlzdF9kZWxfaW5pdCgmcmFuZ2Ut Pmxpc3QpOwogCW11dGV4X3VubG9jaygmaG1tLT5sb2NrKTsKIAogCS8qIERyb3AgcmVmZXJlbmNl IHRha2VuIGJ5IGhtbV9yYW5nZV9yZWdpc3RlcigpICovCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==