From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] dma-buf: cleanup reservation_object_init/fini Date: Thu, 27 Jun 2019 17:38:15 +0200 Message-ID: <20190627153815.GL12905@phenom.ffwll.local> References: <20190627101813.61430-1-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190627101813.61430-1-christian.koenig@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org List-Id: amd-gfx.lists.freedesktop.org T24gVGh1LCBKdW4gMjcsIDIwMTkgYXQgMTI6MTg6MTJQTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBUaGV5IGFyZSBub3QgdXNlZCB0aGF0IG9mdGVuIGFuZCBjZXJ0YWlubHkgbm90 IGluIGEgaG90IHBhdGguCj4gTWFrZSB0aGVtIG5vcm1hbCBmdW5jdGlvbnMgaW5zdGVhZCBvZiBh biBpbmxpbmUuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFu LmtvZW5pZ0BhbWQuY29tPgoKUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0 ZXJAZmZ3bGwuY2g+Cgo+IC0tLQo+ICBkcml2ZXJzL2RtYS1idWYvcmVzZXJ2YXRpb24uYyB8IDQ1 ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9saW51eC9yZXNl cnZhdGlvbi5oICAgfCA0NiArKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAy IGZpbGVzIGNoYW5nZWQsIDQ3IGluc2VydGlvbnMoKyksIDQ0IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2RtYS1idWYvcmVzZXJ2YXRpb24uYyBiL2RyaXZlcnMvZG1hLWJ1 Zi9yZXNlcnZhdGlvbi5jCj4gaW5kZXggNGQzMmUyYzY3ODYyLi5lZjcxMGVmZmVkZmEgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9kbWEtYnVmL3Jlc2VydmF0aW9uLmMKPiArKysgYi9kcml2ZXJzL2Rt YS1idWYvcmVzZXJ2YXRpb24uYwo+IEBAIC01NSw2ICs1NSw1MSBAQCBFWFBPUlRfU1lNQk9MKHJl c2VydmF0aW9uX3NlcWNvdW50X2NsYXNzKTsKPiAgY29uc3QgY2hhciByZXNlcnZhdGlvbl9zZXFj b3VudF9zdHJpbmdbXSA9ICJyZXNlcnZhdGlvbl9zZXFjb3VudCI7Cj4gIEVYUE9SVF9TWU1CT0wo cmVzZXJ2YXRpb25fc2VxY291bnRfc3RyaW5nKTsKPiAgCj4gKy8qKgo+ICsgKiByZXNlcnZhdGlv bl9vYmplY3RfaW5pdCAtIGluaXRpYWxpemUgYSByZXNlcnZhdGlvbiBvYmplY3QKPiArICogQG9i ajogdGhlIHJlc2VydmF0aW9uIG9iamVjdAo+ICsgKi8KPiArdm9pZCByZXNlcnZhdGlvbl9vYmpl Y3RfaW5pdChzdHJ1Y3QgcmVzZXJ2YXRpb25fb2JqZWN0ICpvYmopCj4gK3sKPiArCXd3X211dGV4 X2luaXQoJm9iai0+bG9jaywgJnJlc2VydmF0aW9uX3d3X2NsYXNzKTsKPiArCj4gKwlfX3NlcWNv dW50X2luaXQoJm9iai0+c2VxLCByZXNlcnZhdGlvbl9zZXFjb3VudF9zdHJpbmcsCj4gKwkJCSZy ZXNlcnZhdGlvbl9zZXFjb3VudF9jbGFzcyk7Cj4gKwlSQ1VfSU5JVF9QT0lOVEVSKG9iai0+ZmVu Y2UsIE5VTEwpOwo+ICsJUkNVX0lOSVRfUE9JTlRFUihvYmotPmZlbmNlX2V4Y2wsIE5VTEwpOwo+ ICt9Cj4gK0VYUE9SVF9TWU1CT0wocmVzZXJ2YXRpb25fb2JqZWN0X2luaXQpOwo+ICsKPiArLyoq Cj4gKyAqIHJlc2VydmF0aW9uX29iamVjdF9maW5pIC0gZGVzdHJveXMgYSByZXNlcnZhdGlvbiBv YmplY3QKPiArICogQG9iajogdGhlIHJlc2VydmF0aW9uIG9iamVjdAo+ICsgKi8KPiArdm9pZCBy ZXNlcnZhdGlvbl9vYmplY3RfZmluaShzdHJ1Y3QgcmVzZXJ2YXRpb25fb2JqZWN0ICpvYmopCj4g K3sKPiArCWludCBpOwo+ICsJc3RydWN0IHJlc2VydmF0aW9uX29iamVjdF9saXN0ICpmb2JqOwo+ ICsJc3RydWN0IGRtYV9mZW5jZSAqZXhjbDsKPiArCj4gKwkvKgo+ICsJICogVGhpcyBvYmplY3Qg c2hvdWxkIGJlIGRlYWQgYW5kIGFsbCByZWZlcmVuY2VzIG11c3QgaGF2ZQo+ICsJICogYmVlbiBy ZWxlYXNlZCB0byBpdCwgc28gbm8gbmVlZCB0byBiZSBwcm90ZWN0ZWQgd2l0aCByY3UuCj4gKwkg Ki8KPiArCWV4Y2wgPSByY3VfZGVyZWZlcmVuY2VfcHJvdGVjdGVkKG9iai0+ZmVuY2VfZXhjbCwg MSk7Cj4gKwlpZiAoZXhjbCkKPiArCQlkbWFfZmVuY2VfcHV0KGV4Y2wpOwo+ICsKPiArCWZvYmog PSByY3VfZGVyZWZlcmVuY2VfcHJvdGVjdGVkKG9iai0+ZmVuY2UsIDEpOwo+ICsJaWYgKGZvYmop IHsKPiArCQlmb3IgKGkgPSAwOyBpIDwgZm9iai0+c2hhcmVkX2NvdW50OyArK2kpCj4gKwkJCWRt YV9mZW5jZV9wdXQocmN1X2RlcmVmZXJlbmNlX3Byb3RlY3RlZChmb2JqLT5zaGFyZWRbaV0sIDEp KTsKPiArCj4gKwkJa2ZyZWUoZm9iaik7Cj4gKwl9Cj4gKwo+ICsJd3dfbXV0ZXhfZGVzdHJveSgm b2JqLT5sb2NrKTsKPiArfQo+ICtFWFBPUlRfU1lNQk9MKHJlc2VydmF0aW9uX29iamVjdF9maW5p KTsKPiArCj4gIC8qKgo+ICAgKiByZXNlcnZhdGlvbl9vYmplY3RfcmVzZXJ2ZV9zaGFyZWQgLSBS ZXNlcnZlIHNwYWNlIHRvIGFkZCBzaGFyZWQgZmVuY2VzIHRvCj4gICAqIGEgcmVzZXJ2YXRpb25f b2JqZWN0Lgo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3Jlc2VydmF0aW9uLmggYi9pbmNs dWRlL2xpbnV4L3Jlc2VydmF0aW9uLmgKPiBpbmRleCBlZTc1MDc2NWNjOTQuLmY0N2U4MTk2ZDAz OSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2xpbnV4L3Jlc2VydmF0aW9uLmgKPiArKysgYi9pbmNs dWRlL2xpbnV4L3Jlc2VydmF0aW9uLmgKPiBAQCAtODEsNTAgKzgxLDYgQEAgc3RydWN0IHJlc2Vy dmF0aW9uX29iamVjdCB7Cj4gICNkZWZpbmUgcmVzZXJ2YXRpb25fb2JqZWN0X2Fzc2VydF9oZWxk KG9iaikgXAo+ICAJbG9ja2RlcF9hc3NlcnRfaGVsZCgmKG9iaiktPmxvY2suYmFzZSkKPiAgCj4g LS8qKgo+IC0gKiByZXNlcnZhdGlvbl9vYmplY3RfaW5pdCAtIGluaXRpYWxpemUgYSByZXNlcnZh dGlvbiBvYmplY3QKPiAtICogQG9iajogdGhlIHJlc2VydmF0aW9uIG9iamVjdAo+IC0gKi8KPiAt c3RhdGljIGlubGluZSB2b2lkCj4gLXJlc2VydmF0aW9uX29iamVjdF9pbml0KHN0cnVjdCByZXNl cnZhdGlvbl9vYmplY3QgKm9iaikKPiAtewo+IC0Jd3dfbXV0ZXhfaW5pdCgmb2JqLT5sb2NrLCAm cmVzZXJ2YXRpb25fd3dfY2xhc3MpOwo+IC0KPiAtCV9fc2VxY291bnRfaW5pdCgmb2JqLT5zZXEs IHJlc2VydmF0aW9uX3NlcWNvdW50X3N0cmluZywgJnJlc2VydmF0aW9uX3NlcWNvdW50X2NsYXNz KTsKPiAtCVJDVV9JTklUX1BPSU5URVIob2JqLT5mZW5jZSwgTlVMTCk7Cj4gLQlSQ1VfSU5JVF9Q T0lOVEVSKG9iai0+ZmVuY2VfZXhjbCwgTlVMTCk7Cj4gLX0KPiAtCj4gLS8qKgo+IC0gKiByZXNl cnZhdGlvbl9vYmplY3RfZmluaSAtIGRlc3Ryb3lzIGEgcmVzZXJ2YXRpb24gb2JqZWN0Cj4gLSAq IEBvYmo6IHRoZSByZXNlcnZhdGlvbiBvYmplY3QKPiAtICovCj4gLXN0YXRpYyBpbmxpbmUgdm9p ZAo+IC1yZXNlcnZhdGlvbl9vYmplY3RfZmluaShzdHJ1Y3QgcmVzZXJ2YXRpb25fb2JqZWN0ICpv YmopCj4gLXsKPiAtCWludCBpOwo+IC0Jc3RydWN0IHJlc2VydmF0aW9uX29iamVjdF9saXN0ICpm b2JqOwo+IC0Jc3RydWN0IGRtYV9mZW5jZSAqZXhjbDsKPiAtCj4gLQkvKgo+IC0JICogVGhpcyBv YmplY3Qgc2hvdWxkIGJlIGRlYWQgYW5kIGFsbCByZWZlcmVuY2VzIG11c3QgaGF2ZQo+IC0JICog YmVlbiByZWxlYXNlZCB0byBpdCwgc28gbm8gbmVlZCB0byBiZSBwcm90ZWN0ZWQgd2l0aCByY3Uu Cj4gLQkgKi8KPiAtCWV4Y2wgPSByY3VfZGVyZWZlcmVuY2VfcHJvdGVjdGVkKG9iai0+ZmVuY2Vf ZXhjbCwgMSk7Cj4gLQlpZiAoZXhjbCkKPiAtCQlkbWFfZmVuY2VfcHV0KGV4Y2wpOwo+IC0KPiAt CWZvYmogPSByY3VfZGVyZWZlcmVuY2VfcHJvdGVjdGVkKG9iai0+ZmVuY2UsIDEpOwo+IC0JaWYg KGZvYmopIHsKPiAtCQlmb3IgKGkgPSAwOyBpIDwgZm9iai0+c2hhcmVkX2NvdW50OyArK2kpCj4g LQkJCWRtYV9mZW5jZV9wdXQocmN1X2RlcmVmZXJlbmNlX3Byb3RlY3RlZChmb2JqLT5zaGFyZWRb aV0sIDEpKTsKPiAtCj4gLQkJa2ZyZWUoZm9iaik7Cj4gLQl9Cj4gLQo+IC0Jd3dfbXV0ZXhfZGVz dHJveSgmb2JqLT5sb2NrKTsKPiAtfQo+IC0KPiAgLyoqCj4gICAqIHJlc2VydmF0aW9uX29iamVj dF9nZXRfbGlzdCAtIGdldCB0aGUgcmVzZXJ2YXRpb24gb2JqZWN0J3MKPiAgICogc2hhcmVkIGZl bmNlIGxpc3QsIHdpdGggdXBkYXRlLXNpZGUgbG9jayBoZWxkCj4gQEAgLTI2Nyw2ICsyMjMsOCBA QCByZXNlcnZhdGlvbl9vYmplY3RfZ2V0X2V4Y2xfcmN1KHN0cnVjdCByZXNlcnZhdGlvbl9vYmpl Y3QgKm9iaikKPiAgCXJldHVybiBmZW5jZTsKPiAgfQo+ICAKPiArdm9pZCByZXNlcnZhdGlvbl9v YmplY3RfaW5pdChzdHJ1Y3QgcmVzZXJ2YXRpb25fb2JqZWN0ICpvYmopOwo+ICt2b2lkIHJlc2Vy dmF0aW9uX29iamVjdF9maW5pKHN0cnVjdCByZXNlcnZhdGlvbl9vYmplY3QgKm9iaik7Cj4gIGlu dCByZXNlcnZhdGlvbl9vYmplY3RfcmVzZXJ2ZV9zaGFyZWQoc3RydWN0IHJlc2VydmF0aW9uX29i amVjdCAqb2JqLAo+ICAJCQkJICAgICAgdW5zaWduZWQgaW50IG51bV9mZW5jZXMpOwo+ICB2b2lk IHJlc2VydmF0aW9uX29iamVjdF9hZGRfc2hhcmVkX2ZlbmNlKHN0cnVjdCByZXNlcnZhdGlvbl9v YmplY3QgKm9iaiwKPiAtLSAKPiAyLjE3LjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=