From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel Date: Thu, 8 Aug 2019 16:09:04 -0700 Message-ID: <201908081608.A4F6711@keescook> References: <20190724140212.qzvbcx5j2gi5lcoj@willie-the-truck> <20190724142059.GC21234@fuggles.cambridge.arm.com> <20190806171335.4dzjex5asoertaob@willie-the-truck> <201908081410.C16D2BD@keescook> <20190808153300.09d3eb80772515f0ea062833@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190808153300.09d3eb80772515f0ea062833@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Morton Cc: Andrey Konovalov , Will Deacon , Will Deacon , Vincenzo Frascino , Catalin Marinas , Mark Rutland , kvm@vger.kernel.org, Szabolcs Nagy , dri-devel@lists.freedesktop.org, Kostya Serebryany , Khalid Aziz , "open list:KERNEL SELFTEST FRAMEWORK" , Felix Kuehling , Jacob Bramley , Leon Romanovsky , linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , Linux ARM List-Id: amd-gfx.lists.freedesktop.org On Thu, Aug 08, 2019 at 03:33:00PM -0700, Andrew Morton wrote: > On Thu, 8 Aug 2019 14:12:19 -0700 Kees Cook wrote: > > > > The ones that are left are the mm ones: 4, 5, 6, 7 and 8. > > > > > > Andrew, could you take a look and give your Acked-by or pick them up directly? > > > > Given the subsystem Acks, it seems like 3-10 and 12 could all just go > > via Andrew? I hope he agrees. :) > > I'll grab everything that has not yet appeared in linux-next. If more > of these patches appear in linux-next I'll drop those as well. > > The review discussion against " [PATCH v19 02/15] arm64: Introduce > prctl() options to control the tagged user addresses ABI" has petered > out inconclusively. prctl() vs arch_prctl(). I've always disliked arch_prctl() existing at all. Given that tagging is likely to be a multi-architectural feature, it seems like the controls should live in prctl() to me. -- Kees Cook