From: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH 3/3] drm/amd/display: update bw_calcs to take pipe sync into account (v2)
Date: Thu, 22 Aug 2019 10:36:45 -0500 [thread overview]
Message-ID: <20190822153645.3296-4-alexander.deucher@amd.com> (raw)
In-Reply-To: <20190822153645.3296-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
Properly set all_displays_in_sync so that when the data is
propagated to powerplay, it's set properly and we can enable
mclk switching when all monitors are in sync.
v2: fix logic, clean up
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
.../gpu/drm/amd/display/dc/calcs/dce_calcs.c | 49 ++++++++++++++++++-
1 file changed, 47 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
index 9f12e21f8b9b..8d904647fb0f 100644
--- a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
+++ b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
@@ -25,6 +25,7 @@
#include <linux/slab.h>
+#include "resource.h"
#include "dm_services.h"
#include "dce_calcs.h"
#include "dc.h"
@@ -2977,6 +2978,50 @@ static void populate_initial_data(
data->number_of_displays = num_displays;
}
+static bool all_displays_in_sync(const struct pipe_ctx pipe[],
+ int pipe_count,
+ uint32_t number_of_displays)
+{
+ const struct pipe_ctx *unsynced_pipes[MAX_PIPES] = { NULL };
+ int group_size = 1;
+ int i, j;
+
+ for (i = 0; i < pipe_count; i++) {
+ if (!pipe[i].stream)
+ continue;
+
+ unsynced_pipes[i] = &pipe[i];
+ }
+
+ for (i = 0; i < pipe_count; i++) {
+ const struct pipe_ctx *pipe_set[MAX_PIPES];
+
+ if (!unsynced_pipes[i])
+ continue;
+
+ pipe_set[0] = unsynced_pipes[i];
+ unsynced_pipes[i] = NULL;
+
+ /* Add tg to the set, search rest of the tg's for ones with
+ * same timing, add all tgs with same timing to the group
+ */
+ for (j = i + 1; j < pipe_count; j++) {
+ if (!unsynced_pipes[j])
+ continue;
+
+ if (resource_are_streams_timing_synchronizable(
+ unsynced_pipes[j]->stream,
+ pipe_set[0]->stream)) {
+ pipe_set[group_size] = unsynced_pipes[j];
+ unsynced_pipes[j] = NULL;
+ group_size++;
+ }
+ }
+ }
+
+ return (group_size == number_of_displays) ? true : false;
+}
+
/**
* Return:
* true - Display(s) configuration supported.
@@ -2998,8 +3043,8 @@ bool bw_calcs(struct dc_context *ctx,
populate_initial_data(pipe, pipe_count, data);
- /*TODO: this should be taken out calcs output and assigned during timing sync for pplib use*/
- calcs_output->all_displays_in_sync = false;
+ calcs_output->all_displays_in_sync = all_displays_in_sync(pipe, pipe_count,
+ data->number_of_displays);
if (data->number_of_displays != 0) {
uint8_t yclk_lvl, sclk_lvl;
--
2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-08-22 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 15:36 [PATCH 0/3] Support mclk switching when monitors are in sync Alex Deucher
[not found] ` <20190822153645.3296-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-08-22 15:36 ` [PATCH 1/3] drm/amdgpu/powerplay/smu7: enable mclk switching if monitors are synced Alex Deucher
2019-08-22 15:36 ` [PATCH 2/3] drm/amdgpu/powerplay/vega10: " Alex Deucher
2019-08-22 15:36 ` Alex Deucher [this message]
[not found] ` <20190822153645.3296-4-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-08-22 16:25 ` [PATCH 3/3] drm/amd/display: update bw_calcs to take pipe sync into account (v2) Kazlauskas, Nicholas
[not found] ` <6c011b85-27c8-4ff5-12b5-4d034878c916-5C7GfCeVMHo@public.gmane.org>
2019-08-22 16:31 ` Alex Deucher
[not found] ` <CADnq5_MmDXmchA=WoQpKzkFp0+WpVDSOoBMqqo8pppB9ky_AvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-08-22 16:35 ` Kazlauskas, Nicholas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822153645.3296-4-alexander.deucher@amd.com \
--to=alexdeucher-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox