From: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
Tom St Denis <tom.stdenis-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH 2/2] drm/amdgpu: disable MSI-X on APUs
Date: Thu, 3 Oct 2019 09:13:26 -0500 [thread overview]
Message-ID: <20191003141326.7600-2-alexander.deucher@amd.com> (raw)
In-Reply-To: <20191003141326.7600-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
Raven claims to support them, but seems to have problems. Stick
with MSIs for now on APUs.
Tested-by: Tom St Denis <tom.stdenis@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
index 98aa28edba6a..8f2236bd7d0e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
@@ -248,7 +248,8 @@ int amdgpu_irq_init(struct amdgpu_device *adev)
unsigned int flags;
int nvec = pci_msix_vec_count(adev->pdev);
- if (nvec <= 0) {
+ /* Raven claims to support MSI-X, but seems to have problems */
+ if ((nvec <= 0) || (adev->flags & AMD_IS_APU)) {
flags = PCI_IRQ_MSI;
nvec = 1;
} else {
--
2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-10-03 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 14:13 [PATCH 1/2] drm/amdgpu: improve MSI-X handling Alex Deucher
[not found] ` <20191003141326.7600-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-10-03 14:13 ` Alex Deucher [this message]
[not found] ` <20191003141326.7600-2-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-10-03 14:27 ` [PATCH 2/2] drm/amdgpu: disable MSI-X on APUs Liu, Shaoyun
2019-10-03 15:07 ` [PATCH 1/2] drm/amdgpu: improve MSI-X handling Huang, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003141326.7600-2-alexander.deucher@amd.com \
--to=alexdeucher-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=tom.stdenis-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox