AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: xinhui pan <xinhui.pan@amd.com>
To: amd-gfx@lists.freedesktop.org
Cc: xinhui pan <xinhui.pan@amd.com>
Subject: [PATCH v4 0/2] fix gmc page fault on navi1X
Date: Sat, 14 Mar 2020 00:09:31 +0800	[thread overview]
Message-ID: <20200313160933.10394-1-xinhui.pan@amd.com> (raw)

We hit gmc page fault on navi1X.
UMR tells that the physical address of pte is bad.

Two issues:
1) we did not sync job schedule fence while update mapping.
fix it by adding bo fence to resv after every job submit.

2) we might unref page table bo during update ptes, at the same time, there
is job pending on bo. and submit a job in commit after free bo.
We need free the bo after adding all fence to bo.

change from v3:
use vm to get root bo resv.
add vm zombies list head.

change from v2:
use the correct page table bo resv

change from v1:
fix rebase issue.

xinhui pan (2):
  drm_amdgpu: Add job fence to resv conditionally
  drm/amdgpu: unref pt bo after job submit

 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c      | 24 ++++++++++++++++++---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h      |  3 +++
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c |  4 +++-
 3 files changed, 27 insertions(+), 4 deletions(-)

-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

             reply	other threads:[~2020-03-13 16:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13 16:09 xinhui pan [this message]
2020-03-13 16:09 ` [PATCH v4 1/2] drm_amdgpu: Add job fence to resv conditionally xinhui pan
2020-03-13 16:09 ` [PATCH v4 2/2] drm/amdgpu: unref pt bo after job submit xinhui pan
2020-03-13 17:36   ` Felix Kuehling
2020-03-13 18:05     ` Christian König
2020-03-14 13:06       ` Pan, Xinhui
2020-03-16  8:15         ` Tao, Yintian
2020-03-16  9:51           ` Pan, Xinhui
2020-03-16  9:54             ` Tao, Yintian
2020-03-16 12:15           ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200313160933.10394-1-xinhui.pan@amd.com \
    --to=xinhui.pan@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox