From: Johannes Hirte <johannes.hirte@datenkhaos.de>
To: Prike Liang <Prike.Liang@amd.com>
Cc: Xinhui.Pan@amd.com, Rahul.Kumar1@amd.com, ray.huang@amd.com,
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: fix the hw hang during perform system reboot and reset
Date: Mon, 13 Apr 2020 18:46:13 +0200 [thread overview]
Message-ID: <20200413164613.GA2148@latitude> (raw)
In-Reply-To: <1586790530-19464-1-git-send-email-Prike.Liang@amd.com>
On 2020 Apr 13, Prike Liang wrote:
> Unify set device CGPG to ungate state before enter poweroff or reset.
>
> Signed-off-by: Prike Liang <Prike.Liang@amd.com>
> Tested-by: Mengbing Wang <Mengbing.Wang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 87f7c12..bbe090a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2413,6 +2413,8 @@ static int amdgpu_device_ip_suspend_phase1(struct amdgpu_device *adev)
> {
> int i, r;
>
> + amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE);
> + amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE);
>
> for (i = adev->num_ip_blocks - 1; i >= 0; i--) {
> if (!adev->ip_blocks[i].status.valid)
> --
> 2.7.4
>
I can confirm that this fixes the shutdown/reboot hang on my raven.
--
Regards,
Johannes Hirte
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-04-13 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 15:08 [PATCH] drm/amdgpu: fix the hw hang during perform system reboot and reset Prike Liang
2020-04-13 15:14 ` Alex Deucher
2020-04-13 18:17 ` Paul Menzel
2020-04-13 20:32 ` Alex Deucher
2020-04-14 2:06 ` Liang, Prike
2020-04-13 16:46 ` Johannes Hirte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413164613.GA2148@latitude \
--to=johannes.hirte@datenkhaos.de \
--cc=Prike.Liang@amd.com \
--cc=Rahul.Kumar1@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox