From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Quan, Evan" <Evan.Quan@amd.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: address the static checker warnings
Date: Tue, 28 Apr 2020 14:01:36 +0300 [thread overview]
Message-ID: <20200428110135.GA1992@kadam> (raw)
In-Reply-To: <DM6PR12MB261984ABA35E54EBFE1CA521E4AC0@DM6PR12MB2619.namprd12.prod.outlook.com>
On Tue, Apr 28, 2020 at 02:31:12AM +0000, Quan, Evan wrote:
> Ping..
Are you asking me? It's really hard for me to read your emails.
Normally email clients put "> " in front of the quoted parts of the
email. Your email client doesn't line wrap at 72 characters either. :(
> [Evan] No, that's true for SGPU setup only. For XGMI setup(multiple dgpus interconnected with bridges), the "hive" here is not NULL.
Presumably you are talking about out of tree code so I can't comment
on this. In the current linux-next we know that amdgpu_device_lock_adev()
will only return false when "hive" is NULL.
regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-04-28 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 10:41 [PATCH] drm/amdgpu: address the static checker warnings Evan Quan
2020-04-24 11:02 ` Dan Carpenter
2020-04-26 3:18 ` Quan, Evan
2020-04-28 2:31 ` Quan, Evan
2020-04-28 11:01 ` Dan Carpenter [this message]
2020-04-29 2:32 ` Quan, Evan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428110135.GA1992@kadam \
--to=dan.carpenter@oracle.com \
--cc=Alexander.Deucher@amd.com \
--cc=Evan.Quan@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox