From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71518C433E2 for ; Tue, 1 Sep 2020 10:34:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AA122083B for ; Tue, 1 Sep 2020 10:34:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Qqnyi90e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AA122083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B73106E296; Tue, 1 Sep 2020 10:34:06 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A4746E296 for ; Tue, 1 Sep 2020 10:34:05 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id z1so936530wrt.3 for ; Tue, 01 Sep 2020 03:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=jKyzOb5SSjLTlidGXj8nXzunjb6G7Xj1PMn/IF7Kh0Q=; b=Qqnyi90epWKP7jewklh6e9RqunmvmQed0dKzS7CXCIVEkImfyXoD6VtIpPFDWTw9x4 /I8UiTnWNBVYyd/F7rLaSu7grnq8YFxbwQprL6snyFJnWBrP+9mjyeG9AayJelNTylxG 8fnJcXzhNavwJhm4Rrp+xe5KF7vrXkFXr3afo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=jKyzOb5SSjLTlidGXj8nXzunjb6G7Xj1PMn/IF7Kh0Q=; b=tF0boB8/FpG5W+lemvKSwN554GLaMwOci8MqtbMe2S95vlABNoRghUZUjE2nfTD8v7 dqa6ZyRETO1zQieQZSvvWRX6ljLGgefOW6VMgtQeFz+ThnROzLnke5GWbOX5fgCtu25A l6vMzDMWwCfq/Od+ofQf+elWjXtez5uyDH1nKYNPaUHLr/9fFb2Di40/ZDw5yFUHCeQ5 xc6jsORom8G1OeQ1ZAymlSSx7Fuit7Bi4y11cUSzRnvl7/8Me0jsDUqJNgYfG7PTdDLg 75C4m8l7fDNqY9ZwnLVKkyXsEhmhn/P+ZzVM11lx1huaATaeItjmdn3C0zlaxfkPDNYl +dzw== X-Gm-Message-State: AOAM530leQ4H6MxJQRX4Na7K/HXe7IKkiUmVPGp7YWTrluXv0QjqUH6g DbZdwwrd8HEmTw+NyPj0d53aYg== X-Google-Smtp-Source: ABdhPJwX3BtpzPEM8bwIoBP6M24mJ4sxhTaPj5GAjfsE+Vc7Wf+oU9kCjsGF8ynZ4dKIOy50GyyzLA== X-Received: by 2002:adf:ec08:: with SMTP id x8mr1086804wrn.235.1598956444120; Tue, 01 Sep 2020 03:34:04 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id v4sm1167712wml.46.2020.09.01.03.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 03:34:03 -0700 (PDT) Date: Tue, 1 Sep 2020 12:34:01 +0200 From: Daniel Vetter To: Michel =?iso-8859-1?Q?D=E4nzer?= Subject: Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is Message-ID: <20200901103401.GA2352366@phenom.ffwll.local> References: <20200821165758.1106210-1-michel@daenzer.net> <58dc5ed0-307e-74c9-1a8b-1e998be04900@amd.com> <91391bb3-a855-1a29-2d2e-a31856c99946@daenzer.net> <20200824104327.559503f7@eldfell> <20200901075719.GX2352366@phenom.ffwll.local> <52d558d2-3277-716f-6386-b8b90e6f41d3@daenzer.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <52d558d2-3277-716f-6386-b8b90e6f41d3@daenzer.net> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , dri-devel@lists.freedesktop.org, Pekka Paalanen , amd-gfx@lists.freedesktop.org, Daniel Vetter , "Kazlauskas, Nicholas" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, Sep 01, 2020 at 10:56:42AM +0200, Michel D=E4nzer wrote: > On 2020-09-01 9:57 a.m., Daniel Vetter wrote: > > On Tue, Aug 25, 2020 at 04:55:28PM +0200, Michel D=E4nzer wrote: > >> On 2020-08-24 9:43 a.m., Pekka Paalanen wrote: > >> = > >>> Sounds like the helpers you refer to are inadequate for your case. > >>> Can't you fix the helpers in the long run and land this patch as an > >>> immediate fix? > >> = > >> I'd rather leave working on those helpers to KMS developers. :) > > = > > I thought the issue is the rmfb ioctl trickery, which has this assumpti= on > > fully backed in. The wiggle room in there for semantic changes is iirc > > pretty much nil, it took us a pile of patches to just get to the current > > state. So it's not helper code, it's core legacy ioctl code for atomic > > drivers. > = > My bad. Should I respin with an amended commit log? Yeah if it's not yet merged then I think would be good to clarify that this assumption is baked into rmfb, and that together with the assumption the the legacy cursor ioctls just work we have fallout. If (and hey I've been on vacations for 2 weeks, so good chances I remebers this all wrong) this is indeed what we discussed a few weeks ago. Cheers, Daniel -- = Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx