From: Christoph Hellwig <hch@lst.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: amd-gfx@lists.freedesktop.org, stable@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
dri-devel@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
christian.koenig@amd.com
Subject: Re: [PATCH] Revert "drm/radeon: handle PCIe root ports with addressing limitations"
Date: Wed, 16 Sep 2020 09:04:36 +0200 [thread overview]
Message-ID: <20200916070436.GA9392@lst.de> (raw)
In-Reply-To: <20200915184607.84435-1-alexander.deucher@amd.com>
On Tue, Sep 15, 2020 at 02:46:07PM -0400, Alex Deucher wrote:
> This change breaks tons of systems.
Did you do at least some basic root causing on why? Do GPUs get
fed address they can't deal with? Any examples?
Bug 1 doesn't seem to contain any analysis and was reported against
a very old kernel that had all kind of fixes since.
Bug 2 seems to imply a drm kthread is accessing some structure it
shouldn't, which would imply a mismatch between pools used by radeon
now and those actually provided by the core. Something that should
be pretty to trivial to fix for someone understanding the whole ttm
pool maze.
Bug 3: same as 1, but an even older kernel.
Bug 4: looks like 1 and 3, and actually verified to work properly
in 5.9-rc. Did you try to get the other reporters test this as well?
All over not a very useful changelog.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-09-16 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 18:46 [PATCH] Revert "drm/radeon: handle PCIe root ports with addressing limitations" Alex Deucher
2020-09-16 6:33 ` Greg KH
2020-09-16 9:59 ` Daniel Vetter
2020-09-16 13:08 ` Alex Deucher
2020-09-16 7:04 ` Christoph Hellwig [this message]
2020-09-16 22:16 ` Alex Deucher
2020-09-17 17:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916070436.GA9392@lst.de \
--to=hch@lst.de \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox