From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AE79C43461 for ; Wed, 16 Sep 2020 09:59:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40956221E8 for ; Wed, 16 Sep 2020 09:59:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="b5lDIFgq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40956221E8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD9216E393; Wed, 16 Sep 2020 09:59:31 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CC9F6E37F for ; Wed, 16 Sep 2020 09:59:30 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id z4so6251530wrr.4 for ; Wed, 16 Sep 2020 02:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3+5MUINgS/3kXupUIpF5UdrtH6x938/qY5ueTCYuS7A=; b=b5lDIFgqmTLviC3gjjGxPQgnNyy7XbQrAKuUwxP7Ku2nwztn3YYPq4PyP1978qIyYk aZ9aF1s/XUmkYigIJofHDOR5G0Pm5UgjznZZPJvg+Q74Bp4CxPB+YI2qHnfTpJ0AAkYL cl6HbP8W6pCUhLbAVWlNOwhI6qy54eZgYNgc0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3+5MUINgS/3kXupUIpF5UdrtH6x938/qY5ueTCYuS7A=; b=rXI5LaF24LiNLr9FCY5tYjJkdIai9EPjbMIBYG4z6s5ADMxmjeqe/qcb5unFqKnIxC 7mAykLQHe2USqJxnCbSXJGXFqH1lbZeGINzV2LWh5raGm9zFksMaZu9lnjQSbVoMYXg/ 1T6Sg4smI7Q8fHdkZH77RMaSWuri4FDHSgGmYfSfV6nPF5dFZOHpZMaPQ+9Fg8PYSEMU +IpQvpXPpFAgnspdR06/jxBcUu0oJmCoUh4DCJLSDf9J3BNRem4A0k5/Ejlny0YyTYxQ tcuHq3FXrmPukuhchGVdOeW612iFjdJeZUEq2pfu9f0Zvnwq1e2PN3S1DMzwVgOIj5yO dVLg== X-Gm-Message-State: AOAM530NYUk2DjUC9b11MSye8zNUbGTBjpgYHuVCn6GEYzx3cXfcWquK XvyG64cTWcJbLO3p/upTqbl6ng== X-Google-Smtp-Source: ABdhPJx4rSat5jYIT6/IV5uxY2B7ojnvbYPfcJNaB1zF5LC7sG7GGRH9n5yFXUAfnCZDnFw96E4KSQ== X-Received: by 2002:a5d:608f:: with SMTP id w15mr2952652wrt.244.1600250369082; Wed, 16 Sep 2020 02:59:29 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id o16sm30112339wrp.52.2020.09.16.02.59.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 02:59:28 -0700 (PDT) Date: Wed, 16 Sep 2020 11:59:26 +0200 From: Daniel Vetter To: Greg KH Subject: Re: [PATCH] Revert "drm/radeon: handle PCIe root ports with addressing limitations" Message-ID: <20200916095926.GE438822@phenom.ffwll.local> References: <20200915184607.84435-1-alexander.deucher@amd.com> <20200916063300.GJ142621@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200916063300.GJ142621@kroah.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, christian.koenig@amd.com, Alex Deucher , stable@vger.kernel.org, Alex Deucher , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, Sep 16, 2020 at 08:33:00AM +0200, Greg KH wrote: > On Tue, Sep 15, 2020 at 02:46:07PM -0400, Alex Deucher wrote: > > This change breaks tons of systems. > > Very vague :( > > This commit has also been merged for over a year, why the sudden > problem now? Unrelated rant, but one year is generally what it takes for most users to upgrade to new kernels, through their distro updates. Especially for older hw like the radeon drivers (since 5 years or so amd gpus switched over to amdgpu.ko). So surprise that bugs only show up after 1+ year shouldn't be a surprise :-) My personal rule is that I put a 1 year spacer between a risky change and any cleanup that enables. Too many regrets in the past. Cheers, Daniel > > > This reverts commit 33b3ad3788aba846fc8b9a065fe2685a0b64f713. > > You mean "33b3ad3788ab ("drm/radeon: handle PCIe root ports with > addressing limitations")"? > > That's the proper way to reference commits in changelogs please. It's > even documented that way... > > > > > Bug: https://bugzilla.kernel.org/show_bug.cgi?id=206973 > > Bug: https://bugzilla.kernel.org/show_bug.cgi?id=206697 > > Bug: https://bugzilla.kernel.org/show_bug.cgi?id=207763 > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1140 > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1287 > > Signed-off-by: Alex Deucher > > Cc: stable@vger.kernel.org > > Cc: Christoph Hellwig > > Cc: christian.koenig@amd.com > > Fixes: 33b3ad3788ab ("drm/radeon: handle PCIe root ports with addressing limitations") > > as well? > > thanks, > > greg k-h > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx