From: Huang Rui <ray.huang@amd.com>
To: amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>,
Xiaomeng Hou <Xiaomeng.Hou@amd.com>,
Huang Rui <ray.huang@amd.com>, Aaron Liu <aaron.liu@amd.com>,
Xiaojian Du <xiaojian.du@amd.com>
Subject: [PATCH 2/7] drm/amd/pm: enhance the real response for smu message
Date: Fri, 8 Jan 2021 16:55:02 +0800 [thread overview]
Message-ID: <20210108085507.1164588-3-ray.huang@amd.com> (raw)
In-Reply-To: <20210108085507.1164588-1-ray.huang@amd.com>
The user prefers to know the real response value from C2PMSG 90 register
which is written by firmware not -EIO.
Signed-off-by: Huang Rui <ray.huang@amd.com>
---
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index f8260769061c..42b125701436 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -111,6 +111,7 @@ int smu_cmn_send_smc_msg_with_param(struct smu_context *smu,
{
struct amdgpu_device *adev = smu->adev;
int ret = 0, index = 0;
+ int response;
if (smu->adev->in_pci_err_recovery)
return 0;
@@ -137,8 +138,9 @@ int smu_cmn_send_smc_msg_with_param(struct smu_context *smu,
ret = smu_cmn_wait_for_response(smu);
if (ret) {
+ response = RREG32_SOC15_NO_KIQ(MP1, 0, mmMP1_SMN_C2PMSG_90);
dev_err(adev->dev, "failed send message: %10s (%d) \tparam: 0x%08x response %#x\n",
- smu_get_message_name(smu, msg), index, param, ret);
+ smu_get_message_name(smu, msg), index, param, response);
goto out;
}
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-01-08 8:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 8:55 [PATCH 0/7] implement the processor fine grain feature for vangogh Huang Rui
2021-01-08 8:55 ` [PATCH 1/7] drm/amd/pm: remove vcn/jpeg powergating feature checking " Huang Rui
2021-01-08 8:55 ` Huang Rui [this message]
2021-01-08 10:02 ` [PATCH 2/7] drm/amd/pm: enhance the real response for smu message Quan, Evan
2021-01-08 8:55 ` [PATCH 3/7] drm/amd/pm: clean up get_allowed_feature_mask function Huang Rui
2021-01-08 8:55 ` [PATCH 4/7] drm/amd/pm: initial feature_enabled/feature_support bitmap for vangogh Huang Rui
2021-01-08 8:55 ` [PATCH 5/7] drm/amd/pm: don't mark all apu as true on feature mask Huang Rui
2021-01-08 8:55 ` [PATCH 6/7] drm/amd/pm: implement the processor clocks which read by metric Huang Rui
2021-01-08 10:03 ` Quan, Evan
2021-01-08 8:55 ` [PATCH 7/7] drm/amd/pm: implement processor fine grain feature for vangogh Huang Rui
2021-01-08 10:01 ` Quan, Evan
2021-01-08 10:12 ` Huang Rui
2021-01-08 10:59 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108085507.1164588-3-ray.huang@amd.com \
--to=ray.huang@amd.com \
--cc=Xiaomeng.Hou@amd.com \
--cc=aaron.liu@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=xiaojian.du@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox