From: YuBiao Wang <YuBiao.Wang@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: "Andrey Grodzovsky" <Andrey.Grodzovsky@amd.com>,
"Evan Quan" <Evan.Quan@amd.com>,
horace.chen@amd.com, "Tuikov Luben" <Luben.Tuikov@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Deucher Alexander" <Alexander.Deucher@amd.com>,
"Jack Xiao" <Jack.Xiao@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Monk Liu" <Monk.Liu@amd.com>, "Feifei Xu" <Feifei.Xu@amd.com>,
"Kevin Wang" <Kevin1.Wang@amd.com>,
"YuBiao Wang" <YuBiao.Wang@amd.com>
Subject: [PATCH] drm/amd/amdgpu: skip locking delayed work if not initialized.
Date: Thu, 5 Aug 2021 10:37:36 +0800 [thread overview]
Message-ID: <20210805023736.699291-1-YuBiao.Wang@amd.com> (raw)
When init failed in early init stage, amdgpu_object has
not been initialized, so hasn't the ttm delayed queue functions.
Signed-off-by: YuBiao Wang <YuBiao.Wang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 9e53ff851496..4c33985542ed 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3825,7 +3825,8 @@ void amdgpu_device_fini_hw(struct amdgpu_device *adev)
{
dev_info(adev->dev, "amdgpu: finishing device.\n");
flush_delayed_work(&adev->delayed_init_work);
- ttm_bo_lock_delayed_workqueue(&adev->mman.bdev);
+ if (adev->mman.initialized)
+ ttm_bo_lock_delayed_workqueue(&adev->mman.bdev);
adev->shutdown = true;
/* make sure IB test finished before entering exclusive mode
--
2.25.1
next reply other threads:[~2021-08-05 2:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 2:37 YuBiao Wang [this message]
2021-08-05 12:35 ` [PATCH] drm/amd/amdgpu: skip locking delayed work if not initialized Christian König
2021-08-06 6:01 ` Wang, YuBiao
2021-08-09 9:49 ` Deng, Emily
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210805023736.699291-1-YuBiao.Wang@amd.com \
--to=yubiao.wang@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Andrey.Grodzovsky@amd.com \
--cc=Evan.Quan@amd.com \
--cc=Feifei.Xu@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jack.Xiao@amd.com \
--cc=Kevin1.Wang@amd.com \
--cc=Luben.Tuikov@amd.com \
--cc=Monk.Liu@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=horace.chen@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox