From: Harry Wentland <harry.wentland@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <ndesaulniers@google.com>, <torvalds@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <arnd@kernel.org>,
<sunpeng.li@amd.com>, <alexander.deucher@amd.com>,
<christian.koenig@amd.com>, <Xinhui.Pan@amd.com>,
<nathan@kernel.org>, <linux@roeck-us.net>, <llvm@lists.linux.dev>,
Harry Wentland <harry.wentland@amd.com>
Subject: [PATCH 0/4] Fix stack usage of DML
Date: Wed, 8 Sep 2021 21:00:19 -0400 [thread overview]
Message-ID: <20210909010023.29110-1-harry.wentland@amd.com> (raw)
With the '-Werror' enablement patch the amdgpu build was failing
on clang builds because a bunch of functions were blowing past
the 1024 byte stack frame default. Due to this we also noticed
that a lot of functions were passing large structs by value
instead of by pointer.
This series attempts to fix this.
There is still one remaining function that blows the 1024 limit by 40 bytes:
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:3397:6:
error: stack frame size of 1064 bytes in function
'dml21_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe-larger-than=]
This will be a slightly more challenging fix but I'll see if we can get it
below 1024 by breaking it into smaller functions.
With this series I can build amdgpu with CC=clang and a stack frame limit of
1064.
This series boots on a Radeon RX 5500 XT.
Harry Wentland (4):
drm/amd/display: Pass display_pipe_params_st as const in DML
drm/amd/display: Pass all structs in display_rq_dlg_helpers by pointer
drm/amd/display: Fix rest of pass-by-value structs in DML
drm/amd/display: Allocate structs needed by dcn_bw_calc_rq_dlg_ttu in
pipe_ctx
.../gpu/drm/amd/display/dc/calcs/dcn_calcs.c | 55 ++--
.../drm/amd/display/dc/dcn20/dcn20_resource.c | 2 +-
.../dc/dml/dcn20/display_rq_dlg_calc_20.c | 158 +++++------
.../dc/dml/dcn20/display_rq_dlg_calc_20.h | 4 +-
.../dc/dml/dcn20/display_rq_dlg_calc_20v2.c | 156 +++++------
.../dc/dml/dcn20/display_rq_dlg_calc_20v2.h | 4 +-
.../dc/dml/dcn21/display_rq_dlg_calc_21.c | 156 +++++------
.../dc/dml/dcn21/display_rq_dlg_calc_21.h | 4 +-
.../dc/dml/dcn30/display_rq_dlg_calc_30.c | 132 ++++-----
.../dc/dml/dcn30/display_rq_dlg_calc_30.h | 4 +-
.../dc/dml/dcn31/display_rq_dlg_calc_31.c | 166 ++++++------
.../dc/dml/dcn31/display_rq_dlg_calc_31.h | 4 +-
.../drm/amd/display/dc/dml/display_mode_lib.h | 4 +-
.../display/dc/dml/display_rq_dlg_helpers.c | 256 +++++++++---------
.../display/dc/dml/display_rq_dlg_helpers.h | 20 +-
.../display/dc/dml/dml1_display_rq_dlg_calc.c | 246 ++++++++---------
.../display/dc/dml/dml1_display_rq_dlg_calc.h | 10 +-
.../gpu/drm/amd/display/dc/inc/core_types.h | 3 +
18 files changed, 695 insertions(+), 689 deletions(-)
--
2.33.0
next reply other threads:[~2021-09-09 1:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 1:00 Harry Wentland [this message]
2021-09-09 1:00 ` [PATCH 1/4] drm/amd/display: Pass display_pipe_params_st as const in DML Harry Wentland
2021-09-15 23:21 ` [1/4] " Anson Jacob
2021-09-09 1:00 ` [PATCH 2/4] drm/amd/display: Pass all structs in display_rq_dlg_helpers by pointer Harry Wentland
2021-09-15 23:23 ` [2/4] " Anson Jacob
2021-09-09 1:00 ` [PATCH 3/4] drm/amd/display: Fix rest of pass-by-value structs in DML Harry Wentland
2021-09-15 23:24 ` [3/4] " Anson Jacob
2021-09-09 1:00 ` [PATCH 4/4] drm/amd/display: Allocate structs needed by dcn_bw_calc_rq_dlg_ttu in pipe_ctx Harry Wentland
2021-09-09 8:04 ` [PATCH 0/4] Fix stack usage of DML Christian König
2021-09-09 21:53 ` Nathan Chancellor
2021-09-15 21:58 ` Leo Li
-- strict thread matches above, loose matches on Subject: below --
2021-09-09 0:30 Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909010023.29110-1-harry.wentland@amd.com \
--to=harry.wentland@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arnd@kernel.org \
--cc=christian.koenig@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sunpeng.li@amd.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox