From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED31DC43217 for ; Fri, 25 Feb 2022 01:27:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A2F610E195; Fri, 25 Feb 2022 01:27:05 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 81C0E10E14A; Fri, 25 Feb 2022 01:27:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0C66A60EDA; Fri, 25 Feb 2022 01:27:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 424C8C340E9; Fri, 25 Feb 2022 01:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645752422; bh=85HLwqlMewbSTrfjrAGqrkfIdSjqXwp0JPp7/aV8oao=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=CWeHyaMrKSdImi6hOg4U9noz6tqzKHIZUjH13gF9g3nF6NbTkZgECjc47NFg6M1Re TQaJK3/EtRRbNXIBNiv0ItbHzqW516lHT581oit2EAjSdgX0YLN9bnUnKaz1GZry7d EE4wsswMdhEE2ZdOqOIE7L1GRaycVqFECVFq76nAPCI809gYnzZLTeUpfJwmdgyDwu gXDpO7Bydtp+mXExg8f7vlIkWi5YYsOfrpWPOr7PK+Qg4dqRvTFwCPKZe3df1XblYT oF0Gg1ybQvZIO2BGvcpeh5efMlC16fMdYbfHBWM49HVaE9KiOzweoX4xFgmWySDmQ2 Po/3tKeCF+sJg== Date: Thu, 24 Feb 2022 19:27:00 -0600 From: Bjorn Helgaas To: Mario Limonciello Subject: Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core Message-ID: <20220225012700.GA319379@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220225012346.GA317859@bhelgaas> X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Jamet , "open list:PCI SUBSYSTEM" , "open list:THUNDERBOLT DRIVER" , Yehezkel Bernat , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:X86 PLATFORM DRIVERS" , Andreas Noever , Lukas Wunner , "open list:DRM DRIVERS" , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , Bjorn Helgaas , Alexander.Deucher@amd.com, Mika Westerberg Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Thu, Feb 24, 2022 at 07:23:49PM -0600, Bjorn Helgaas wrote: > On Thu, Feb 24, 2022 at 03:51:12PM -0600, Mario Limonciello wrote: > > The `is_thunderbolt` attribute originally had a well defined list of > > quirks that it existed for, but it has been overloaded with more > > meaning. > > > > Instead use the driver core removable attribute to indicate the > > detail a device is attached to a thunderbolt or USB4 chain. > ... > If these things are not specifically related to Thunderbolt, I'd > prefer to get rid of pci_is_thunderbolt_attached() and see if we can > help the GPU folks figure out what they really need. Ah. Guess I should read the whole series before commenting :) I see that you *did* remove pci_is_thunderbolt_attached() in the last patch. I'll look more at the rest tomorrow. Bjorn