From: Alex Deucher <alexander.deucher@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: Lijo Lazar <lijo.lazar@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Evan Quan <evan.quan@amd.com>
Subject: [PATCH] drm/amd/pm: correct SMU OverridePcieParameters related settings
Date: Thu, 28 Apr 2022 17:29:45 -0400 [thread overview]
Message-ID: <20220428212946.700296-11-alexander.deucher@amd.com> (raw)
In-Reply-To: <20220428212946.700296-1-alexander.deucher@amd.com>
From: Evan Quan <evan.quan@amd.com>
Correct the hw initialization sequence.
Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
index 85fbb18a9e4b..612d07762306 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
@@ -1218,6 +1218,17 @@ static int smu_smc_hw_setup(struct smu_context *smu)
if (!smu_is_dpm_running(smu))
dev_info(adev->dev, "dpm has been disabled\n");
+ /*
+ * Set initialized values (get from vbios) to dpm tables context such as
+ * gfxclk, memclk, dcefclk, and etc. And enable the DPM feature for each
+ * type of clks.
+ */
+ ret = smu_set_default_dpm_table(smu);
+ if (ret) {
+ dev_err(adev->dev, "Failed to setup default dpm clock tables!\n");
+ return ret;
+ }
+
if (adev->pm.pcie_gen_mask & CAIL_PCIE_LINK_SPEED_SUPPORT_GEN4)
pcie_gen = 3;
else if (adev->pm.pcie_gen_mask & CAIL_PCIE_LINK_SPEED_SUPPORT_GEN3)
@@ -1261,17 +1272,6 @@ static int smu_smc_hw_setup(struct smu_context *smu)
return ret;
}
- /*
- * Set initialized values (get from vbios) to dpm tables context such as
- * gfxclk, memclk, dcefclk, and etc. And enable the DPM feature for each
- * type of clks.
- */
- ret = smu_set_default_dpm_table(smu);
- if (ret) {
- dev_err(adev->dev, "Failed to setup default dpm clock tables!\n");
- return ret;
- }
-
ret = smu_notify_display_change(smu);
if (ret) {
dev_err(adev->dev, "Failed to notify display change!\n");
--
2.35.1
next prev parent reply other threads:[~2022-04-28 21:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 21:29 [PATCH] drm/amd/smu: Increace dpm level count only for aldebaran Alex Deucher
2022-04-28 21:29 ` [PATCH] drm/amdgpu: add updated smu_info structures Alex Deucher
2022-04-28 21:29 ` [PATCH] drm/amdgpu: query core refclk from bios for smu v13 Alex Deucher
2022-04-28 21:29 ` [PATCH] drm/amd/pm: enable pp_dpm_vclk/dclk sysfs interface support for SMU 13.0.0 Alex Deucher
2022-04-28 21:29 ` [PATCH] drm/amd/pm: fix NULL pointer issue of amdgpu_smu_stb_debug_fs_init Alex Deucher
2022-04-28 21:29 ` [PATCH] drm/amd/pm: move bootup values retrieving to ->sw_init Alex Deucher
2022-04-28 21:29 ` [PATCH] drm/amd/pm: correct the way for retrieving bootup clocks Alex Deucher
2022-04-28 21:29 ` [PATCH] drm/amd/pm: update the hw initialization sequence around pptable setup Alex Deucher
2022-04-28 21:29 ` [PATCH] drm/amdgpu: enable pptable ucode loading Alex Deucher
2022-04-28 21:29 ` [PATCH] drm/amd/pm: enable SCPM support for SMU Alex Deucher
2022-04-28 21:29 ` Alex Deucher [this message]
2022-04-28 21:29 ` [PATCH] drm/amd/pm: enable the support for retrieving combo pptable Alex Deucher
2022-04-29 2:41 ` [PATCH] drm/amd/smu: Increace dpm level count only for aldebaran Zhang, Hawking
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428212946.700296-11-alexander.deucher@amd.com \
--to=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=lijo.lazar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox