AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: "Christian König" <christian.koenig@amd.com>
Subject: [PATCH 2/6] drm/amdgpu: audit bo->resource usage
Date: Thu,  7 Jul 2022 12:24:49 +0200	[thread overview]
Message-ID: <20220707102453.3633-3-christian.koenig@amd.com> (raw)
In-Reply-To: <20220707102453.3633-1-christian.koenig@amd.com>

Make sure we can at least move and release BOs without backing store.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c    | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index d9cfe259f2a9..677d1dfab37f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -1305,7 +1305,7 @@ void amdgpu_bo_release_notify(struct ttm_buffer_object *bo)
 	if (bo->base.resv == &bo->base._resv)
 		amdgpu_amdkfd_remove_fence_on_pt_pd_bos(abo);
 
-	if (bo->resource->mem_type != TTM_PL_VRAM ||
+	if (!bo->resource || bo->resource->mem_type != TTM_PL_VRAM ||
 	    !(abo->flags & AMDGPU_GEM_CREATE_VRAM_WIPE_ON_RELEASE) ||
 	    adev->in_suspend || adev->shutdown)
 		return;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index be6f76a30ac6..3bddf266e8b5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -471,7 +471,8 @@ static int amdgpu_bo_move(struct ttm_buffer_object *bo, bool evict,
 
 	adev = amdgpu_ttm_adev(bo->bdev);
 
-	if (old_mem->mem_type == TTM_PL_SYSTEM && bo->ttm == NULL) {
+	if (!old_mem || (old_mem->mem_type == TTM_PL_SYSTEM &&
+			 bo->ttm == NULL)) {
 		ttm_bo_move_null(bo, new_mem);
 		goto out;
 	}
-- 
2.25.1


  parent reply	other threads:[~2022-07-07 10:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 10:24 Cleanup of TTM NULL resources Christian König
2022-07-07 10:24 ` [PATCH 1/6] drm/ttm: rename and cleanup ttm_bo_init_reserved Christian König
2022-07-07 10:35   ` Christian König
2022-07-07 17:24   ` [Intel-gfx] " kernel test robot
2022-07-08 13:31   ` Ruhl, Michael J
2022-07-07 10:24 ` Christian König [this message]
2022-07-08 13:34   ` [Intel-gfx] [PATCH 2/6] drm/amdgpu: audit bo->resource usage Ruhl, Michael J
2022-07-07 10:24 ` [PATCH 3/6] drm/nouveau: " Christian König
2022-07-08 13:35   ` [Intel-gfx] " Ruhl, Michael J
2022-07-07 10:24 ` [PATCH 4/6] drm/ttm: audit bo->resource usage v2 Christian König
2022-07-08 13:48   ` [Intel-gfx] " Ruhl, Michael J
2022-07-07 10:24 ` [PATCH 5/6] drm/ttm: stop allocating dummy resources during BO creation Christian König
2022-07-08 13:54   ` Ruhl, Michael J
2022-07-09 14:31   ` [drm/ttm] b297c22b70: canonical_address#:#[##] kernel test robot
2022-07-07 10:24 ` [PATCH 6/6] drm/ttm: stop allocating a dummy resource for pipelined gutting Christian König
2022-07-08 13:56   ` Ruhl, Michael J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707102453.3633-3-christian.koenig@amd.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox