From: Dan Carpenter <dan.carpenter@oracle.com>
To: Simon Ser <contact@emersion.fr>
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [bug report] drm/amd/display: use FB pitch to fill dc_cursor_attributes
Date: Tue, 26 Jul 2022 18:47:48 +0300 [thread overview]
Message-ID: <20220726154748.GQ2338@kadam> (raw)
In-Reply-To: <1JPWbfs9ltu7lsg8hK1KCCiKY9S6tjFGGGF13vR28hS9_FtOSHoSoS9rmHM4suOoa9fs8H8zcQiz0uFiuCpx8uOfV0CoRKBVwbKp8rKeozs=@emersion.fr>
On Tue, Jul 26, 2022 at 03:27:54PM +0000, Simon Ser wrote:
> Hi,
>
> plane->state->fb is NULL iff afb is NULL. There is an early return to
> make sure the dereferences don't cause a segfault.
>
Are you talking about this:
if (!plane->state->fb && !old_plane_state->fb)
return;
Should the && be ||?
regards,
dan carpenter
next prev parent reply other threads:[~2022-07-26 15:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 15:20 [bug report] drm/amd/display: use FB pitch to fill dc_cursor_attributes Dan Carpenter
2022-07-26 15:27 ` Simon Ser
2022-07-26 15:47 ` Dan Carpenter [this message]
2022-07-26 17:16 ` Simon Ser
-- strict thread matches above, loose matches on Subject: below --
2020-12-07 14:51 Dan Carpenter
2020-12-07 14:53 ` Simon Ser
2020-12-07 17:51 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726154748.GQ2338@kadam \
--to=dan.carpenter@oracle.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=contact@emersion.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox