From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: Alex Deucher <alexander.deucher@amd.com>,
Aurabindo Pillai <aurabindo.pillai@amd.com>,
Harry Wentland <harry.wentland@amd.com>,
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Subject: [PATCH 2/3] drm/amd/display: Enable new commit sequence only for DCN32x
Date: Tue, 11 Oct 2022 14:11:39 -0400 [thread overview]
Message-ID: <20221011181140.94595-3-Rodrigo.Siqueira@amd.com> (raw)
In-Reply-To: <20221011181140.94595-1-Rodrigo.Siqueira@amd.com>
Change commit sequence might impact multiple ASICs; for this reason, it
is better to run it only on DCN32x for the first set of validation.
After we get more confident about this change, we should expand it to
all ASICs.
Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Co-developed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index ad3aafb73cba..21d20900cfe3 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -1913,6 +1913,13 @@ bool dc_commit_state(struct dc *dc, struct dc_state *context)
enum dc_status result = DC_ERROR_UNEXPECTED;
int i;
+ /* TODO: Enable the new commit sequence for all ASICs */
+ if (dc->ctx->asic_id.chip_family == AMDGPU_FAMILY_GC_11_0_0 ||
+ dc->ctx->asic_id.chip_family == AMDGPU_FAMILY_GC_11_0_1) {
+ result = dc_commit_streams(dc, context->streams, context->stream_count);
+ return result == DC_OK;
+ }
+
if (!context_changed(dc, context))
return DC_OK;
@@ -3898,6 +3905,15 @@ void dc_commit_updates_for_stream(struct dc *dc,
struct dc_context *dc_ctx = dc->ctx;
int i, j;
+ /* TODO: Enable the new commit sequence for all ASICs */
+ if (dc->ctx->asic_id.chip_family == AMDGPU_FAMILY_GC_11_0_0 ||
+ dc->ctx->asic_id.chip_family == AMDGPU_FAMILY_GC_11_0_1) {
+ dc_update_planes_and_stream(dc, srf_updates,
+ surface_count, stream,
+ stream_update);
+ return;
+ }
+
stream_status = dc_stream_get_status(stream);
context = dc->current_state;
--
2.35.1
next prev parent reply other threads:[~2022-10-11 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 18:11 [PATCH 0/3] Update DC commit sequence Rodrigo Siqueira
2022-10-11 18:11 ` [PATCH 1/3] drm/amd/display: Add functions for new " Rodrigo Siqueira
2022-10-11 18:47 ` Harry Wentland
2022-10-11 18:11 ` Rodrigo Siqueira [this message]
2022-10-11 22:08 ` [PATCH 2/3] drm/amd/display: Enable new commit sequence only for DCN32x Harry Wentland
2022-10-11 18:11 ` [PATCH 3/3] drm/amd/display: Move dc_state copy in commit_tail after dc_commit_state Rodrigo Siqueira
2022-10-11 22:03 ` Harry Wentland
2022-10-11 18:52 ` [PATCH 0/3] Update DC commit sequence Wheeler, Daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221011181140.94595-3-Rodrigo.Siqueira@amd.com \
--to=rodrigo.siqueira@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=harry.wentland@amd.com \
--cc=nicholas.kazlauskas@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox