From: Shashank Sharma <shashank.sharma@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: mukul.joshi@amd.com, contactshashanksharma@gmail.com,
arvind.yadav@amd.com, Shashank Sharma <shashank.sharma@amd.com>
Subject: [PATCH v2 00/12] AMDGPU doorbell manager
Date: Wed, 12 Apr 2023 18:25:24 +0200 [thread overview]
Message-ID: <20230412162537.1357-1-shashank.sharma@amd.com> (raw)
Doorbells in AMDGPU drivers are currently managed by different clients
in a scattered way, across may places. The existing clients are:
- AMDGPU graphics driver for kernel level doorbell writes.
- AMDGPU MES module for kernel level doorbell write (MES ring test and
aggregated doorbells).
- AMDGPU MES module for MES process doorbells.
- AMDKFD module for KFD/KIQ kernel doorbells.
- AMDKFD module for KFD process doorbells.
- AMDGPU usermode queues for usermode doorbell writes (upcoming).
This patch series introduces doorbell-manager to keep the doorbell
handling at a central place. The fundamental changes are:
- Introduce and accommodate a new GEM domain for doorbells.
- Prepare the AMDGPU ttm backend for handling doorbell allocation.
- Create doorbell BOs for kernel-level and process level doorbell
opertations, and place it in existing structures.
- Modify the existing graphics, KFD and MES code to use the
doorbell-manager functions.
- Remove the existing doorbell management code in KFD/MES.
The idea is that:
- a kernel client can call doorbell manager functions to allocate/free
doorbell pages.
- a usermode app can directly allocate a page from the doorbell bar just
like a GEM object and use it for different usermode queues.
- There is no direct UAPI change in this series, just an additional flag
for GEM_OBJECT_DOORBELL, here:
https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/286
PS: This series has been sanity tested with kfd_test_suit to ensure
it is not introducing any regressions due to kfd doorbell changes.
Alex Deucher (2):
drm/amdgpu: add UAPI for allocating doorbell memory
drm/amdgpu: accommodate DOMAIN/PL_DOORBELL
Shashank Sharma (10):
drm/amdgpu: create a new file for doorbell manager
drm/amdgpu: don't modify num_doorbells for mes
drm/amdgpu: initialize ttm for doorbells
drm/amdgpu: create kernel doorbell pages
get absolute offset from doorbell index
drm/amdgpu: use doorbell manager for kfd kernel doorbells
drm/amdgpu: use doorbell manager for kfd process doorbells
drm/amdgpu: remove unused functions and variables
drm/amdgpu: use doorbell mgr for MES kernel doorbells
drm/amdgpu: cleanup MES process level doorbells
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 174 +------------
drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h | 17 +-
.../gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c | 230 ++++++++++++++++++
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 148 +++--------
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 16 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 11 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 +
.../gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 2 +
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 30 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 1 +
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 13 -
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 -
.../drm/amd/amdkfd/kfd_device_queue_manager.c | 8 +-
drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c | 207 +++++-----------
drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 27 +-
drivers/gpu/drm/amd/amdkfd/kfd_process.c | 21 +-
.../amd/amdkfd/kfd_process_queue_manager.c | 22 +-
include/uapi/drm/amdgpu_drm.h | 7 +-
19 files changed, 446 insertions(+), 494 deletions(-)
create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c
--
2.40.0
next reply other threads:[~2023-04-12 16:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 16:25 Shashank Sharma [this message]
2023-04-12 16:25 ` [PATCH v2 01/12] drm/amdgpu: create a new file for doorbell manager Shashank Sharma
2023-04-13 10:48 ` Christian König
2023-04-13 10:51 ` Christian König
2023-04-12 16:25 ` [PATCH v2 02/12] drm/amdgpu: don't modify num_doorbells for mes Shashank Sharma
2023-04-12 16:25 ` [PATCH v2 03/12] drm/amdgpu: add UAPI for allocating doorbell memory Shashank Sharma
2023-04-12 16:25 ` [PATCH v2 04/12] drm/amdgpu: accommodate DOMAIN/PL_DOORBELL Shashank Sharma
2023-04-12 16:25 ` [PATCH v2 05/12] drm/amdgpu: initialize ttm for doorbells Shashank Sharma
2023-04-12 16:25 ` [PATCH v2 06/12] drm/amdgpu: create kernel doorbell pages Shashank Sharma
2023-04-12 16:25 ` [PATCH v2 07/12] get absolute offset from doorbell index Shashank Sharma
2023-04-13 10:59 ` Christian König
2023-04-12 16:25 ` [PATCH v2 08/12] drm/amdgpu: use doorbell manager for kfd kernel doorbells Shashank Sharma
2023-04-13 11:02 ` Christian König
2023-04-13 13:08 ` Shashank Sharma
2023-04-21 19:58 ` Felix Kuehling
2023-04-22 6:39 ` Shashank Sharma
2023-04-24 19:56 ` Felix Kuehling
2023-04-25 19:59 ` Shashank Sharma
2023-06-09 19:33 ` Felix Kuehling
2023-04-12 16:25 ` [PATCH v2 09/12] drm/amdgpu: use doorbell manager for kfd process doorbells Shashank Sharma
2023-04-13 11:07 ` Christian König
2023-04-21 20:11 ` Felix Kuehling
2023-04-22 6:45 ` Shashank Sharma
2023-04-12 16:25 ` [PATCH v2 10/12] drm/amdgpu: remove unused functions and variables Shashank Sharma
2023-06-09 19:34 ` Felix Kuehling
2023-04-12 16:25 ` [PATCH v2 11/12] drm/amdgpu: use doorbell mgr for MES kernel doorbells Shashank Sharma
2023-04-12 16:25 ` [PATCH v2 12/12] drm/amdgpu: cleanup MES process level doorbells Shashank Sharma
2023-04-13 11:19 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412162537.1357-1-shashank.sharma@amd.com \
--to=shashank.sharma@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arvind.yadav@amd.com \
--cc=contactshashanksharma@gmail.com \
--cc=mukul.joshi@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox