From: Ma Jun <Jun.Ma2@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: Alexander.Deucher@amd.com, Ma Jun <Jun.Ma2@amd.com>,
mario.limonciello@amd.com
Subject: [PATCH] drm/amdgpu: Check resize bar register when system uses large bar
Date: Tue, 19 Dec 2023 13:58:02 +0800 [thread overview]
Message-ID: <20231219055802.304678-1-Jun.Ma2@amd.com> (raw)
Print a warnning message if the system can't access
the resize bar register when using large bar.
Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 4b694696930e..e7aedb4bd66e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1417,6 +1417,12 @@ void amdgpu_device_wb_free(struct amdgpu_device *adev, u32 wb)
__clear_bit(wb, adev->wb.used);
}
+static inline void amdgpu_find_rb_register(struct amdgpu_device *adev)
+{
+ if (!pci_find_ext_capability(adev->pdev, PCI_EXT_CAP_ID_REBAR))
+ DRM_WARN("System can't access the resize bar register,please check!!\n");
+}
+
/**
* amdgpu_device_resize_fb_bar - try to resize FB BAR
*
@@ -1444,8 +1450,10 @@ int amdgpu_device_resize_fb_bar(struct amdgpu_device *adev)
/* skip if the bios has already enabled large BAR */
if (adev->gmc.real_vram_size &&
- (pci_resource_len(adev->pdev, 0) >= adev->gmc.real_vram_size))
+ (pci_resource_len(adev->pdev, 0) >= adev->gmc.real_vram_size)) {
+ amdgpu_find_rb_register(adev);
return 0;
+ }
/* Check if the root BUS has 64bit memory resources */
root = adev->pdev->bus;
--
2.34.1
next reply other threads:[~2023-12-19 5:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 5:58 Ma Jun [this message]
2023-12-20 14:10 ` [PATCH] drm/amdgpu: Check resize bar register when system uses large bar Christian König
2023-12-21 1:58 ` Ma, Jun
2023-12-30 2:22 ` Mario Limonciello
2024-01-05 13:39 ` Christian König
2024-01-05 16:11 ` Alex Deucher
2024-01-08 9:25 ` Ma, Jun
2024-01-08 9:24 ` Ma, Jun
2024-01-08 16:24 ` Christian König
2024-01-09 9:44 ` Ma, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219055802.304678-1-Jun.Ma2@amd.com \
--to=jun.ma2@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox