From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14E2FC47DA9 for ; Sun, 28 Jan 2024 16:17:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B7D6011271D; Sun, 28 Jan 2024 16:17:22 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F02B11271D; Sun, 28 Jan 2024 16:17:22 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B168661BAC; Sun, 28 Jan 2024 16:17:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56AC4C433F1; Sun, 28 Jan 2024 16:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706458641; bh=9tq2CZVoobi2oj8srMBe1yHU4nEL5RrxPBU5PI/csw4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oA2VEghi2/sA2Aha/O3cCRGOL3asGtzebWyK22OqNFn+GUtMAPQGhZKZ+zwe5m2pB LRExQYVRoy65vDk5Qfxc2sEGBo/1N/yIjmQisCd87o6ob2l/HEDoN7FaFPma+VTwX4 46PQrZKN9qAC+o/gLvMaIZuy/OvCoz8I1widZV82LlvXxR/ks5XuSYhiz2L9+ewBqd +yVgsAzfFXvoRTGiNj+kdJpzYPac1PQa+IPJ5jDtSGIQ3g1oskCiPovOO8hpgMaPlb MKnZkmRGOiE8ZrRMY9QT4xBLgnQ24V/+CSpceH1Smow+zHBhvuQBqSVBDMBRO0zlSs 8bPdMRxzW+XmA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 8/8] drm/amdgpu: Release 'adev->pm.fw' before return in 'amdgpu_device_need_post()' Date: Sun, 28 Jan 2024 11:16:59 -0500 Message-ID: <20240128161704.205756-8-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240128161704.205756-1-sashal@kernel.org> References: <20240128161704.205756-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.306 Content-Transfer-Encoding: 8bit X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Xinhui.Pan@amd.com, Srinivasan Shanmugam , shashank.sharma@amd.com, dri-devel@lists.freedesktop.org, Lijo Lazar , amd-gfx@lists.freedesktop.org, victorchengchi.lu@amd.com, le.ma@amd.com, hamza.mahfooz@amd.com, mario.limonciello@amd.com, daniel@ffwll.ch, Alex Deucher , andrealmeid@igalia.com, candice.li@amd.com, airlied@gmail.com, =?UTF-8?q?Christian=20K=C3=B6nig?= , Monk Liu , Hawking.Zhang@amd.com Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" From: Srinivasan Shanmugam [ Upstream commit 8a44fdd3cf91debbd09b43bd2519ad2b2486ccf4 ] In function 'amdgpu_device_need_post(struct amdgpu_device *adev)' - 'adev->pm.fw' may not be released before return. Using the function release_firmware() to release adev->pm.fw. Thus fixing the below: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1571 amdgpu_device_need_post() warn: 'adev->pm.fw' from request_firmware() not released on lines: 1554. Cc: Monk Liu Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Suggested-by: Lijo Lazar Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index c84f475d4f13..ae28f72c73ef 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -823,6 +823,7 @@ bool amdgpu_device_need_post(struct amdgpu_device *adev) return true; fw_ver = *((uint32_t *)adev->pm.fw->data + 69); + release_firmware(adev->pm.fw); if (fw_ver < 0x00160e00) return true; } -- 2.43.0