AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: David McFarland <corngood@gmail.com>
To: amd-gfx@lists.freedesktop.org
Cc: David McFarland <corngood@gmail.com>, mario.limonciello@amd.com
Subject: [PATCH 1/1] drm/amd: Don't init MEC2 firmware when it fails to load
Date: Sun, 28 Jan 2024 12:18:06 -0400	[thread overview]
Message-ID: <20240128161803.1224103-2-corngood@gmail.com> (raw)
In-Reply-To: <20240128161803.1224103-1-corngood@gmail.com>

The same calls are made directly above, but conditional on the firmware
loading and validating successfully.

Fixes: 9931b67690cf ("drm/amd: Load GFX10 microcode during early_init")
---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index d63cab294883..b0ba68016a02 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
@@ -4022,18 +4022,16 @@ static int gfx_v10_0_init_microcode(struct amdgpu_device *adev)
 	err = amdgpu_ucode_request(adev, &adev->gfx.mec2_fw, fw_name);
 	if (!err) {
 		amdgpu_gfx_cp_init_microcode(adev, AMDGPU_UCODE_ID_CP_MEC2);
 		amdgpu_gfx_cp_init_microcode(adev, AMDGPU_UCODE_ID_CP_MEC2_JT);
 	} else {
 		err = 0;
 		adev->gfx.mec2_fw = NULL;
 	}
-	amdgpu_gfx_cp_init_microcode(adev, AMDGPU_UCODE_ID_CP_MEC2);
-	amdgpu_gfx_cp_init_microcode(adev, AMDGPU_UCODE_ID_CP_MEC2_JT);
 
 	gfx_v10_0_check_fw_write_wait(adev);
 out:
 	if (err) {
 		amdgpu_ucode_release(&adev->gfx.pfp_fw);
 		amdgpu_ucode_release(&adev->gfx.me_fw);
 		amdgpu_ucode_release(&adev->gfx.ce_fw);
 		amdgpu_ucode_release(&adev->gfx.rlc_fw);
-- 
2.40.1


  reply	other threads:[~2024-01-29  9:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-28 16:18 [PATCH 0/1] amdgpu: Fix crash when MEC2 firmware fails to load David McFarland
2024-01-28 16:18 ` David McFarland [this message]
2024-01-29 20:46   ` [PATCH 1/1] drm/amd: Don't init MEC2 firmware when it " Mario Limonciello
2024-01-29 21:15     ` Mario Limonciello
2024-01-29 22:18       ` [PATCH v2 0/1] " David McFarland
2024-01-29 22:18       ` [PATCH v2 1/1] " David McFarland
2024-01-29 22:21         ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240128161803.1224103-2-corngood@gmail.com \
    --to=corngood@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=mario.limonciello@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox