From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A75FC48BC4 for ; Wed, 14 Feb 2024 09:19:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E389510E6EC; Wed, 14 Feb 2024 09:19:15 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="SiwuB6QY"; dkim-atps=neutral Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1061C10E971 for ; Wed, 14 Feb 2024 00:00:26 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d8ef977f1eso35997235ad.0 for ; Tue, 13 Feb 2024 16:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707868824; x=1708473624; darn=lists.freedesktop.org; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :from:to:cc:subject:date:message-id:reply-to; bh=YMBETSS65YtqnXuGPPIuISSAqLQJ5kfAKukBNt/idE8=; b=SiwuB6QYvne3X826qdP+/MSbRU0Qm/A+aTVg2IY61kiYEh+0r2mq9y94uhpCDR2Wdl Ec/oV2Vbf5WMGNLZTMXHHyMq5o9hImmB2W9mZ4QyqM9AEfahZ99Or6AoBS8Ui7KqcPAg PvBnNIhn/Ws5M9pZf1sU0KK0L2+hyHscJpVJ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707868824; x=1708473624; h=content-disposition:mime-version:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YMBETSS65YtqnXuGPPIuISSAqLQJ5kfAKukBNt/idE8=; b=js6+lobBBhDE7jL5HvBw1SpK/rsezE10+GlxivC3QA6CWpgxd+tHI68rtVsAnCprA/ QMsxU9v/4wXBpsjoUTs+qjJcssHKP6iGj7+QUqt/MN5pzCpuYftSIRiCShYocxRFegda JzIOoC6KYvJxWJJlRjsRGnJCx+Kvb3TqwnZ0Qjr2e9qips4wsBo38qnfmnD2ydxzsZxg ONWYl00VdWhxm5wJh7dRxpAlR0eULKk2f5ywgj1QzArwGqfOv/1PqjwArkKbq7zuY748 LwKfbCceJea2ml6AdwDQChpbYKigYteO/T7ABQ1t8d4JadAWRC72NSkwngkiSp11IrWV 7llw== X-Forwarded-Encrypted: i=1; AJvYcCW+D7IhPo1KWsM4PK6RuGIDmDDcA49DCTftBQmpBo7WgVMMZZ7ZNV/G0f2RUDvO0AS7iEG0bT0H10Om8fXa/id/H0cbylpexlS4STVIog== X-Gm-Message-State: AOJu0Yx6BSBQUfAifNq8H0k/4TNWYOqYKu3R4fvnmtyjgxuCATJnFGVR nWohlkPunVtzelnqmTULYW2573MyHAM1Jxk4IvunLxyvIp5jRzev0CgvdycCyQ== X-Google-Smtp-Source: AGHT+IH9rsUe89jGMxEbzEa0N6vUYHDPRuvR/b9/k1IT9a00gMG0R2c9wJlulVF3FzsCot+gzaw1PA== X-Received: by 2002:a17:90a:f40c:b0:296:15ed:b220 with SMTP id ch12-20020a17090af40c00b0029615edb220mr832051pjb.45.1707868824140; Tue, 13 Feb 2024 16:00:24 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXvqigQwCxsR1eRkChMkloewkaYy2M5PIy5Ni/XnHBQDAoKHR/aIWNhHUmSslt8uKRHk2RvI4FXgV3UeO0qZK5hqOibVcIauBOnaVV6bWqTt+6c8dkIprXNrI5L5VfYBFUHS69JyCg+nHpwWH2NA7USk6ZGA7BJYmKeBVNaUv6t7nbX6rD1Z408EwIrtCw4leiFoAOQQxPSKq96raZChBqacZ3+4FYorcIV+LyapGi48IgtKsvYmWtHxOooH1tU+9GuPo7DWxRObhQs2h/a8NPsVDG+8Ii56LWj61JxEfWg8Jpnp22Q5QXdxTZePUUSTJkUCjhZzswaHYKdG9wthJUgMDbiBypE28viY4HtoFLOasVUO9pQGnzZlTiocOiJc/j2G5FPsjyRYU/m/U+tLeylJhN8RRMOG1mblR4pXyrkPq8U4+QBJzK2xCgs4paq+UjHOlY6f8nCDaPTIYca6QGUU4oDY6Wxvl/ffuvXbNTLjgytPTUvb0LZI8DpX3qZ9VXoyFO2DA98Nd/FyAdnCsh9Wx4mk4ILJR0vc+h2OOqUOjdFTYgx1CTlgPMBCwL2wn02OHDgfzIBa4fgsHNuZ2cYDjFG1baEF2loFgOxwfI7AqA2M0tBhkyn56ZLLulIRLW9y2Yhe/oRExou8cAUYnr3X3fcva1E523zl+gb8uJN9PUnSoaBABRO4nU5Zub2E2rHh6pibQJRTd5zMWMDH/6Ng64ln4aFlKDp3UrwcNFtF+9YSPO3aiogzLGUboEk6CYsA2Qc6BtsMMWfB3lxYqpKqJTGb1frpJIrwJTMGNoHZ330172lV9akQVjbSxkHoEY9vEhupNRlyX1PhADYagw9Eug9eM1rAObW7gqFTdA9KWXKUA0JFFdMhd46aF3gGGOFbVnANrA1fRYLe3cigO4CcuNuISMz8MiDonjdbYtNfdfO9UmzV/30vOkiws/N/gTW7P 9ZxedQ9fPgpdcMoM9aUXZcpQijJVqwyZiu0ME7ezdhRn4k0vJV3sxJfd8YsRR/fEySJmzTASB18YtNpPAPC//yt7IQiwiKqBOckpWmQ0j4IQj5XbaBcWuhawwVFuZ4eLJmroLfpIackC8FxNUKY62wd6T0mgw4m9+N2ZG22Gfz Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id mv21-20020a17090b199500b00298c373a820sm100292pjb.23.2024.02.13.16.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 16:00:23 -0800 (PST) From: coverity-bot X-Google-Original-From: coverity-bot Date: Tue, 13 Feb 2024 16:00:23 -0800 To: Saleemkhan Jamadar Cc: Sun peng Li , Mario Limonciello , amd-gfx@lists.freedesktop.org, "Pan, Xinhui" , Daniel Vetter , Roman Li , Veerabadhran Gopalakrishnan , Horatio Zhang , James Zhu , Harry Wentland , Yifan Zhang , David Airlie , Aurabindo Pillai , Leo Liu , Bhawanpreet Lakha , Sonny Jiang , Lang Yu , Alex Deucher , Li Ma , Lijo Lazar , Morris Zhang , Tao Zhou , dri-devel@lists.freedesktop.org, Shane Xiao , Christian =?iso-8859-1?Q?K=F6nig?= , Ran Sun , Jane Jian , Hawking Zhang , Ivan Lipski , linux-kernel@vger.kernel.org, Tom Chung , "Gustavo A. R. Silva" , linux-next@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Coverity: jpeg_v4_0_5_start(): Code maintainability issues Message-ID: <202402131600.FF35A56D27@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailman-Approved-At: Wed, 14 Feb 2024 09:19:14 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20240213 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by commits: Mon Feb 12 16:09:32 2024 -0500 0a119d53f74a ("drm/amdgpu/jpeg: add support for jpeg DPG mode") Coverity reported the following: *** CID 1583635: Code maintainability issues (UNUSED_VALUE) drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c:461 in jpeg_v4_0_5_start() 455 456 WREG32_SOC15(VCN, i, regVCN_JPEG_DB_CTRL, 457 ring->doorbell_index << VCN_JPEG_DB_CTRL__OFFSET__SHIFT | 458 VCN_JPEG_DB_CTRL__EN_MASK); 459 460 if (adev->pg_flags & AMD_PG_SUPPORT_JPEG_DPG) { vvv CID 1583635: Code maintainability issues (UNUSED_VALUE) vvv Assigning value from "jpeg_v4_0_5_start_dpg_mode(adev, i, adev->jpeg.indirect_sram)" to "r" here, but that stored value is overwritten before it can be used. 461 r = jpeg_v4_0_5_start_dpg_mode(adev, i, adev->jpeg.indirect_sram); 462 continue; 463 } 464 465 /* disable power gating */ 466 r = jpeg_v4_0_5_disable_static_power_gating(adev, i); If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot Addresses-Coverity-ID: 1583635 ("Code maintainability issues") Fixes: 0a119d53f74a ("drm/amdgpu/jpeg: add support for jpeg DPG mode") Thanks for your attention! -- Coverity-bot