From: Li Ma <li.ma@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <alexander.deucher@amd.com>, <richard.gong@amd.com>,
<yifan1.zhang@amd.com>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
Akshata MukundShetty <akshata.mukundshetty@amd.com>
Subject: [PATCH 4/8] HID: amd_sfh: Increase sensor command timeout
Date: Fri, 29 Mar 2024 18:17:46 +0800 [thread overview]
Message-ID: <20240329101748.3961982-4-li.ma@amd.com> (raw)
In-Reply-To: <20240329101748.3961982-1-li.ma@amd.com>
From: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
During the initialization sensors may take some time to respond. Hence,
increase the sensor command timeouts in order to obtain status responses
within a maximum timeout.
Co-developed-by: Akshata MukundShetty <akshata.mukundshetty@amd.com>
Signed-off-by: Akshata MukundShetty <akshata.mukundshetty@amd.com>
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
(cherry picked from commit 7e5ce11484572aae906d6b3e098c78d3a95e5288)
---
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
index 2530fa98b568..8a4cd793d021 100644
--- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
+++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
@@ -39,11 +39,11 @@ static int amd_sfh_wait_response_v2(struct amd_mp2_dev *mp2, u8 sid, u32 sensor_
{
union cmd_response cmd_resp;
- /* Get response with status within a max of 1600 ms timeout */
+ /* Get response with status within a max of 10 seconds timeout */
if (!readl_poll_timeout(mp2->mmio + AMD_P2C_MSG(0), cmd_resp.resp,
(cmd_resp.response_v2.response == sensor_sts &&
cmd_resp.response_v2.status == 0 && (sid == 0xff ||
- cmd_resp.response_v2.sensor_id == sid)), 500, 1600000))
+ cmd_resp.response_v2.sensor_id == sid)), 500, 10000000))
return cmd_resp.response_v2.response;
return SENSOR_DISABLED;
--
2.25.1
next prev parent reply other threads:[~2024-03-29 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 10:17 [PATCH 1/8] HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int() Li Ma
2024-03-29 10:17 ` [PATCH 2/8] HID: amd_sfh: Add a new interface for exporting HPD data Li Ma
2024-03-29 10:17 ` [PATCH 3/8] HID: amd_sfh: Add a new interface for exporting ALS data Li Ma
2024-03-29 10:17 ` Li Ma [this message]
2024-03-29 10:17 ` [PATCH 5/8] HID: amd_sfh: Update HPD sensor structure elements Li Ma
2024-03-29 10:17 ` [PATCH 6/8] HID: amd_sfh: Avoid disabling the interrupt Li Ma
2024-03-29 10:17 ` [PATCH 7/8] HID: amd_sfh: Improve boot time when SFH is available Li Ma
2024-03-29 10:17 ` [PATCH 8/8] HID: amd_sfh: Extend MP2 register access to SFH Li Ma
2024-04-03 12:11 ` [PATCH 1/8] HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int() Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240329101748.3961982-4-li.ma@amd.com \
--to=li.ma@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=akshata.mukundshetty@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=richard.gong@amd.com \
--cc=yifan1.zhang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox