From: Yang Wang <kevinyang.wang@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <hawking.zhang@amd.com>, <alexander.deucher@amd.com>
Subject: [PATCH 02/18] drm/amdgpu: refine gpu_info firmware loading
Date: Fri, 31 May 2024 14:52:33 +0800 [thread overview]
Message-ID: <20240531065249.1746350-2-kevinyang.wang@amd.com> (raw)
In-Reply-To: <20240531065249.1746350-1-kevinyang.wang@amd.com>
refine gpu_info firmware loading
Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 6711836054f9..a6af15fb203c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2350,7 +2350,6 @@ void amdgpu_device_set_sriov_virtual_display(struct amdgpu_device *adev)
static int amdgpu_device_parse_gpu_info_fw(struct amdgpu_device *adev)
{
const char *chip_name;
- char fw_name[40];
int err;
const struct gpu_info_firmware_header_v1_0 *hdr;
@@ -2384,12 +2383,12 @@ static int amdgpu_device_parse_gpu_info_fw(struct amdgpu_device *adev)
break;
}
- snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_gpu_info.bin", chip_name);
- err = amdgpu_ucode_request(adev, &adev->firmware.gpu_info_fw, fw_name);
+ err = amdgpu_ucode_request(adev, &adev->firmware.gpu_info_fw,
+ "amdgpu/%s_gpu_info.bin", chip_name);
if (err) {
dev_err(adev->dev,
- "Failed to get gpu_info firmware \"%s\"\n",
- fw_name);
+ "Failed to get gpu_info firmware \"%s_gpu_info.bin\"\n",
+ chip_name);
goto out;
}
--
2.34.1
next prev parent reply other threads:[~2024-05-31 6:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 6:52 [PATCH 01/18] drm/amdgpu: enhance amdgpu_ucode_request() function flexibility Yang Wang
2024-05-31 6:52 ` Yang Wang [this message]
2024-05-31 6:52 ` [PATCH 03/18] drm/amdgpu: refine isp firmware loading Yang Wang
2024-05-31 6:52 ` [PATCH 04/18] drm/amdgpu: refine mes " Yang Wang
2024-05-31 14:24 ` Deucher, Alexander
2024-05-31 14:49 ` Wang, Yang(Kevin)
2024-05-31 6:52 ` [PATCH 05/18] drm/amdgpu: refine psp " Yang Wang
2024-05-31 6:52 ` [PATCH 06/18] drm/amdgpu: refine sdma " Yang Wang
2024-05-31 6:52 ` [PATCH 07/18] drm/amdgpu: refine imu " Yang Wang
2024-05-31 6:52 ` [PATCH 08/18] drm/amdgpu: refine pmfw/smu " Yang Wang
2024-05-31 6:52 ` [PATCH 09/18] drm/amdgpu: refine gmc " Yang Wang
2024-05-31 6:52 ` [PATCH 10/18] drm/amdgpu: refine vcn " Yang Wang
2024-05-31 6:52 ` [PATCH 11/18] drm/amdgpu: refine vpe " Yang Wang
2024-05-31 6:52 ` [PATCH 12/18] drm/amdgpu: refine gfx6 " Yang Wang
2024-05-31 6:52 ` [PATCH 13/18] drm/amdgpu: refine gfx7 " Yang Wang
2024-05-31 6:52 ` [PATCH 14/18] drm/amdgpu: refine gfx8 " Yang Wang
2024-05-31 6:52 ` [PATCH 15/18] drm/amdgpu: refine gfx9 " Yang Wang
2024-05-31 6:52 ` [PATCH 16/18] drm/amdgpu: refine gfx10 " Yang Wang
2024-05-31 6:52 ` [PATCH 17/18] drm/amdgpu: refine gfx11 " Yang Wang
2024-05-31 6:52 ` [PATCH 18/18] drm/amdgpu: refine gfx12 " Yang Wang
2024-06-03 11:05 ` [PATCH 01/18] drm/amdgpu: enhance amdgpu_ucode_request() function flexibility Christian König
-- strict thread matches above, loose matches on Subject: below --
2024-06-03 1:41 [PATCH 00/18] Enhance amdgpu_firmware_request() to improve " Yang Wang
2024-06-03 1:41 ` [PATCH 02/18] drm/amdgpu: refine gpu_info firmware loading Yang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240531065249.1746350-2-kevinyang.wang@amd.com \
--to=kevinyang.wang@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=hawking.zhang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox