From: kernel test robot <lkp@intel.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
tursulin@ursulin.net, friedrich.vock@gmx.de
Cc: oe-kbuild-all@lists.linux.dev, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/6] drm/ttm: add TTM_PL_FLAG_TRESHOLD
Date: Wed, 5 Jun 2024 09:12:56 +0800 [thread overview]
Message-ID: <202406050819.et54U72l-lkp@intel.com> (raw)
In-Reply-To: <20240604160503.43359-3-christian.koenig@amd.com>
Hi Christian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm/drm-next]
[also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.10-rc2 next-20240604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-ttm-add-TTM_PL_FLAG_TRESHOLD/20240605-040913
base: git://anongit.freedesktop.org/drm/drm drm-next
patch link: https://lore.kernel.org/r/20240604160503.43359-3-christian.koenig%40amd.com
patch subject: [PATCH 2/6] drm/ttm: add TTM_PL_FLAG_TRESHOLD
config: parisc-defconfig (https://download.01.org/0day-ci/archive/20240605/202406050819.et54U72l-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240605/202406050819.et54U72l-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406050819.et54U72l-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/ttm/ttm_resource.c:339: warning: Function parameter or struct member 'ctx' not described in 'ttm_resource_compatible'
vim +339 drivers/gpu/drm/ttm/ttm_resource.c
46299051794a9c Christian König 2024-06-04 325
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 326 /**
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 327 * ttm_resource_compatible - check if resource is compatible with placement
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 328 *
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 329 * @res: the resource to check
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 330 * @placement: the placement to check against
cc941c70df3927 Christian König 2023-12-06 331 * @evicting: true if the caller is doing evictions
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 332 *
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 333 * Returns true if the placement is compatible.
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 334 */
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 335 bool ttm_resource_compatible(struct ttm_resource *res,
cc941c70df3927 Christian König 2023-12-06 336 struct ttm_placement *placement,
46299051794a9c Christian König 2024-06-04 337 struct ttm_operation_ctx *ctx,
cc941c70df3927 Christian König 2023-12-06 338 bool evicting)
98cca519df6da6 Christian König 2021-08-30 @339 {
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 340 struct ttm_buffer_object *bo = res->bo;
544432703b2fe7 Arunpravin Paneer Selvam 2022-08-20 341 struct ttm_device *bdev = bo->bdev;
98cca519df6da6 Christian König 2021-08-30 342 unsigned i;
98cca519df6da6 Christian König 2021-08-30 343
98cca519df6da6 Christian König 2021-08-30 344 if (res->placement & TTM_PL_FLAG_TEMPORARY)
98cca519df6da6 Christian König 2021-08-30 345 return false;
98cca519df6da6 Christian König 2021-08-30 346
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 347 for (i = 0; i < placement->num_placement; i++) {
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 348 const struct ttm_place *place = &placement->placement[i];
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 349 struct ttm_resource_manager *man;
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 350
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 351 if (res->mem_type != place->mem_type)
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 352 continue;
98cca519df6da6 Christian König 2021-08-30 353
46299051794a9c Christian König 2024-06-04 354 if (!ttm_place_applicable(place, ctx, evicting))
cc941c70df3927 Christian König 2023-12-06 355 continue;
cc941c70df3927 Christian König 2023-12-06 356
cc941c70df3927 Christian König 2023-12-06 357 if (place->flags & TTM_PL_FLAG_CONTIGUOUS &&
cc941c70df3927 Christian König 2023-12-06 358 !(res->placement & TTM_PL_FLAG_CONTIGUOUS))
cc941c70df3927 Christian König 2023-12-06 359 continue;
cc941c70df3927 Christian König 2023-12-06 360
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 361 man = ttm_manager_type(bdev, res->mem_type);
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 362 if (man->func->compatible &&
a78a8da51b36c7 Somalapuram Amaranath 2023-11-13 363 !man->func->compatible(man, res, place, bo->base.size))
98cca519df6da6 Christian König 2021-08-30 364 continue;
98cca519df6da6 Christian König 2021-08-30 365
98cca519df6da6 Christian König 2021-08-30 366 return true;
98cca519df6da6 Christian König 2021-08-30 367 }
98cca519df6da6 Christian König 2021-08-30 368 return false;
98cca519df6da6 Christian König 2021-08-30 369 }
98cca519df6da6 Christian König 2021-08-30 370
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-06-05 1:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 16:04 Rate limit improvements for TTM Christian König
2024-06-04 16:04 ` [PATCH 1/6] drm/amdgpu: cleanup MES command submission Christian König
2024-06-04 16:04 ` [PATCH 2/6] drm/ttm: add TTM_PL_FLAG_TRESHOLD Christian König
2024-06-05 1:12 ` kernel test robot [this message]
2024-06-04 16:05 ` [PATCH 3/6] drm/amdgpu: enable GTT fallback handling for dGPUs only Christian König
2024-11-12 15:12 ` Alex Deucher
2024-06-04 16:05 ` [PATCH 4/6] drm/amdgpu: re-order AMDGPU_GEM_DOMAIN_DOORBELL handling Christian König
2024-06-04 16:05 ` [PATCH 5/6] drm/amdgpu: always enable move threshold for BOs Christian König
2024-06-11 16:24 ` Tvrtko Ursulin
2024-06-14 9:53 ` Christian König
2024-06-14 16:06 ` Tvrtko Ursulin
2024-06-28 8:13 ` Tvrtko Ursulin
2024-06-04 16:05 ` [PATCH 6/6] drm/amdgpu: Re-validate evicted buffers v2 Christian König
2024-08-13 15:07 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202406050819.et54U72l-lkp@intel.com \
--to=lkp@intel.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=friedrich.vock@gmx.de \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox