From: Wayne Lin <Wayne.Lin@amd.com>
To: <amd-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>
Cc: <lyude@redhat.com>, <jani.nikula@intel.com>,
<imre.deak@intel.com>, <daniel@ffwll.ch>,
<Harry.Wentland@amd.com>, <jerry.zuo@amd.com>,
Wayne Lin <Wayne.Lin@amd.com>
Subject: [PATCH 3/3] drm/amd/display: Solve mst monitors blank out problem after resume
Date: Wed, 26 Jun 2024 16:48:25 +0800 [thread overview]
Message-ID: <20240626084825.878565-4-Wayne.Lin@amd.com> (raw)
In-Reply-To: <20240626084825.878565-1-Wayne.Lin@amd.com>
[Why]
In dm resume, we firstly restore dc state and do the mst resume for
topology probing thereafter. If we change dpcd DP_MSTM_CTRL value
after LT in mst reume, it will cause light up problem on the hub.
[How]
Revert the commit 202dc359adda ("drm/amd/display: Defer handling mst
up request in resume"). And adjust the reason to trigger
dc_link_detect by DETECT_REASON_RESUMEFROMS3S4.
Fixes: 202dc359adda ("drm/amd/display: Defer handling mst up request in resume")
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index c64cc2378a94..b01452eb0981 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -2569,6 +2569,7 @@ static void resume_mst_branch_status(struct drm_dp_mst_topology_mgr *mgr)
ret = drm_dp_dpcd_writeb(mgr->aux, DP_MSTM_CTRL,
DP_MST_EN |
+ DP_UP_REQ_EN |
DP_UPSTREAM_IS_SRC);
if (ret < 0) {
drm_dbg_kms(mgr->dev, "mst write failed - undocked during suspend?\n");
@@ -3171,7 +3172,7 @@ static int dm_resume(void *handle)
} else {
mutex_lock(&dm->dc_lock);
dc_exit_ips_for_hw_access(dm->dc);
- dc_link_detect(aconnector->dc_link, DETECT_REASON_HPD);
+ dc_link_detect(aconnector->dc_link, DETECT_REASON_RESUMEFROMS3S4);
mutex_unlock(&dm->dc_lock);
}
--
2.37.3
next prev parent reply other threads:[~2024-06-26 8:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 8:48 [PATCH 0/3] Fix mst daisy chain light up issue after resume Wayne Lin
2024-06-26 8:48 ` [PATCH 1/3] drm/dp_mst: Fix all mstb marked as not probed after suspend/resume Wayne Lin
2024-06-26 16:22 ` Lyude Paul
2024-06-26 8:48 ` [PATCH 2/3] drm/dp_mst: Skip CSN if topology probing is not done yet Wayne Lin
2024-06-26 16:20 ` Lyude Paul
2024-06-27 9:04 ` Lin, Wayne
2024-06-28 17:40 ` Lyude Paul
2024-07-03 8:13 ` Lin, Wayne
2024-07-03 13:51 ` Lyude Paul
2024-06-26 8:48 ` Wayne Lin [this message]
2024-07-03 14:06 ` [PATCH 3/3] drm/amd/display: Solve mst monitors blank out problem after resume Zuo, Jerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626084825.878565-4-Wayne.Lin@amd.com \
--to=wayne.lin@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=imre.deak@intel.com \
--cc=jani.nikula@intel.com \
--cc=jerry.zuo@amd.com \
--cc=lyude@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox