From: kernel test robot <lkp@intel.com>
To: Melissa Wen <mwen@igalia.com>,
harry.wentland@amd.com, sunpeng.li@amd.com,
Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
daniel@ffwll.ch
Cc: oe-kbuild-all@lists.linux.dev, Alex Hung <alex.hung@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel-dev@igalia.com
Subject: Re: [PATCH v4 11/11] drm/amd/display: remove dc_edid handler from dm_helpers_parse_edid_caps
Date: Sun, 7 Jul 2024 10:24:49 +0800 [thread overview]
Message-ID: <202407071047.0LkXU4JN-lkp@intel.com> (raw)
In-Reply-To: <20240706034004.801329-12-mwen@igalia.com>
Hi Melissa,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20240703]
[cannot apply to amd-pstate/linux-next amd-pstate/bleeding-edge linus/master v6.10-rc6 v6.10-rc5 v6.10-rc4 v6.10-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Melissa-Wen/drm-amd-display-clean-unused-variables-for-hdmi-freesync-parser/20240706-121621
base: next-20240703
patch link: https://lore.kernel.org/r/20240706034004.801329-12-mwen%40igalia.com
patch subject: [PATCH v4 11/11] drm/amd/display: remove dc_edid handler from dm_helpers_parse_edid_caps
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240707/202407071047.0LkXU4JN-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240707/202407071047.0LkXU4JN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407071047.0LkXU4JN-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:92: warning: Excess function parameter 'edid' description in 'dm_helpers_parse_edid_caps'
vim +92 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c
613a7956deb3b1 Aurabindo Pillai 2023-06-12 79
4855fdb5fc5488 Melissa Wen 2024-07-06 80 #define AMDGPU_ELD_DISPLAY_NAME_SIZE_IN_CHARS 13
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 81 /**
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 82 * dm_helpers_parse_edid_caps() - Parse edid caps
4562236b3bc0a2 Harry Wentland 2017-09-12 83 *
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 84 * @link: current detected link
4562236b3bc0a2 Harry Wentland 2017-09-12 85 * @edid: [in] pointer to edid
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 86 * @edid_caps: [in] pointer to edid caps
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 87 *
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 88 * Return: void
f0b60e6e9b2ba3 Srinivasan Shanmugam 2023-07-13 89 */
4dbd1b96ef4bca Melissa Wen 2024-07-06 90 enum dc_edid_status dm_helpers_parse_edid_caps(struct dc_link *link,
4562236b3bc0a2 Harry Wentland 2017-09-12 91 struct dc_edid_caps *edid_caps)
4562236b3bc0a2 Harry Wentland 2017-09-12 @92 {
3c021931023a30 Claudio Suarez 2021-10-17 93 struct amdgpu_dm_connector *aconnector = link->priv;
3c021931023a30 Claudio Suarez 2021-10-17 94 struct drm_connector *connector = &aconnector->base;
766cded62d4ba6 Melissa Wen 2024-07-06 95 const struct drm_edid *drm_edid = aconnector->drm_edid;
766cded62d4ba6 Melissa Wen 2024-07-06 96 struct drm_edid_product_id product_id;
c3e817e49503e3 Melissa Wen 2024-07-06 97 int sad_count;
4562236b3bc0a2 Harry Wentland 2017-09-12 98 int i = 0;
4562236b3bc0a2 Harry Wentland 2017-09-12 99 enum dc_edid_status result = EDID_OK;
4562236b3bc0a2 Harry Wentland 2017-09-12 100
4dbd1b96ef4bca Melissa Wen 2024-07-06 101 if (!edid_caps || !drm_edid)
4562236b3bc0a2 Harry Wentland 2017-09-12 102 return EDID_BAD_INPUT;
4562236b3bc0a2 Harry Wentland 2017-09-12 103
766cded62d4ba6 Melissa Wen 2024-07-06 104 drm_edid_get_product_id(drm_edid, &product_id);
766cded62d4ba6 Melissa Wen 2024-07-06 105
766cded62d4ba6 Melissa Wen 2024-07-06 106 edid_caps->manufacturer_id = le16_to_cpu(product_id.manufacturer_name);
766cded62d4ba6 Melissa Wen 2024-07-06 107 edid_caps->product_id = le16_to_cpu(product_id.product_code);
766cded62d4ba6 Melissa Wen 2024-07-06 108 edid_caps->serial_number = le32_to_cpu(product_id.serial_number);
766cded62d4ba6 Melissa Wen 2024-07-06 109 edid_caps->manufacture_week = product_id.week_of_manufacture;
766cded62d4ba6 Melissa Wen 2024-07-06 110 edid_caps->manufacture_year = product_id.year_of_manufacture;
4562236b3bc0a2 Harry Wentland 2017-09-12 111
4855fdb5fc5488 Melissa Wen 2024-07-06 112 memset(edid_caps->display_name, 0, AUDIO_INFO_DISPLAY_NAME_SIZE_IN_CHARS);
4855fdb5fc5488 Melissa Wen 2024-07-06 113 memcpy(edid_caps->display_name,
4855fdb5fc5488 Melissa Wen 2024-07-06 114 &connector->eld[DRM_ELD_MONITOR_NAME_STRING],
4855fdb5fc5488 Melissa Wen 2024-07-06 115 AMDGPU_ELD_DISPLAY_NAME_SIZE_IN_CHARS);
4562236b3bc0a2 Harry Wentland 2017-09-12 116
3c021931023a30 Claudio Suarez 2021-10-17 117 edid_caps->edid_hdmi = connector->display_info.is_hdmi;
4562236b3bc0a2 Harry Wentland 2017-09-12 118
766cded62d4ba6 Melissa Wen 2024-07-06 119 apply_edid_quirks(&product_id, edid_caps);
b7cdccc6a84956 Ryan Lin 2024-02-28 120
b13a74b7280b1a Melissa Wen 2024-07-06 121 sad_count = drm_eld_sad_count(connector->eld);
ae2a3495973ef0 Jean Delvare 2019-09-04 122 if (sad_count <= 0)
4562236b3bc0a2 Harry Wentland 2017-09-12 123 return result;
4562236b3bc0a2 Harry Wentland 2017-09-12 124
1347b15d5e8e16 Srinivasan Shanmugam 2023-08-13 125 edid_caps->audio_mode_count = min(sad_count, DC_MAX_AUDIO_DESC_COUNT);
4562236b3bc0a2 Harry Wentland 2017-09-12 126 for (i = 0; i < edid_caps->audio_mode_count; ++i) {
b13a74b7280b1a Melissa Wen 2024-07-06 127 struct cea_sad sad;
4562236b3bc0a2 Harry Wentland 2017-09-12 128
b13a74b7280b1a Melissa Wen 2024-07-06 129 if (drm_eld_sad_get(connector->eld, i, &sad) < 0)
b13a74b7280b1a Melissa Wen 2024-07-06 130 continue;
b13a74b7280b1a Melissa Wen 2024-07-06 131
b13a74b7280b1a Melissa Wen 2024-07-06 132 edid_caps->audio_modes[i].format_code = sad.format;
b13a74b7280b1a Melissa Wen 2024-07-06 133 edid_caps->audio_modes[i].channel_count = sad.channels + 1;
b13a74b7280b1a Melissa Wen 2024-07-06 134 edid_caps->audio_modes[i].sample_rate = sad.freq;
b13a74b7280b1a Melissa Wen 2024-07-06 135 edid_caps->audio_modes[i].sample_size = sad.byte2;
4562236b3bc0a2 Harry Wentland 2017-09-12 136 }
4562236b3bc0a2 Harry Wentland 2017-09-12 137
4562236b3bc0a2 Harry Wentland 2017-09-12 138
c3e817e49503e3 Melissa Wen 2024-07-06 139 if (connector->eld[DRM_ELD_SPEAKER])
c3e817e49503e3 Melissa Wen 2024-07-06 140 edid_caps->speaker_flags = connector->eld[DRM_ELD_SPEAKER];
4562236b3bc0a2 Harry Wentland 2017-09-12 141 else
4562236b3bc0a2 Harry Wentland 2017-09-12 142 edid_caps->speaker_flags = DEFAULT_SPEAKER_LOCATION;
4562236b3bc0a2 Harry Wentland 2017-09-12 143
4562236b3bc0a2 Harry Wentland 2017-09-12 144 return result;
4562236b3bc0a2 Harry Wentland 2017-09-12 145 }
4562236b3bc0a2 Harry Wentland 2017-09-12 146
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2024-07-07 2:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-06 3:35 [PATCH v4 00/11] drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid Melissa Wen
2024-07-06 3:35 ` [PATCH v4 01/11] drm/amd/display: clean unused variables for hdmi freesync parser Melissa Wen
2024-07-25 16:23 ` Alex Hung
2024-07-29 1:32 ` Melissa Wen
2024-07-29 13:24 ` Alex Hung
2024-07-06 3:35 ` [PATCH v4 02/11] drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid Melissa Wen
2024-07-25 16:35 ` Alex Hung
2024-07-29 1:59 ` Melissa Wen
2024-07-06 3:35 ` [PATCH v4 03/11] drm/amd/display: switch to setting physical address directly Melissa Wen
2024-07-25 16:36 ` Alex Hung
2024-07-06 3:35 ` [PATCH v4 04/11] drm/amd/display: always call connector_update when parsing freesync_caps Melissa Wen
2024-07-06 3:35 ` [PATCH v4 05/11] drm/amd/display: remove redundant freesync parser for DP Melissa Wen
2024-07-06 3:35 ` [PATCH v4 06/11] drm/amd/display: use drm_edid_product_id for parsing EDID product info Melissa Wen
2024-07-06 3:35 ` [PATCH v4 07/11] drm/amd/display: don't give initial values for sad/b_count Melissa Wen
2024-07-25 16:38 ` Alex Hung
2024-07-29 2:01 ` Melissa Wen
2024-07-06 3:35 ` [PATCH v4 08/11] drm/amd/display: parse display name from drm_eld Melissa Wen
2024-07-06 3:35 ` [PATCH v4 09/11] drm/amd/display: get SAD from drm_eld when parsing EDID caps Melissa Wen
2024-07-25 16:39 ` Alex Hung
2024-07-29 2:02 ` Melissa Wen
2024-07-29 13:27 ` Alex Hung
2024-07-06 3:35 ` [PATCH v4 10/11] drm/amd/display: get SADB " Melissa Wen
2024-07-25 16:40 ` Alex Hung
2024-07-06 3:35 ` [PATCH v4 11/11] drm/amd/display: remove dc_edid handler from dm_helpers_parse_edid_caps Melissa Wen
2024-07-07 2:24 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202407071047.0LkXU4JN-lkp@intel.com \
--to=lkp@intel.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-dev@igalia.com \
--cc=mario.limonciello@amd.com \
--cc=mwen@igalia.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox