From: Melissa Wen <mwen@igalia.com>
To: harry.wentland@amd.com, sunpeng.li@amd.com,
Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
daniel@ffwll.ch
Cc: Alex Hung <alex.hung@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
kernel-dev@igalia.com, Melissa Wen <mwen@igalia.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v5 6/9] drm/amd/display: parse display name from drm_eld
Date: Wed, 7 Aug 2024 19:25:08 -0100 [thread overview]
Message-ID: <20240807203207.2830-7-mwen@igalia.com> (raw)
In-Reply-To: <20240807203207.2830-1-mwen@igalia.com>
We don't need to parse dc_edid to get the display name since it's
already set in drm_eld which in turn had it values updated when updating
connector with the opaque drm_edid.
Signed-off-by: Melissa Wen <mwen@igalia.com>
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
index 1e454cfcaef2..89ffd36dafd3 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
@@ -32,7 +32,7 @@
#include <drm/amdgpu_drm.h>
#include <drm/drm_edid.h>
#include <drm/drm_fixed.h>
-
+#include <drm/drm_eld.h>
#include "dm_services.h"
#include "amdgpu.h"
#include "dc.h"
@@ -77,6 +77,7 @@ static void apply_edid_quirks(struct drm_edid_product_id *product_id, struct dc_
}
}
+#define AMDGPU_ELD_DISPLAY_NAME_SIZE_IN_CHARS 13
/**
* dm_helpers_parse_edid_caps() - Parse edid caps
*
@@ -118,9 +119,10 @@ enum dc_edid_status dm_helpers_parse_edid_caps(
edid_caps->manufacture_week = product_id.week_of_manufacture;
edid_caps->manufacture_year = product_id.year_of_manufacture;
- drm_edid_get_monitor_name(edid_buf,
- edid_caps->display_name,
- AUDIO_INFO_DISPLAY_NAME_SIZE_IN_CHARS);
+ memset(edid_caps->display_name, 0, AUDIO_INFO_DISPLAY_NAME_SIZE_IN_CHARS);
+ memcpy(edid_caps->display_name,
+ &connector->eld[DRM_ELD_MONITOR_NAME_STRING],
+ AMDGPU_ELD_DISPLAY_NAME_SIZE_IN_CHARS);
edid_caps->edid_hdmi = connector->display_info.is_hdmi;
--
2.43.0
next prev parent reply other threads:[~2024-08-07 20:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 20:25 [PATCH v5 0/9] drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid Melissa Wen
2024-08-07 20:25 ` [PATCH v5 1/9] " Melissa Wen
2024-08-07 20:25 ` [PATCH v5 2/9] drm/amd/display: switch to setting physical address directly Melissa Wen
2024-08-07 20:25 ` [PATCH v5 3/9] drm/amd/display: always call connector_update when parsing freesync_caps Melissa Wen
2024-08-07 20:25 ` [PATCH v5 4/9] drm/amd/display: remove redundant freesync parser for DP Melissa Wen
2024-08-07 20:25 ` [PATCH v5 5/9] drm/amd/display: use drm_edid_product_id for parsing EDID product info Melissa Wen
2024-08-07 20:25 ` Melissa Wen [this message]
2024-08-07 20:25 ` [PATCH v5 7/9] drm/amd/display: get SAD from drm_eld when parsing EDID caps Melissa Wen
2024-08-07 20:25 ` [PATCH v5 8/9] drm/amd/display: get SADB " Melissa Wen
2024-08-07 20:25 ` [PATCH v5 9/9] drm/amd/display: remove dc_edid handler from dm_helpers_parse_edid_caps Melissa Wen
2024-08-08 9:01 ` [PATCH v5 0/9] drm/amd/display: switch amdgpu_dm_connector to use struct drm_edid Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807203207.2830-7-mwen@igalia.com \
--to=mwen@igalia.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-dev@igalia.com \
--cc=mario.limonciello@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox