From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 287BDC5320E for ; Sun, 18 Aug 2024 20:13:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 044F810E160; Sun, 18 Aug 2024 20:13:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="C9vVDF75"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 82D1910E11F; Sun, 18 Aug 2024 20:13:26 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8523B8A9; Sun, 18 Aug 2024 22:12:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1724011944; bh=spm+vGN5EQwtcVCujDzNDZ7flxfLEHLbATgJd0V/Lak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C9vVDF75BUE5ZLkO/xuAvAQWELzrAqkTOiHzLi6osl3dBZAu9oZiZo28SGbCiHPuu 73xgjo292b0Nv4TVLOT23T8louYR2JIVQpsxBDZVTIBjgooefFcYwADUJuhYpq6JWU ZZkB5gVoEFzMCTgYaHuA2JtOT1aMcpd54BdNgpHA= Date: Sun, 18 Aug 2024 23:12:58 +0300 From: Laurent Pinchart To: Thomas Zimmermann Cc: daniel@ffwll.ch, airlied@gmail.com, jfalempe@redhat.com, javierm@redhat.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, Kieran Bingham Subject: Re: [PATCH 34/86] drm/renesas/rcar-du: Run DRM default client setup Message-ID: <20240818201258.GG29465@pendragon.ideasonboard.com> References: <20240816125408.310253-1-tzimmermann@suse.de> <20240816125408.310253-35-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240816125408.310253-35-tzimmermann@suse.de> X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi Thomas, Thank you for the patch. On Fri, Aug 16, 2024 at 02:23:00PM +0200, Thomas Zimmermann wrote: > Call drm_client_setup() to run the kernel's default client setup > for DRM. Set fbdev_probe in struct drm_driver, so that the client > setup can start the common fbdev client. > > The rcar-du driver specifies a preferred color mode of 32. As this > is the default if no format has been given, leave it out entirely. > > Signed-off-by: Thomas Zimmermann > Cc: Laurent Pinchart > Cc: Kieran Bingham Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c > index fb719d9aff10..4e0bafc86f50 100644 > --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c > @@ -19,6 +19,7 @@ > #include > > #include > +#include > #include > #include > #include > @@ -606,6 +607,7 @@ static const struct drm_driver rcar_du_driver = { > .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > .dumb_create = rcar_du_dumb_create, > .gem_prime_import_sg_table = rcar_du_gem_prime_import_sg_table, > + DRM_FBDEV_DMA_DRIVER_OPS, > .fops = &rcar_du_fops, > .name = "rcar-du", > .desc = "Renesas R-Car Display Unit", > @@ -716,7 +718,7 @@ static int rcar_du_probe(struct platform_device *pdev) > > drm_info(&rcdu->ddev, "Device %s probed\n", dev_name(&pdev->dev)); > > - drm_fbdev_dma_setup(&rcdu->ddev, 32); > + drm_client_setup(&rcdu->ddev, NULL); > > return 0; > -- Regards, Laurent Pinchart