Re: [PATCH v5 28/44] drm/amd/display: Add support for sRGB Inverse EOTF in SHAPER block

[kernel test robot <lkp@intel.com>]

Hi Harry,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm/drm-next]
[also build test WARNING on drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc4 next-20240820]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Harry-Wentland/drm-Add-helper-for-conversion-from-signed-magnitude/20240820-050138
base:   git://anongit.freedesktop.org/drm/drm drm-next
patch link:    https://lore.kernel.org/r/20240819205714.316380-29-harry.wentland%40amd.com
patch subject: [PATCH v5 28/44] drm/amd/display: Add support for sRGB Inverse EOTF in SHAPER block
config: x86_64-randconfig-003-20240821 (https://download.01.org/0day-ci/archive/20240821/202408211241.xAvubshv-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240821/202408211241.xAvubshv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408211241.xAvubshv-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_color.c:1232:42: warning: variable 'shaper_size' is uninitialized when used here [-Wuninitialized]
    1232 |                 return __set_output_tf(tf, shaper_lut, shaper_size, false);
         |                                                        ^~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_color.c:1214:22: note: initialize the variable 'shaper_size' to silence this warning
    1214 |         uint32_t shaper_size;
         |                             ^
         |                              = 0
   1 warning generated.


vim +/shaper_size +1232 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_color.c

  1205	
  1206	static int
  1207	__set_colorop_in_shaper_1d_curve(struct dc_plane_state *dc_plane_state,
  1208			       struct drm_colorop_state *colorop_state)
  1209	{
  1210		struct dc_transfer_func *tf = &dc_plane_state->in_shaper_func;
  1211		struct drm_colorop *colorop = colorop_state->colorop;
  1212		struct drm_device *drm = colorop->dev;
  1213		const struct drm_color_lut *shaper_lut;
  1214		uint32_t shaper_size;
  1215	
  1216		if (colorop->type != DRM_COLOROP_1D_CURVE &&
  1217		    colorop_state->curve_1d_type != DRM_COLOROP_1D_CURVE_SRGB_INV_EOTF)
  1218			return -EINVAL;
  1219	
  1220		if (colorop_state->bypass) {
  1221			tf->type = TF_TYPE_BYPASS;
  1222			tf->tf = TRANSFER_FUNCTION_LINEAR;
  1223			return 0;
  1224		}
  1225	
  1226		drm_dbg(drm, "Shaper colorop with ID: %d\n", colorop->base.id);
  1227	
  1228		if (colorop->type == DRM_COLOROP_1D_CURVE) {
  1229			tf->type = TF_TYPE_DISTRIBUTED_POINTS;
  1230			tf->tf = amdgpu_colorop_tf_to_dc_tf(colorop_state->curve_1d_type);
  1231			tf->sdr_ref_white_level = SDR_WHITE_LEVEL_INIT_VALUE;
> 1232			return __set_output_tf(tf, shaper_lut, shaper_size, false);
  1233		}
  1234	
  1235		return -EINVAL;
  1236	}
  1237	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki