From: Sunil Khatri <sunil.khatri@amd.com>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Cc: amd-gfx@lists.freedesktop.org, Sunil Khatri <sunil.khatri@amd.com>
Subject: [PATCH v3 10/16] drm/amdgpu: clean the dummy suspend functions
Date: Wed, 16 Oct 2024 12:52:52 +0530 [thread overview]
Message-ID: <20241016072258.1399698-11-sunil.khatri@amd.com> (raw)
In-Reply-To: <20241016072258.1399698-1-sunil.khatri@amd.com>
Remove the dummy suspend functions for all
ip blocks.
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c | 6 ------
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/cik.c | 6 ------
drivers/gpu/drm/amd/amdgpu/si.c | 6 ------
4 files changed, 2 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
index 1383fd1644d6..4d82e8fec0f5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c
@@ -66,11 +66,6 @@ static int isp_hw_fini(struct amdgpu_ip_block *ip_block)
return -ENODEV;
}
-static int isp_suspend(struct amdgpu_ip_block *ip_block)
-{
- return 0;
-}
-
static int isp_load_fw_by_psp(struct amdgpu_device *adev)
{
const struct common_firmware_header *hdr;
@@ -161,7 +156,6 @@ static const struct amd_ip_funcs isp_ip_funcs = {
.late_init = NULL,
.hw_init = isp_hw_init,
.hw_fini = isp_hw_fini,
- .suspend = isp_suspend,
.is_idle = isp_is_idle,
.wait_for_idle = isp_wait_for_idle,
.soft_reset = isp_soft_reset,
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
index fd31e2e9feb9..ed8015313827 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
@@ -613,7 +613,8 @@ static int amdgpu_vkms_suspend(struct amdgpu_ip_block *ip_block)
r = drm_mode_config_helper_suspend(adev_to_drm(adev));
if (r)
return r;
- return amdgpu_vkms_hw_fini(ip_block);
+
+ return 0;
}
static int amdgpu_vkms_resume(struct amdgpu_ip_block *ip_block)
diff --git a/drivers/gpu/drm/amd/amdgpu/cik.c b/drivers/gpu/drm/amd/amdgpu/cik.c
index f3f6b32d4e2a..c8fb592f13df 100644
--- a/drivers/gpu/drm/amd/amdgpu/cik.c
+++ b/drivers/gpu/drm/amd/amdgpu/cik.c
@@ -2143,11 +2143,6 @@ static int cik_common_hw_fini(struct amdgpu_ip_block *ip_block)
return 0;
}
-static int cik_common_suspend(struct amdgpu_ip_block *ip_block)
-{
- return cik_common_hw_fini(ip_block);
-}
-
static int cik_common_resume(struct amdgpu_ip_block *ip_block)
{
return cik_common_hw_init(ip_block);
@@ -2187,7 +2182,6 @@ static const struct amd_ip_funcs cik_common_ip_funcs = {
.late_init = NULL,
.hw_init = cik_common_hw_init,
.hw_fini = cik_common_hw_fini,
- .suspend = cik_common_suspend,
.resume = cik_common_resume,
.is_idle = cik_common_is_idle,
.wait_for_idle = cik_common_wait_for_idle,
diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
index f0817d5fbea8..66ccb76eb72a 100644
--- a/drivers/gpu/drm/amd/amdgpu/si.c
+++ b/drivers/gpu/drm/amd/amdgpu/si.c
@@ -2639,11 +2639,6 @@ static int si_common_hw_fini(struct amdgpu_ip_block *ip_block)
return 0;
}
-static int si_common_suspend(struct amdgpu_ip_block *ip_block)
-{
- return si_common_hw_fini(ip_block);
-}
-
static int si_common_resume(struct amdgpu_ip_block *ip_block)
{
return si_common_hw_init(ip_block);
@@ -2682,7 +2677,6 @@ static const struct amd_ip_funcs si_common_ip_funcs = {
.late_init = NULL,
.hw_init = si_common_hw_init,
.hw_fini = si_common_hw_fini,
- .suspend = si_common_suspend,
.resume = si_common_resume,
.is_idle = si_common_is_idle,
.wait_for_idle = si_common_wait_for_idle,
--
2.34.1
next prev parent reply other threads:[~2024-10-16 7:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 7:22 [PATCH v3 00/16] clean unused functions of amd_ip_funcs Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 01/16] drm/amdgpu: validate sw_init before function call Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 02/16] drm/amdgpu: clean the dummy sw_init functions Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 03/16] drm/amdgpu: validate sw_fini before function call Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 04/16] drm/amdgpu: clean the dummy sw_fini functions Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 05/16] drm/amdgpu: validate hw_fini before function call Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 06/16] drm/amdgpu: validate suspend " Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 07/16] drm/amdgpu: validate resume " Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 08/16] drm/amdgpu: validate wait_for_idle " Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 09/16] drm/amdgpu: clean the dummy resume functions Sunil Khatri
2024-10-16 7:22 ` Sunil Khatri [this message]
2024-10-16 7:22 ` [PATCH v3 11/16] drm/amdgpu: clean the dummy hw_fini functions Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 12/16] drm/amdgpu: clean the dummy wait_for_idle functions Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 13/16] drm/amdgpu: clean the dummy soft_reset functions Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 14/16] drm/amdgpu: clean unused functions of amd_ip_funcs Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 15/16] drm/amdgpu: validate get_clockgating_state before use Sunil Khatri
2024-10-16 7:22 ` [PATCH v3 16/16] drm/amdgpu: validate hw_init function pointers Sunil Khatri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016072258.1399698-11-sunil.khatri@amd.com \
--to=sunil.khatri@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox