From: Alex Deucher <alexander.deucher@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: [PATCH 3/3] drm/amdgpu: add missing size check in amdgpu_debugfs_gprwave_read()
Date: Wed, 23 Oct 2024 17:03:42 -0400 [thread overview]
Message-ID: <20241023210342.685808-3-alexander.deucher@amd.com> (raw)
In-Reply-To: <20241023210342.685808-1-alexander.deucher@amd.com>
Avoid a possible buffer overflow if size is larger than 4K.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
index 2ef7bcfdb2e2..3a118645b4bb 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
@@ -402,7 +402,7 @@ static ssize_t amdgpu_debugfs_gprwave_read(struct file *f, char __user *buf, siz
int r;
uint32_t *data, x;
- if (size & 0x3 || *pos & 0x3)
+ if (size > 4096 || size & 0x3 || *pos & 0x3)
return -EINVAL;
r = pm_runtime_get_sync(adev_to_drm(adev)->dev);
--
2.46.2
next prev parent reply other threads:[~2024-10-23 21:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 21:03 [PATCH 1/3] drm/amdgpu: Adjust debugfs register access permissions Alex Deucher
2024-10-23 21:03 ` [PATCH 2/3] drm/amdgpu: Adjust debugfs eviction and IB " Alex Deucher
2024-10-23 21:03 ` Alex Deucher [this message]
2024-10-28 14:42 ` [PATCH 1/3] drm/amdgpu: Adjust debugfs register " Alex Deucher
2024-10-30 16:02 ` Alex Deucher
2024-10-31 2:23 ` Wang, Yang(Kevin)
2024-10-31 2:58 ` Alex Deucher
2024-10-31 3:31 ` Wang, Yang(Kevin)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023210342.685808-3-alexander.deucher@amd.com \
--to=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox