AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yunxiang Li <Yunxiang.Li@amd.com>
To: <dri-devel@lists.freedesktop.org>,
	<amd-gfx@lists.freedesktop.org>, <christian.koenig@amd.com>,
	<tvrtko.ursulin@igalia.com>
Cc: <Alexander.Deucher@amd.com>, Yunxiang Li <Yunxiang.Li@amd.com>
Subject: [PATCH v6 0/5] rework bo mem stats tracking
Date: Fri, 25 Oct 2024 13:41:08 -0400	[thread overview]
Message-ID: <20241025174113.554-1-Yunxiang.Li@amd.com> (raw)

Right now every time the fdinfo is read, we go through the vm lists and
lock all the BOs to calcuate the statistics. This causes a lot of lock
contention when the VM is actively used. It gets worse if there is a lot
of shared BOs or if there's a lot of submissions. We have seen
submissions lock-up for seconds due to fdinfo for some workload.
Therefore, rework the implementation to track the BOs as they get moved
around.

Also the visible memory stat is removed to simplify implementation, it's
unclear how useful this stat is since kernel map/unmap BOs whenever it
wants to and on a modern system all of VRAM can be mapped if needed.

v5: rebase on top of the drm_print_memory_stats refactor
v6: split the drm changes into a seperate patch for drm-devel review,
fix handling of drm-total- vs drm-resident- and handle drm-purgable-.

I'm currently stuck on drm-active-, I don't know where would be a good
place to add such info, especially how I could remove a BO's stat when
it's fence is signaled.

Yunxiang Li (5):
  drm/amdgpu: remove unused function parameter
  drm/amdgpu: make drm-memory-* report resident memory
  drm/amdgpu: stop tracking visible memory stats
  drm: add drm_memory_stats_is_zero
  drm/amdgpu: track bo memory stats at runtime

 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c      |   4 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c |  16 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c  |  23 +--
 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c     |   3 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c  | 119 +++---------
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.h  |  16 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h     |   2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c      | 193 +++++++++++++++-----
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h      |  26 ++-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c   |   1 +
 drivers/gpu/drm/drm_file.c                  |   9 +
 include/drm/drm_file.h                      |   1 +
 12 files changed, 230 insertions(+), 183 deletions(-)

-- 
2.34.1


             reply	other threads:[~2024-10-25 17:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25 17:41 Yunxiang Li [this message]
2024-10-25 17:41 ` [PATCH v6 1/5] drm/amdgpu: remove unused function parameter Yunxiang Li
2024-10-25 17:41 ` [PATCH v6 2/5] drm/amdgpu: make drm-memory-* report resident memory Yunxiang Li
2024-10-25 17:41 ` [PATCH v6 3/5] drm/amdgpu: stop tracking visible memory stats Yunxiang Li
2024-10-25 17:41 ` [PATCH v6 4/5] drm: add drm_memory_stats_is_zero Yunxiang Li
2024-10-31 12:34   ` Christian König
2024-11-07 10:41   ` Tvrtko Ursulin
2024-11-07 14:17     ` Li, Yunxiang (Teddy)
2024-11-07 14:43       ` Tvrtko Ursulin
2024-11-07 14:47         ` Christian König
2024-10-25 17:41 ` [PATCH v6 5/5] drm/amdgpu: track bo memory stats at runtime Yunxiang Li
2024-10-31 12:53   ` Christian König
2024-10-31 13:48     ` Li, Yunxiang (Teddy)
2024-11-07 10:48       ` Tvrtko Ursulin
2024-11-07 14:24         ` Li, Yunxiang (Teddy)
2024-11-07 14:55           ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241025174113.554-1-Yunxiang.Li@amd.com \
    --to=yunxiang.li@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=tvrtko.ursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox