From: Alexandre Demers <alexandre.f.demers@gmail.com>
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH 2/5] drm/amdgpu: use cik_sdma_is_idle() in CIK SDMA
Date: Sat, 22 Mar 2025 14:37:43 -0400 [thread overview]
Message-ID: <20250322183746.86002-3-alexandre.f.demers@gmail.com> (raw)
In-Reply-To: <20250322183746.86002-1-alexandre.f.demers@gmail.com>
cik_sdma_is_idle() does exactly what we need, so use it.
Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c
index ede1a028d48d..e7c06ce7ffae 100644
--- a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c
+++ b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c
@@ -1038,14 +1038,10 @@ static bool cik_sdma_is_idle(void *handle)
static int cik_sdma_wait_for_idle(struct amdgpu_ip_block *ip_block)
{
unsigned i;
- u32 tmp;
struct amdgpu_device *adev = ip_block->adev;
for (i = 0; i < adev->usec_timeout; i++) {
- tmp = RREG32(mmSRBM_STATUS2) & (SRBM_STATUS2__SDMA_BUSY_MASK |
- SRBM_STATUS2__SDMA1_BUSY_MASK);
-
- if (!tmp)
+ if (cik_sdma_is_idle(adev))
return 0;
udelay(1);
}
--
2.49.0
next prev parent reply other threads:[~2025-03-22 18:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 18:37 [PATCH 0/5] Small tidy up of CIK code Alexandre Demers
2025-03-22 18:37 ` [PATCH 1/5] drm/amdgpu: use gmc_v7_0_is_idle() since it is available under GMC7 Alexandre Demers
2025-03-24 18:23 ` Alex Deucher
2025-03-22 18:37 ` Alexandre Demers [this message]
2025-03-22 18:37 ` [PATCH 3/5] drm/amdgpu: small cleanup to CIK SDMA Alexandre Demers
2025-03-22 18:37 ` [PATCH 4/5] drm/amdgpu: move X_GB_ADDR_CONFIG_GOLDEN in GFX7 Alexandre Demers
2025-03-22 18:37 ` [PATCH 6/5] drm/amdgpu: fix style in dce_v8_0.c and in vi.c Alexandre Demers
2025-03-22 18:46 ` Alexandre Demers
2025-03-24 18:20 ` Alex Deucher
2025-03-27 4:16 ` Alexandre Demers
2025-03-27 15:21 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250322183746.86002-3-alexandre.f.demers@gmail.com \
--to=alexandre.f.demers@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox