From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE01AC369D9 for ; Sun, 27 Apr 2025 10:13:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 11B0510E36E; Sun, 27 Apr 2025 10:13:15 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="K4HJKU+o"; dkim-atps=neutral Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3CDF110E183; Sun, 27 Apr 2025 09:46:03 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-224172f32b3so9374715ad.2; Sun, 27 Apr 2025 02:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745747163; x=1746351963; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+KDTqcMZlGtBruM/CFwkX9atXMGLUR7NjJmS88z9xoA=; b=K4HJKU+oL8aTBrXDsxQdBqV0uQK3Da4mweiWSbQd4HZwi1nxvSO+XM3MzG2jzfQEjx +yO4VwabVqiROGw4sFQstDb2D3M5RkZAUNV1FKFfCHXazJLkXjylYEmMJup8eBhmLqGk lOfrlmHoBqxzRjN+T8xvCGwEhiAloPDD4nHeMB4G+nbAvQe8cwihnmwiPDzd2uUDXZN4 jxFTuAq/ca5gQuNkUcg+4kO3hLj6cA/qhnGFMkKNoNdgDNZr1ta89J0QVmtwt7z1S7Fa oD3kGy2acHaVh1KVmX+kLgke4W5+D3y3fznpXp8TKRl0J6kV2gDCoM0/i+lvoPdQDPlt +PcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745747163; x=1746351963; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+KDTqcMZlGtBruM/CFwkX9atXMGLUR7NjJmS88z9xoA=; b=uT4q3JAwg8FIF4OggoJbFd5ozUuOMzjeYVsx3SVTe21bi58jBPQ0gIkbpM0SgDzAHV KdWZ5+DYC6DsbW3wjFaiGDqCXxZ5ArUTYGk1hQ7+U/csBiZ7x0uyvVzwj6U115AkEpMF z8Usd5PFWT+aIINefbiJDImLsu1OdSkG/kG+OEMrRWXqAHkIJ9a6A5UwVBd1k/ZUZyEi x90sADz5uXP/fr8L5pHro5mG8qDpI72Uf4dhlmrxWDoWWZD/DbBxFcyQmqtTq3oppctq FAREnhySEuIyojexka0owB2N5flA8WMNXwaOu6baki02eoEtJfSOaOjChxI86D3cPmjM yTMw== X-Forwarded-Encrypted: i=1; AJvYcCVs00jczsKvcWuy19SRkGe80z+bB8SYNY7CmlOUzGeMUOnZI588MHv58g50LC6Yt6w4i5lRgpgPIHE=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yz2wJMcg2jfwQz3aFCFZh8gycBV+i6A9UVjAjXB7KYoTFzYYTU3 bc0oa3SAma/Rvgs+Sl1xb3qPwTaTWFpz4jvAcgKSxT1UxKF8IdKTkNgefsrT X-Gm-Gg: ASbGncuXYCznIWMke62d4i6IJbLOaYgsBxneo0veEEWIyNTaGeiomFwSRGNZX0VH9JA jptD1WyjCChp73gzS4oKJzrl3ZLSSJgFXNWwrOaIWz2gS9ILolWvRb+xOQYdhGFhYDolyhgfEPz 9YYmnm5zla8naibNa2mtE+9UYpJGewI20fk0dDAc6XAC1ZKjGfEhg/68hBztOPAy12ZVu6oyhou hncbuY8lTpIJHAGSoJEYt9YtFOADNxWboUX2Xx+P+ssxmy0STSemmlk+jB3vWLeVjZmjmM439zF ycnd20djOaZvs7p+cO08M/6nntfJMEpjmL6FaiwAleGOQdssOeI= X-Google-Smtp-Source: AGHT+IFgcciqD50PlJmVfjc1kvZFMb6P1l5O/9ptq2pZnaHuOKXwCR7aBlX0yzuIsyy5e/DKD2Gdyg== X-Received: by 2002:a17:902:dac2:b0:21f:356:758f with SMTP id d9443c01a7336-22dbf5df830mr46268985ad.3.1745747162689; Sun, 27 Apr 2025 02:46:02 -0700 (PDT) Received: from dev.. ([2402:e280:214c:86:df9f:2e4f:f8a7:6d85]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db50e7a33sm61557025ad.146.2025.04.27.02.45.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Apr 2025 02:46:02 -0700 (PDT) From: R Sundar To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , Sunil Khatri , Tim Huang , "Jesse . zhang @ amd . com" , Boyuan Zhang , Pierre-Eric Pelloux-Prayer , Yang Wang , Peyton Lee Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, R Sundar , kernel test robot , Julia Lawall Subject: [PATCH linux-next] drm/amdgpu: use string choice helpers Date: Sun, 27 Apr 2025 15:15:36 +0530 Message-Id: <20250427094536.353823-1-prosunofficial@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Sun, 27 Apr 2025 10:13:10 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Use string choice helpers for better readability. Reported-by: kernel test robot Reported-by: Julia Lawall Closes: https://lore.kernel.org/r/202503222049.sUXL3q6w-lkp@intel.com/ Signed-off-by: R Sundar --- Reported in linux repository. cocci warnings: (new ones prefixed by >>) >> drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c:311:49-70: opportunity for str_true_false(vpe -> collaborate_mode) vim +311 drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c for linux-next: drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c index 121ee17b522b..442d137e0fed 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c @@ -317,7 +317,7 @@ static int vpe_early_init(struct amdgpu_ip_block *ip_block) vpe_set_ring_funcs(adev); vpe_set_regs(vpe); - dev_info(adev->dev, "VPE: collaborate mode %s", vpe->collaborate_mode ? "true" : "false"); + dev_info(adev->dev, "VPE: collaborate mode %s", str_true_false(vpe->collaborate_mode)); return 0; } -- 2.34.1