* [PATCH 1/2] drm/amdgpu: Fix jpeg v4.0.3 poison irq call trace on sriov guest
@ 2025-07-31 7:18 Xiang Liu
2025-07-31 7:18 ` [PATCH 2/2] drm/amdgpu: Fix vcn " Xiang Liu
0 siblings, 1 reply; 3+ messages in thread
From: Xiang Liu @ 2025-07-31 7:18 UTC (permalink / raw)
To: amd-gfx; +Cc: Hawking.Zhang, Stanley.Yang, Xiang Liu
Sriov guest side doesn't init ras feature hence the poison irq shouldn't
be put during hw fini.
Fixes: 810a6a2de64d ("drm/amdgpu: Register aqua vanjaram jpeg poison irq")
[25209.467154] Call Trace:
[25209.467156] <TASK>
[25209.467158] ? srso_alias_return_thunk+0x5/0x7f
[25209.467162] ? show_trace_log_lvl+0x28e/0x2ea
[25209.467166] ? show_trace_log_lvl+0x28e/0x2ea
[25209.467171] ? jpeg_v4_0_3_hw_fini+0x6f/0x90 [amdgpu]
[25209.467300] ? show_regs.part.0+0x23/0x29
[25209.467303] ? show_regs.cold+0x8/0xd
[25209.467304] ? amdgpu_irq_put+0x9e/0xc0 [amdgpu]
[25209.467403] ? __warn+0x8c/0x100
[25209.467407] ? amdgpu_irq_put+0x9e/0xc0 [amdgpu]
[25209.467503] ? report_bug+0xa4/0xd0
[25209.467508] ? handle_bug+0x39/0x90
[25209.467511] ? exc_invalid_op+0x19/0x70
[25209.467513] ? asm_exc_invalid_op+0x1b/0x20
[25209.467518] ? amdgpu_irq_put+0x9e/0xc0 [amdgpu]
[25209.467613] ? amdgpu_irq_put+0x5f/0xc0 [amdgpu]
[25209.467709] jpeg_v4_0_3_hw_fini+0x6f/0x90 [amdgpu]
[25209.467805] amdgpu_ip_block_hw_fini+0x34/0x61 [amdgpu]
[25209.467971] amdgpu_device_fini_hw+0x3b3/0x467 [amdgpu]
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c
index b86288a69e7b..a78144773fab 100644
--- a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c
+++ b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c
@@ -444,7 +444,7 @@ static int jpeg_v4_0_3_hw_fini(struct amdgpu_ip_block *ip_block)
ret = jpeg_v4_0_3_set_powergating_state(ip_block, AMD_PG_STATE_GATE);
}
- if (amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__JPEG))
+ if (amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__JPEG) && !amdgpu_sriov_vf(adev))
amdgpu_irq_put(adev, &adev->jpeg.inst->ras_poison_irq, 0);
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] drm/amdgpu: Fix vcn v4.0.3 poison irq call trace on sriov guest
2025-07-31 7:18 [PATCH 1/2] drm/amdgpu: Fix jpeg v4.0.3 poison irq call trace on sriov guest Xiang Liu
@ 2025-07-31 7:18 ` Xiang Liu
2025-08-04 1:56 ` Yang, Stanley
0 siblings, 1 reply; 3+ messages in thread
From: Xiang Liu @ 2025-07-31 7:18 UTC (permalink / raw)
To: amd-gfx; +Cc: Hawking.Zhang, Stanley.Yang, Xiang Liu
Sriov guest side doesn't init ras feature hence the poison irq shouldn't
be put during hw fini.
Fixes: d260e486d34d ("drm/amdgpu: Register aqua vanjaram vcn poison irq")
[25209.468816] Call Trace:
[25209.468817] <TASK>
[25209.468818] ? srso_alias_return_thunk+0x5/0x7f
[25209.468820] ? show_trace_log_lvl+0x28e/0x2ea
[25209.468822] ? show_trace_log_lvl+0x28e/0x2ea
[25209.468825] ? vcn_v4_0_3_hw_fini+0xaf/0xe0 [amdgpu]
[25209.468936] ? show_regs.part.0+0x23/0x29
[25209.468939] ? show_regs.cold+0x8/0xd
[25209.468940] ? amdgpu_irq_put+0x9e/0xc0 [amdgpu]
[25209.469038] ? __warn+0x8c/0x100
[25209.469040] ? amdgpu_irq_put+0x9e/0xc0 [amdgpu]
[25209.469135] ? report_bug+0xa4/0xd0
[25209.469138] ? handle_bug+0x39/0x90
[25209.469140] ? exc_invalid_op+0x19/0x70
[25209.469142] ? asm_exc_invalid_op+0x1b/0x20
[25209.469146] ? amdgpu_irq_put+0x9e/0xc0 [amdgpu]
[25209.469241] vcn_v4_0_3_hw_fini+0xaf/0xe0 [amdgpu]
[25209.469343] amdgpu_ip_block_hw_fini+0x34/0x61 [amdgpu]
[25209.469511] amdgpu_device_fini_hw+0x3b3/0x467 [amdgpu]
Signed-off-by: Xiang Liu <xiang.liu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c
index c51dc401226a..c6450ed65c12 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c
@@ -384,7 +384,7 @@ static int vcn_v4_0_3_hw_fini(struct amdgpu_ip_block *ip_block)
vinst->set_pg_state(vinst, AMD_PG_STATE_GATE);
}
- if (amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__VCN))
+ if (amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__VCN) && !amdgpu_sriov_vf(adev))
amdgpu_irq_put(adev, &adev->vcn.inst->ras_poison_irq, 0);
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 2/2] drm/amdgpu: Fix vcn v4.0.3 poison irq call trace on sriov guest
2025-07-31 7:18 ` [PATCH 2/2] drm/amdgpu: Fix vcn " Xiang Liu
@ 2025-08-04 1:56 ` Yang, Stanley
0 siblings, 0 replies; 3+ messages in thread
From: Yang, Stanley @ 2025-08-04 1:56 UTC (permalink / raw)
To: Liu, Xiang(Dean), amd-gfx@lists.freedesktop.org; +Cc: Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only]
The series is Reviewed-by: Stanley.Yang <Stanley.Yang@amd.com>
Regards,
Stanley
> -----Original Message-----
> From: Liu, Xiang(Dean) <Xiang.Liu@amd.com>
> Sent: Thursday, July 31, 2025 3:19 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Zhang, Hawking <Hawking.Zhang@amd.com>; Yang, Stanley
> <Stanley.Yang@amd.com>; Liu, Xiang(Dean) <Xiang.Liu@amd.com>
> Subject: [PATCH 2/2] drm/amdgpu: Fix vcn v4.0.3 poison irq call trace on sriov
> guest
>
> Sriov guest side doesn't init ras feature hence the poison irq shouldn't be put
> during hw fini.
>
> Fixes: d260e486d34d ("drm/amdgpu: Register aqua vanjaram vcn poison
> irq")
>
> [25209.468816] Call Trace:
> [25209.468817] <TASK>
> [25209.468818] ? srso_alias_return_thunk+0x5/0x7f [25209.468820] ?
> show_trace_log_lvl+0x28e/0x2ea [25209.468822] ?
> show_trace_log_lvl+0x28e/0x2ea [25209.468825] ?
> vcn_v4_0_3_hw_fini+0xaf/0xe0 [amdgpu] [25209.468936] ?
> show_regs.part.0+0x23/0x29 [25209.468939] ? show_regs.cold+0x8/0xd
> [25209.468940] ? amdgpu_irq_put+0x9e/0xc0 [amdgpu] [25209.469038] ?
> __warn+0x8c/0x100 [25209.469040] ? amdgpu_irq_put+0x9e/0xc0
> [amdgpu] [25209.469135] ? report_bug+0xa4/0xd0 [25209.469138] ?
> handle_bug+0x39/0x90 [25209.469140] ? exc_invalid_op+0x19/0x70
> [25209.469142] ? asm_exc_invalid_op+0x1b/0x20 [25209.469146] ?
> amdgpu_irq_put+0x9e/0xc0 [amdgpu] [25209.469241]
> vcn_v4_0_3_hw_fini+0xaf/0xe0 [amdgpu] [25209.469343]
> amdgpu_ip_block_hw_fini+0x34/0x61 [amdgpu] [25209.469511]
> amdgpu_device_fini_hw+0x3b3/0x467 [amdgpu]
>
> Signed-off-by: Xiang Liu <xiang.liu@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c
> b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c
> index c51dc401226a..c6450ed65c12 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c
> @@ -384,7 +384,7 @@ static int vcn_v4_0_3_hw_fini(struct
> amdgpu_ip_block *ip_block)
> vinst->set_pg_state(vinst, AMD_PG_STATE_GATE);
> }
>
> - if (amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__VCN))
> + if (amdgpu_ras_is_supported(adev, AMDGPU_RAS_BLOCK__VCN) &&
> +!amdgpu_sriov_vf(adev))
> amdgpu_irq_put(adev, &adev->vcn.inst->ras_poison_irq, 0);
>
> return 0;
> --
> 2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-04 1:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-31 7:18 [PATCH 1/2] drm/amdgpu: Fix jpeg v4.0.3 poison irq call trace on sriov guest Xiang Liu
2025-07-31 7:18 ` [PATCH 2/2] drm/amdgpu: Fix vcn " Xiang Liu
2025-08-04 1:56 ` Yang, Stanley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).