amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: amd-gfx@lists.freedesktop.org
Cc: "Timur Kristóf" <timur.kristof@gmail.com>
Subject: [PATCH 4/7] drm/amd/display: Fill display clock and vblank time in dce110_fill_display_configs
Date: Thu, 31 Jul 2025 11:43:49 +0200	[thread overview]
Message-ID: <20250731094352.29528-5-timur.kristof@gmail.com> (raw)
In-Reply-To: <20250731094352.29528-1-timur.kristof@gmail.com>

Also needed by DCE 6.
This way the code that gathers this info can be shared between
different DCE versions and doesn't have to be repeated.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
---
 .../drm/amd/display/dc/clk_mgr/dce100/dce_clk_mgr.c    |  2 --
 .../drm/amd/display/dc/clk_mgr/dce110/dce110_clk_mgr.c | 10 +++-------
 .../drm/amd/display/dc/clk_mgr/dce60/dce60_clk_mgr.c   |  2 --
 3 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dce100/dce_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dce100/dce_clk_mgr.c
index 69e9540f553b..17a8b46b0818 100644
--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dce100/dce_clk_mgr.c
+++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dce100/dce_clk_mgr.c
@@ -386,8 +386,6 @@ static void dce_pplib_apply_display_requirements(
 {
 	struct dm_pp_display_configuration *pp_display_cfg = &context->pp_display_cfg;
 
-	pp_display_cfg->avail_mclk_switch_time_us = dce110_get_min_vblank_time_us(context);
-
 	dce110_fill_display_configs(context, pp_display_cfg);
 
 	if (memcmp(&dc->current_state->pp_display_cfg, pp_display_cfg, sizeof(*pp_display_cfg)) !=  0)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dce110/dce110_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dce110/dce110_clk_mgr.c
index baeac8f1c04f..13cf415e38e5 100644
--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dce110/dce110_clk_mgr.c
+++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dce110/dce110_clk_mgr.c
@@ -124,6 +124,9 @@ void dce110_fill_display_configs(
 	int j;
 	int num_cfgs = 0;
 
+	pp_display_cfg->avail_mclk_switch_time_us = dce110_get_min_vblank_time_us(context);
+	pp_display_cfg->disp_clk_khz = dc->clk_mgr->clks.dispclk_khz;
+	pp_display_cfg->avail_mclk_switch_time_in_disp_active_us = 0;
 	pp_display_cfg->crtc_index = dc->res_pool->res_cap->num_timing_generator;
 
 	for (j = 0; j < context->stream_count; j++) {
@@ -243,13 +246,6 @@ void dce11_pplib_apply_display_requirements(
 	pp_display_cfg->min_engine_clock_deep_sleep_khz
 			= context->bw_ctx.bw.dce.sclk_deep_sleep_khz;
 
-	pp_display_cfg->avail_mclk_switch_time_us =
-						dce110_get_min_vblank_time_us(context);
-	/* TODO: dce11.2*/
-	pp_display_cfg->avail_mclk_switch_time_in_disp_active_us = 0;
-
-	pp_display_cfg->disp_clk_khz = dc->clk_mgr->clks.dispclk_khz;
-
 	dce110_fill_display_configs(context, pp_display_cfg);
 
 	if (memcmp(&dc->current_state->pp_display_cfg, pp_display_cfg, sizeof(*pp_display_cfg)) !=  0)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dce60/dce60_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dce60/dce60_clk_mgr.c
index cfd7309f2c6a..7044b437fe9d 100644
--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dce60/dce60_clk_mgr.c
+++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dce60/dce60_clk_mgr.c
@@ -109,8 +109,6 @@ static void dce60_pplib_apply_display_requirements(
 {
 	struct dm_pp_display_configuration *pp_display_cfg = &context->pp_display_cfg;
 
-	pp_display_cfg->avail_mclk_switch_time_us = dce110_get_min_vblank_time_us(context);
-
 	dce110_fill_display_configs(context, pp_display_cfg);
 
 	if (memcmp(&dc->current_state->pp_display_cfg, pp_display_cfg, sizeof(*pp_display_cfg)) !=  0)
-- 
2.50.1


  parent reply	other threads:[~2025-07-31  9:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31  9:43 [PATCH 0/7] DC: don't overclock DCE 6-10 and other fixes Timur Kristóf
2025-07-31  9:43 ` [PATCH 1/7] drm/amd/display: Don't overclock DCE 6 by 15% Timur Kristóf
2025-08-04 15:54   ` Alex Deucher
2025-08-12 22:11   ` Rodrigo Siqueira
2025-07-31  9:43 ` [PATCH 2/7] drm/amd/display: Adjust DCE 8-10 clock, don't overclock " Timur Kristóf
2025-08-04 15:56   ` Alex Deucher
2025-08-04 16:35     ` Timur Kristóf
2025-08-04 16:57       ` Alex Deucher
2025-08-12 22:18   ` Rodrigo Siqueira
2025-07-31  9:43 ` [PATCH 3/7] drm/amd/display: Find first CRTC and its line time in dce110_fill_display_configs Timur Kristóf
2025-08-04 15:57   ` Alex Deucher
2025-08-12 22:32   ` Rodrigo Siqueira
2025-07-31  9:43 ` Timur Kristóf [this message]
2025-08-04 15:58   ` [PATCH 4/7] drm/amd/display: Fill display clock and vblank " Alex Deucher
2025-08-12 22:39   ` Rodrigo Siqueira
2025-07-31  9:43 ` [PATCH 5/7] drm/amd/display: Don't warn when missing DCE encoder caps Timur Kristóf
2025-08-04 15:59   ` Alex Deucher
2025-08-12 22:47   ` Rodrigo Siqueira
2025-07-31  9:43 ` [PATCH 6/7] drm/amd/display: Don't print errors for nonexistent connectors Timur Kristóf
2025-08-04 15:59   ` Alex Deucher
2025-08-12 22:59   ` Rodrigo Siqueira
2025-07-31  9:43 ` [PATCH 7/7] drm/amd/display: Fix fractional fb divider in set_pixel_clock_v3 Timur Kristóf
2025-08-04 15:59   ` Alex Deucher
2025-08-12 23:46   ` Rodrigo Siqueira
2025-08-09 20:25 ` [PATCH 0/7] DC: don't overclock DCE 6-10 and other fixes Timur Kristóf
2025-08-18  3:01 ` Alex Hung
2025-08-18 14:44   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250731094352.29528-5-timur.kristof@gmail.com \
    --to=timur.kristof@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).