From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4111CA0EE4 for ; Wed, 13 Aug 2025 12:00:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DAD010E700; Wed, 13 Aug 2025 12:00:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rOg9wUHI"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id CEA5C10E075; Wed, 13 Aug 2025 12:00:49 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 5AE853D5; Wed, 13 Aug 2025 13:59:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1755086394; bh=Z0Wd8Ul5IDIWW8lxpyrGHrFqOEXZiZV2mDebB4u5iE0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rOg9wUHIbPEf8oD+S/HQgLiT+Ai8eRs5plN7KfY2BBIY0wfkrzEz3ag5dCeEf2/i3 RF6xNPKTXbUbsF/QoBV6L8GEne60I13yX3l803DuYWioasayslSxglfN+k9p0fzG/W FevitONufT6X9SIEpJrGUMhPwvU+lq60Z0MZc1tI= Date: Wed, 13 Aug 2025 15:00:29 +0300 From: Laurent Pinchart To: "Kandpal, Suraj" Cc: Dmitry Baryshkov , "kernel-list@raspberrypi.com" , "amd-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "freedreno@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "intel-xe@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "Nautiyal, Ankit K" , "Murthy, Arun R" , "Shankar, Uma" , "Nikula, Jani" , "harry.wentland@amd.com" , "siqueira@igalia.com" , "alexander.deucher@amd.com" , "christian.koenig@amd.com" , "airlied@gmail.com" , "simona@ffwll.ch" , "liviu.dudau@arm.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "robin.clark@oss.qualcomm.com" , "abhinav.kumar@linux.dev" , "tzimmermann@suse.de" , "jessica.zhang@oss.qualcomm.com" , "sean@poorly.run" , "marijn.suijten@somainline.org" , "mcanal@igalia.com" , "dave.stevenson@raspberrypi.com" , "tomi.valkeinen+renesas@ideasonboard.com" , "kieran.bingham+renesas@ideasonboard.com" , "louis.chauvet@bootlin.com" Subject: Re: [RFC PATCH 1/8] drm: writeback: Refactor drm_writeback_connector structure Message-ID: <20250813120029.GE20174@pendragon.ideasonboard.com> References: <20250811092707.3986802-1-suraj.kandpal@intel.com> <20250811092707.3986802-2-suraj.kandpal@intel.com> <20250811094429.GE21313@pendragon.ideasonboard.com> <20250811111546.GA30760@pendragon.ideasonboard.com> <2ah3pau7p7brgw7huoxznvej3djct76vgfwtc72n6uub7sjojd@zzaebjdcpdwf> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, Aug 13, 2025 at 10:04:22AM +0000, Kandpal, Suraj wrote: > > > > }; > > > > > > I still don't like that. This really doesn't belong here. If anything, > > > the drm_connector for writeback belongs to drm_crtc. > > > > Why? We already have generic HDMI field inside drm_connector. I am really > > hoping to be able to land DP parts next to it. In theory we can have a DVI- > > specific entry there (e.g. with the subconnector type). > > The idea is not to limit how the drivers subclass those structures. > > > > I don't see a good case why WB should deviate from that design. > > > > > If the issue is that some drivers need a custom drm_connector > > > subclass, then I'd rather turn the connector field of > > > drm_writeback_connector into a pointer. > > > > Having a pointer requires additional ops in order to get drm_connector from > > WB code and vice versa. Having drm_connector_wb inside drm_connector > > saves us from those ops (which don't manifest for any other kind of structure). > > Nor will it take any more space since union will reuse space already taken up by > > HDMI part. > > Seems like this thread has died. We need to get a conclusion on the design. > Laurent do you have any issue with the design given Dmitry's explanation as to why this > Design is good for drm_writeback_connector. I'm busy, I'll try to reply in the next few days. > > > > I plan to add drm_connector_dp in a similar way, covering DP needs > > > > (currently WIP). -- Regards, Laurent Pinchart