From: Philip Yang <Philip.Yang@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <Felix.Kuehling@amd.com>, Philip Yang <Philip.Yang@amd.com>,
"Felix Kuehling" <felix.kuehling@amd.com>
Subject: [PATCH v2 2/2] drm/amdkfd: Stop user queues when process mm released
Date: Wed, 15 Oct 2025 16:11:33 -0400 [thread overview]
Message-ID: <20251015201134.2540-2-Philip.Yang@amd.com> (raw)
In-Reply-To: <20251015201134.2540-1-Philip.Yang@amd.com>
In mmu notifier release callback, stop user queues to be safe because
the SVM memory is going to unmap from CPU.
Suggested-by: Felix Kuehling <felix.kuehling@amd.com>
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_process.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
index 0341f570f3d1..e2a0ae0394b8 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
@@ -1221,11 +1221,16 @@ static void kfd_process_free_notifier(struct mmu_notifier *mn)
static void kfd_process_notifier_release_internal(struct kfd_process *p)
{
- int i;
+ int i, r;
cancel_delayed_work_sync(&p->eviction_work);
cancel_delayed_work_sync(&p->restore_work);
+ WARN(debug_evictions, "Evicting pid %d", p->lead_thread->pid);
+ r = kfd_process_evict_queues(p, KFD_QUEUE_EVICTION_TRIGGER_SVM);
+ if (r)
+ pr_debug("failed %d to quiesce KFD queues\n", r);
+
for (i = 0; i < p->n_pdds; i++) {
struct kfd_process_device *pdd = p->pdds[i];
--
2.49.0
next prev parent reply other threads:[~2025-10-15 20:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 20:11 [PATCH v2 1/2] drm/amdkfd: Fix false positive queue buffer free warning Philip Yang
2025-10-15 20:11 ` Philip Yang [this message]
2025-10-15 20:40 ` [PATCH v2 2/2] drm/amdkfd: Stop user queues when process mm released Chen, Xiaogang
2025-10-15 21:33 ` Philip Yang
2025-10-16 14:46 ` Chen, Xiaogang
2025-10-17 22:34 ` Felix Kuehling
2025-10-17 22:43 ` Felix Kuehling
2025-10-20 14:26 ` Philip Yang
2025-10-15 21:01 ` [PATCH v2 1/2] drm/amdkfd: Fix false positive queue buffer free warning Chen, Xiaogang
2025-10-15 21:45 ` Philip Yang
2025-10-15 22:46 ` Chen, Xiaogang
2025-10-16 18:01 ` Philip Yang
2025-10-17 22:39 ` Felix Kuehling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015201134.2540-2-Philip.Yang@amd.com \
--to=philip.yang@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox