From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Christian König" <christian.koenig@amd.com>,
"Michał Winiarski" <michal.winiarski@intel.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
amd-gfx@lists.freedesktop.org, "David Airlie" <airlied@gmail.com>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Michael J . Ruhl" <mjruhl@habana.ai>,
"Andi Shyti" <andi.shyti@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v3 00/11] PCI: Resizable BAR improvements
Date: Wed, 22 Oct 2025 16:33:20 +0300 [thread overview]
Message-ID: <20251022133331.4357-1-ilpo.jarvinen@linux.intel.com> (raw)
pci.c has been used as catch everything that doesn't fits elsewhere
within PCI core and thus resizable BAR code has been placed there as
well. Move Resizable BAR related code to a newly introduced rebar.c to
reduce size of pci.c. After move, there are no pci_rebar_*() calls from
pci.c indicating this is indeed well-defined subset of PCI core.
Endpoint drivers perform Resizable BAR related operations which could
well be performed by PCI core to simplify driver-side code. This
series adds a few new API functions to that effect and converts the
drivers to use the new APIs (in separate patches).
While at it, also convert BAR sizes bitmask to u64 as PCIe spec already
specifies more sizes than what will fit u32 to make the API typing more
future-proof. The extra sizes beyond 128TB are not added at this point.
Some parts of this are to be used by the resizable BAR changes into the
resource fitting/assingment logic but these seem to stand on their own
so sending these out now to reduce the size of the other patch series.
v3:
- Rebased to solve minor conflicts
v2: https://lore.kernel.org/linux-pci/20250915091358.9203-1-ilpo.jarvinen@linux.intel.com/
- Kerneldoc:
- Improve formatting of errno returns
- Open "ctrl" -> "control"
- Removed mislead "bit" words (when referring to BAR size)
- Rewrote pci_rebar_get_possible_sizes() kernel doc to not claim the
returned bitmask is defined in PCIe spec as the capability bits now
span across two registers in the spec and are not continuous (we
don't support the second block of bits yet, but this API is expected
to return the bits without the hole so it will not be matching with
the spec layout).
- Dropped superfluous zero check from pci_rebar_size_supported()
- Small improvement to changelog of patch 7
Ilpo Järvinen (11):
PCI: Move Resizable BAR code into rebar.c
PCI: Cleanup pci_rebar_bytes_to_size() and move into rebar.c
PCI: Move pci_rebar_size_to_bytes() and export it
PCI: Improve Resizable BAR functions kernel doc
PCI: Add pci_rebar_size_supported() helper
drm/i915/gt: Use pci_rebar_size_supported()
drm/xe/vram: Use PCI rebar helpers in resize_vram_bar()
PCI: Add pci_rebar_get_max_size()
drm/xe/vram: Use pci_rebar_get_max_size()
drm/amdgpu: Use pci_rebar_get_max_size()
PCI: Convert BAR sizes bitmasks to u64
Documentation/driver-api/pci/pci.rst | 3 +
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 +-
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 10 +-
drivers/gpu/drm/xe/xe_vram.c | 32 +-
drivers/pci/Makefile | 2 +-
drivers/pci/iov.c | 9 +-
drivers/pci/pci-sysfs.c | 2 +-
drivers/pci/pci.c | 145 ---------
drivers/pci/pci.h | 5 +-
drivers/pci/rebar.c | 314 ++++++++++++++++++++
drivers/pci/setup-res.c | 78 -----
include/linux/pci.h | 15 +-
12 files changed, 350 insertions(+), 273 deletions(-)
create mode 100644 drivers/pci/rebar.c
base-commit: 2f2c7254931f41b5736e3ba12aaa9ac1bbeeeb92
--
2.39.5
next reply other threads:[~2025-10-23 7:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 13:33 Ilpo Järvinen [this message]
2025-10-22 13:33 ` [PATCH v3 01/11] PCI: Move Resizable BAR code into rebar.c Ilpo Järvinen
2025-10-22 13:33 ` [PATCH v3 02/11] PCI: Cleanup pci_rebar_bytes_to_size() and move " Ilpo Järvinen
2025-10-22 13:33 ` [PATCH v3 03/11] PCI: Move pci_rebar_size_to_bytes() and export it Ilpo Järvinen
2025-10-22 13:33 ` [PATCH v3 04/11] PCI: Improve Resizable BAR functions kernel doc Ilpo Järvinen
2025-10-22 13:33 ` [PATCH v3 05/11] PCI: Add pci_rebar_size_supported() helper Ilpo Järvinen
2025-10-22 13:33 ` [PATCH v3 06/11] drm/i915/gt: Use pci_rebar_size_supported() Ilpo Järvinen
2025-10-22 13:33 ` [PATCH v3 07/11] drm/xe/vram: Use PCI rebar helpers in resize_vram_bar() Ilpo Järvinen
2025-10-22 13:33 ` [PATCH v3 08/11] PCI: Add pci_rebar_get_max_size() Ilpo Järvinen
2025-10-22 13:33 ` [PATCH v3 09/11] drm/xe/vram: Use pci_rebar_get_max_size() Ilpo Järvinen
2025-10-22 13:33 ` [PATCH v3 10/11] drm/amdgpu: " Ilpo Järvinen
2025-10-22 13:33 ` [PATCH v3 11/11] PCI: Convert BAR sizes bitmasks to u64 Ilpo Järvinen
2025-10-23 21:29 ` [PATCH v3 00/11] PCI: Resizable BAR improvements Bjorn Helgaas
2025-10-23 22:02 ` Lucas De Marchi
2025-10-23 22:13 ` Bjorn Helgaas
2025-10-24 10:39 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022133331.4357-1-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andi.shyti@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=michal.winiarski@intel.com \
--cc=mjruhl@habana.ai \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox