* [PATCH] drm/fb-helper: Allocate and release fb_info in single place
@ 2025-10-26 17:18 Thomas Zimmermann
2025-10-26 23:41 ` kernel test robot
2025-10-27 0:46 ` kernel test robot
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2025-10-26 17:18 UTC (permalink / raw)
To: javierm, airlied, simona, linux, maarten.lankhorst, mripard,
inki.dae, sw0312.kim, kyungmin.park, patrik.r.jakobsson,
jani.nikula, rodrigo.vivi, robin.clark, lumag, abhinav.kumar,
sean, marijn.suijten, tomi.valkeinen, alexander.deucher,
christian.koenig, thierry.reding, mperttunen, jonathanh
Cc: dri-devel, intel-gfx, intel-xe, linux-arm-msm, freedreno, amd-gfx,
linux-tegra, Thomas Zimmermann
Move the calls to drm_fb_helper_alloc_info() from drivers into a
single place in fbdev helpers. Allocates struct fb_info for a new
framebuffer device. Then call drm_fb_helper_single_fb_probe() to
create an fbdev screen buffer. Also release the instance on errors
by calling drm_fb_helper_release_info().
Simplifies the code and fixes the error cleanup for some of the
drivers.
Regular release of the struct fb_info instance still happens in
drm_fb_helper_fini() as before.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/armada/armada_fbdev.c | 8 +----
drivers/gpu/drm/drm_fb_helper.c | 39 +++++++---------------
drivers/gpu/drm/drm_fbdev_dma.c | 12 ++-----
drivers/gpu/drm/drm_fbdev_shmem.c | 12 ++-----
drivers/gpu/drm/drm_fbdev_ttm.c | 10 +-----
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 9 +----
drivers/gpu/drm/gma500/fbdev.c | 8 +----
drivers/gpu/drm/i915/display/intel_fbdev.c | 9 +----
drivers/gpu/drm/msm/msm_fbdev.c | 9 +----
drivers/gpu/drm/omapdrm/omap_fbdev.c | 9 +----
drivers/gpu/drm/radeon/radeon_fbdev.c | 9 +----
drivers/gpu/drm/tegra/fbdev.c | 9 +----
include/drm/drm_fb_helper.h | 12 -------
13 files changed, 25 insertions(+), 130 deletions(-)
diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
index 22e2081bfa04..c8778a6d8a8d 100644
--- a/drivers/gpu/drm/armada/armada_fbdev.c
+++ b/drivers/gpu/drm/armada/armada_fbdev.c
@@ -43,10 +43,10 @@ int armada_fbdev_driver_fbdev_probe(struct drm_fb_helper *fbh,
struct drm_fb_helper_surface_size *sizes)
{
struct drm_device *dev = fbh->dev;
+ struct fb_info *info = fbh->info;
struct drm_mode_fb_cmd2 mode;
struct armada_framebuffer *dfb;
struct armada_gem_object *obj;
- struct fb_info *info;
int size, ret;
void *ptr;
@@ -90,12 +90,6 @@ int armada_fbdev_driver_fbdev_probe(struct drm_fb_helper *fbh,
if (IS_ERR(dfb))
return PTR_ERR(dfb);
- info = drm_fb_helper_alloc_info(fbh);
- if (IS_ERR(info)) {
- ret = PTR_ERR(info);
- goto err_fballoc;
- }
-
info->fbops = &armada_fb_ops;
info->fix.smem_start = obj->phys_addr;
info->fix.smem_len = obj->obj.size;
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 53e9dc0543de..dd80f5c5feec 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -495,20 +495,7 @@ int drm_fb_helper_init(struct drm_device *dev,
}
EXPORT_SYMBOL(drm_fb_helper_init);
-/**
- * drm_fb_helper_alloc_info - allocate fb_info and some of its members
- * @fb_helper: driver-allocated fbdev helper
- *
- * A helper to alloc fb_info and the member cmap. Called by the driver
- * within the struct &drm_driver.fbdev_probe callback function. Drivers do
- * not need to release the allocated fb_info structure themselves, this is
- * automatically done when calling drm_fb_helper_fini().
- *
- * RETURNS:
- * fb_info pointer if things went okay, pointer containing error code
- * otherwise
- */
-struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper)
+static struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper)
{
struct device *dev = fb_helper->dev->dev;
struct fb_info *info;
@@ -535,17 +522,8 @@ struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper)
framebuffer_release(info);
return ERR_PTR(ret);
}
-EXPORT_SYMBOL(drm_fb_helper_alloc_info);
-/**
- * drm_fb_helper_release_info - release fb_info and its members
- * @fb_helper: driver-allocated fbdev helper
- *
- * A helper to release fb_info and the member cmap. Drivers do not
- * need to release the allocated fb_info structure themselves, this is
- * automatically done when calling drm_fb_helper_fini().
- */
-void drm_fb_helper_release_info(struct drm_fb_helper *fb_helper)
+static void drm_fb_helper_release_info(struct drm_fb_helper *fb_helper)
{
struct fb_info *info = fb_helper->info;
@@ -558,7 +536,6 @@ void drm_fb_helper_release_info(struct drm_fb_helper *fb_helper)
fb_dealloc_cmap(&info->cmap);
framebuffer_release(info);
}
-EXPORT_SYMBOL(drm_fb_helper_release_info);
/**
* drm_fb_helper_unregister_info - unregister fb_info framebuffer device
@@ -1809,6 +1786,11 @@ __drm_fb_helper_initial_config_and_unlock(struct drm_fb_helper *fb_helper)
height = dev->mode_config.max_height;
drm_client_modeset_probe(&fb_helper->client, width, height);
+
+ info = drm_fb_helper_alloc_info(fb_helper);
+ if (IS_ERR(info))
+ return PTR_ERR(info);
+
ret = drm_fb_helper_single_fb_probe(fb_helper);
if (ret < 0) {
if (ret == -EAGAIN) {
@@ -1817,13 +1799,12 @@ __drm_fb_helper_initial_config_and_unlock(struct drm_fb_helper *fb_helper)
}
mutex_unlock(&fb_helper->lock);
- return ret;
+ goto err_drm_fb_helper_release_info;
}
drm_setup_crtcs_fb(fb_helper);
fb_helper->deferred_setup = false;
- info = fb_helper->info;
info->var.pixclock = 0;
/* Need to drop locks to avoid recursive deadlock in
@@ -1846,6 +1827,10 @@ __drm_fb_helper_initial_config_and_unlock(struct drm_fb_helper *fb_helper)
mutex_unlock(&kernel_fb_helper_lock);
return 0;
+
+err_drm_fb_helper_release_info:
+ drm_fb_helper_release_info(fb_helper);
+ return ret;
}
/**
diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
index c6196293e424..442d964039b7 100644
--- a/drivers/gpu/drm/drm_fbdev_dma.c
+++ b/drivers/gpu/drm/drm_fbdev_dma.c
@@ -268,9 +268,9 @@ int drm_fbdev_dma_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
{
struct drm_client_dev *client = &fb_helper->client;
struct drm_device *dev = fb_helper->dev;
+ struct fb_info *info = fb_helper->info;
struct drm_client_buffer *buffer;
struct drm_framebuffer *fb;
- struct fb_info *info;
u32 format;
struct iosys_map map;
int ret;
@@ -300,12 +300,6 @@ int drm_fbdev_dma_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
fb_helper->buffer = buffer;
fb_helper->fb = fb;
- info = drm_fb_helper_alloc_info(fb_helper);
- if (IS_ERR(info)) {
- ret = PTR_ERR(info);
- goto err_drm_client_buffer_vunmap;
- }
-
drm_fb_helper_fill_info(info, fb_helper, sizes);
if (fb->funcs->dirty)
@@ -313,12 +307,10 @@ int drm_fbdev_dma_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
else
ret = drm_fbdev_dma_driver_fbdev_probe_tail(fb_helper, sizes);
if (ret)
- goto err_drm_fb_helper_release_info;
+ goto err_drm_client_buffer_vunmap;
return 0;
-err_drm_fb_helper_release_info:
- drm_fb_helper_release_info(fb_helper);
err_drm_client_buffer_vunmap:
fb_helper->fb = NULL;
fb_helper->buffer = NULL;
diff --git a/drivers/gpu/drm/drm_fbdev_shmem.c b/drivers/gpu/drm/drm_fbdev_shmem.c
index 51573058df6f..2190e2230b83 100644
--- a/drivers/gpu/drm/drm_fbdev_shmem.c
+++ b/drivers/gpu/drm/drm_fbdev_shmem.c
@@ -134,10 +134,10 @@ int drm_fbdev_shmem_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
{
struct drm_client_dev *client = &fb_helper->client;
struct drm_device *dev = fb_helper->dev;
+ struct fb_info *info = fb_helper->info;
struct drm_client_buffer *buffer;
struct drm_gem_shmem_object *shmem;
struct drm_framebuffer *fb;
- struct fb_info *info;
u32 format;
struct iosys_map map;
int ret;
@@ -167,12 +167,6 @@ int drm_fbdev_shmem_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
fb_helper->buffer = buffer;
fb_helper->fb = fb;
- info = drm_fb_helper_alloc_info(fb_helper);
- if (IS_ERR(info)) {
- ret = PTR_ERR(info);
- goto err_drm_client_buffer_vunmap;
- }
-
drm_fb_helper_fill_info(info, fb_helper, sizes);
info->fbops = &drm_fbdev_shmem_fb_ops;
@@ -193,12 +187,10 @@ int drm_fbdev_shmem_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
info->fbdefio = &fb_helper->fbdefio;
ret = fb_deferred_io_init(info);
if (ret)
- goto err_drm_fb_helper_release_info;
+ goto err_drm_client_buffer_vunmap;
return 0;
-err_drm_fb_helper_release_info:
- drm_fb_helper_release_info(fb_helper);
err_drm_client_buffer_vunmap:
fb_helper->fb = NULL;
fb_helper->buffer = NULL;
diff --git a/drivers/gpu/drm/drm_fbdev_ttm.c b/drivers/gpu/drm/drm_fbdev_ttm.c
index ccf460fbc1f0..9a7fa59e2bc7 100644
--- a/drivers/gpu/drm/drm_fbdev_ttm.c
+++ b/drivers/gpu/drm/drm_fbdev_ttm.c
@@ -203,12 +203,6 @@ int drm_fbdev_ttm_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
goto err_drm_client_framebuffer_delete;
}
- info = drm_fb_helper_alloc_info(fb_helper);
- if (IS_ERR(info)) {
- ret = PTR_ERR(info);
- goto err_vfree;
- }
-
drm_fb_helper_fill_info(info, fb_helper, sizes);
info->fbops = &drm_fbdev_ttm_fb_ops;
@@ -225,12 +219,10 @@ int drm_fbdev_ttm_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
info->fbdefio = &fb_helper->fbdefio;
ret = fb_deferred_io_init(info);
if (ret)
- goto err_drm_fb_helper_release_info;
+ goto err_vfree;
return 0;
-err_drm_fb_helper_release_info:
- drm_fb_helper_release_info(fb_helper);
err_vfree:
vfree(screen_buffer);
err_drm_client_framebuffer_delete:
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index a3bd21a827ad..539ce0a87886 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -57,18 +57,11 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper,
struct drm_fb_helper_surface_size *sizes,
struct exynos_drm_gem *exynos_gem)
{
- struct fb_info *fbi;
+ struct fb_info *fbi = helper->info;
struct drm_framebuffer *fb = helper->fb;
unsigned int size = fb->width * fb->height * fb->format->cpp[0];
unsigned long offset;
- fbi = drm_fb_helper_alloc_info(helper);
- if (IS_ERR(fbi)) {
- DRM_DEV_ERROR(to_dma_dev(helper->dev),
- "failed to allocate fb info.\n");
- return PTR_ERR(fbi);
- }
-
fbi->fbops = &exynos_drm_fb_ops;
drm_fb_helper_fill_info(fbi, helper, sizes);
diff --git a/drivers/gpu/drm/gma500/fbdev.c b/drivers/gpu/drm/gma500/fbdev.c
index bc92fa24a1e2..c92e2068c2c2 100644
--- a/drivers/gpu/drm/gma500/fbdev.c
+++ b/drivers/gpu/drm/gma500/fbdev.c
@@ -108,7 +108,7 @@ int psb_fbdev_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
struct drm_device *dev = fb_helper->dev;
struct drm_psb_private *dev_priv = to_drm_psb_private(dev);
struct pci_dev *pdev = to_pci_dev(dev->dev);
- struct fb_info *info;
+ struct fb_info *info = fb_helper->info;
struct drm_framebuffer *fb;
struct drm_mode_fb_cmd2 mode_cmd = { };
int size;
@@ -167,12 +167,6 @@ int psb_fbdev_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
fb_helper->funcs = &psb_fbdev_fb_helper_funcs;
fb_helper->fb = fb;
- info = drm_fb_helper_alloc_info(fb_helper);
- if (IS_ERR(info)) {
- ret = PTR_ERR(info);
- goto err_drm_framebuffer_unregister_private;
- }
-
info->fbops = &psb_fbdev_fb_ops;
/* Accessed stolen memory directly */
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index e5449c41cfa1..9cd03e2adeb2 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -267,8 +267,8 @@ int intel_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,
struct intel_display *display = to_intel_display(helper->dev);
struct intel_fbdev *ifbdev = to_intel_fbdev(helper);
struct intel_framebuffer *fb = ifbdev->fb;
+ struct fb_info *info = helper->info;
struct ref_tracker *wakeref;
- struct fb_info *info;
struct i915_vma *vma;
unsigned long flags = 0;
bool prealloc = false;
@@ -318,13 +318,6 @@ int intel_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,
goto out_unlock;
}
- info = drm_fb_helper_alloc_info(helper);
- if (IS_ERR(info)) {
- drm_err(display->drm, "Failed to allocate fb_info (%pe)\n", info);
- ret = PTR_ERR(info);
- goto out_unpin;
- }
-
helper->funcs = &intel_fb_helper_funcs;
helper->fb = &fb->base;
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index aad6fb77f0de..fd19995b12b5 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -91,9 +91,9 @@ int msm_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,
{
struct drm_device *dev = helper->dev;
struct msm_drm_private *priv = dev->dev_private;
+ struct fb_info *fbi = helper->info;
struct drm_framebuffer *fb = NULL;
struct drm_gem_object *bo;
- struct fb_info *fbi = NULL;
uint64_t paddr;
uint32_t format;
int ret, pitch;
@@ -126,13 +126,6 @@ int msm_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,
goto fail;
}
- fbi = drm_fb_helper_alloc_info(helper);
- if (IS_ERR(fbi)) {
- DRM_DEV_ERROR(dev->dev, "failed to allocate fb info\n");
- ret = PTR_ERR(fbi);
- goto fail;
- }
-
DBG("fbi=%p, dev=%p", fbi, dev);
helper->funcs = &msm_fbdev_helper_funcs;
diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index b5df2923d2a6..c4671ab87f9c 100644
--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
+++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
@@ -153,9 +153,9 @@ int omap_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,
struct drm_device *dev = helper->dev;
struct omap_drm_private *priv = dev->dev_private;
struct omap_fbdev *fbdev = priv->fbdev;
+ struct fb_info *fbi = helper->info;
struct drm_framebuffer *fb = NULL;
union omap_gem_size gsize;
- struct fb_info *fbi = NULL;
struct drm_mode_fb_cmd2 mode_cmd = {0};
struct drm_gem_object *bo;
dma_addr_t dma_addr;
@@ -224,13 +224,6 @@ int omap_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,
goto fail;
}
- fbi = drm_fb_helper_alloc_info(helper);
- if (IS_ERR(fbi)) {
- dev_err(dev->dev, "failed to allocate fb info\n");
- ret = PTR_ERR(fbi);
- goto fail;
- }
-
DBG("fbi=%p, dev=%p", fbi, dev);
helper->funcs = &omap_fbdev_helper_funcs;
diff --git a/drivers/gpu/drm/radeon/radeon_fbdev.c b/drivers/gpu/drm/radeon/radeon_fbdev.c
index 4df6c9167bf0..0c52efdc29d9 100644
--- a/drivers/gpu/drm/radeon/radeon_fbdev.c
+++ b/drivers/gpu/drm/radeon/radeon_fbdev.c
@@ -204,7 +204,7 @@ int radeon_fbdev_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
struct radeon_device *rdev = fb_helper->dev->dev_private;
const struct drm_format_info *format_info;
struct drm_mode_fb_cmd2 mode_cmd = { };
- struct fb_info *info;
+ struct fb_info *info = fb_helper->info;
struct drm_gem_object *gobj;
struct radeon_bo *rbo;
struct drm_framebuffer *fb;
@@ -245,13 +245,6 @@ int radeon_fbdev_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
fb_helper->funcs = &radeon_fbdev_fb_helper_funcs;
fb_helper->fb = fb;
- /* okay we have an object now allocate the framebuffer */
- info = drm_fb_helper_alloc_info(fb_helper);
- if (IS_ERR(info)) {
- ret = PTR_ERR(info);
- goto err_drm_framebuffer_unregister_private;
- }
-
info->fbops = &radeon_fbdev_fb_ops;
/* radeon resume is fragile and needs a vt switch to help it along */
diff --git a/drivers/gpu/drm/tegra/fbdev.c b/drivers/gpu/drm/tegra/fbdev.c
index 91aece6f34e0..8f40882aa76e 100644
--- a/drivers/gpu/drm/tegra/fbdev.c
+++ b/drivers/gpu/drm/tegra/fbdev.c
@@ -73,10 +73,10 @@ int tegra_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,
struct tegra_drm *tegra = helper->dev->dev_private;
struct drm_device *drm = helper->dev;
struct drm_mode_fb_cmd2 cmd = { 0 };
+ struct fb_info *info = helper->info;
unsigned int bytes_per_pixel;
struct drm_framebuffer *fb;
unsigned long offset;
- struct fb_info *info;
struct tegra_bo *bo;
size_t size;
int err;
@@ -97,13 +97,6 @@ int tegra_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,
if (IS_ERR(bo))
return PTR_ERR(bo);
- info = drm_fb_helper_alloc_info(helper);
- if (IS_ERR(info)) {
- dev_err(drm->dev, "failed to allocate framebuffer info\n");
- drm_gem_object_put(&bo->gem);
- return PTR_ERR(info);
- }
-
fb = tegra_fb_alloc(drm,
drm_get_format_info(drm, cmd.pixel_format, cmd.modifier[0]),
&cmd, &bo, 1);
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index c1d38d54a112..2faf8aaf98dc 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -256,8 +256,6 @@ int drm_fb_helper_check_var(struct fb_var_screeninfo *var,
int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper);
-struct fb_info *drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper);
-void drm_fb_helper_release_info(struct drm_fb_helper *fb_helper);
void drm_fb_helper_unregister_info(struct drm_fb_helper *fb_helper);
void drm_fb_helper_fill_info(struct fb_info *info,
struct drm_fb_helper *fb_helper,
@@ -340,16 +338,6 @@ drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper)
return 0;
}
-static inline struct fb_info *
-drm_fb_helper_alloc_info(struct drm_fb_helper *fb_helper)
-{
- return NULL;
-}
-
-static inline void drm_fb_helper_release_info(struct drm_fb_helper *fb_helper)
-{
-}
-
static inline void drm_fb_helper_unregister_info(struct drm_fb_helper *fb_helper)
{
}
--
2.51.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/fb-helper: Allocate and release fb_info in single place
2025-10-26 17:18 [PATCH] drm/fb-helper: Allocate and release fb_info in single place Thomas Zimmermann
@ 2025-10-26 23:41 ` kernel test robot
2025-10-27 0:46 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-10-26 23:41 UTC (permalink / raw)
To: Thomas Zimmermann, javierm, airlied, simona, linux,
maarten.lankhorst, mripard, inki.dae, sw0312.kim, kyungmin.park,
patrik.r.jakobsson, jani.nikula, rodrigo.vivi, robin.clark, lumag,
abhinav.kumar, sean, marijn.suijten, tomi.valkeinen,
alexander.deucher, christian.koenig, thierry.reding, mperttunen,
jonathanh
Cc: oe-kbuild-all, dri-devel, intel-gfx, intel-xe, linux-arm-msm,
freedreno, amd-gfx, linux-tegra
Hi Thomas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-exynos/exynos-drm-next]
[also build test WARNING on drm-i915/for-linux-next drm-i915/for-linux-next-fixes tegra/for-next linus/master v6.18-rc2 next-20251024]
[cannot apply to rmk-arm/drm-armada-devel rmk-arm/drm-armada-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-fb-helper-Allocate-and-release-fb_info-in-single-place/20251027-014054
base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
patch link: https://lore.kernel.org/r/20251026173944.219373-1-tzimmermann%40suse.de
patch subject: [PATCH] drm/fb-helper: Allocate and release fb_info in single place
config: x86_64-buildonly-randconfig-003-20251027 (https://download.01.org/0day-ci/archive/20251027/202510270728.dixqTvyI-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251027/202510270728.dixqTvyI-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510270728.dixqTvyI-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/gpu/drm/radeon/radeon_fbdev.c: In function 'radeon_fbdev_driver_fbdev_probe':
>> drivers/gpu/drm/radeon/radeon_fbdev.c:275:1: warning: label 'err_drm_framebuffer_unregister_private' defined but not used [-Wunused-label]
275 | err_drm_framebuffer_unregister_private:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
drivers/gpu/drm/gma500/fbdev.c: In function 'psb_fbdev_driver_fbdev_probe':
>> drivers/gpu/drm/gma500/fbdev.c:239:1: warning: label 'err_drm_framebuffer_unregister_private' defined but not used [-Wunused-label]
239 | err_drm_framebuffer_unregister_private:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/err_drm_framebuffer_unregister_private +275 drivers/gpu/drm/radeon/radeon_fbdev.c
041f5c416217e37 drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 202
41d48e557e01582 drivers/gpu/drm/radeon/radeon_fbdev.c Thomas Zimmermann 2024-09-24 203 int radeon_fbdev_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 204 struct drm_fb_helper_surface_size *sizes)
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 205 {
041f5c416217e37 drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 206 struct radeon_device *rdev = fb_helper->dev->dev_private;
c0a8e4443d768e5 drivers/gpu/drm/radeon/radeon_fbdev.c Imre Deak 2025-08-05 207 const struct drm_format_info *format_info;
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 208 struct drm_mode_fb_cmd2 mode_cmd = { };
da786b90bcbd1c5 drivers/gpu/drm/radeon/radeon_fbdev.c Thomas Zimmermann 2025-10-26 209 struct fb_info *info = fb_helper->info;
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 210 struct drm_gem_object *gobj;
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 211 struct radeon_bo *rbo;
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 212 struct drm_framebuffer *fb;
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 213 int ret;
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 214 unsigned long tmp;
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 215
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 216 mode_cmd.width = sizes->surface_width;
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 217 mode_cmd.height = sizes->surface_height;
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 218
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 219 /* avivo can't scanout real 24bpp */
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 220 if ((sizes->surface_bpp == 24) && ASIC_IS_AVIVO(rdev))
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 221 sizes->surface_bpp = 32;
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 222
308e5bcbdb10452 drivers/gpu/drm/radeon/radeon_fb.c Jesse Barnes 2011-11-14 223 mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp,
308e5bcbdb10452 drivers/gpu/drm/radeon/radeon_fb.c Jesse Barnes 2011-11-14 224 sizes->surface_depth);
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 225
c0a8e4443d768e5 drivers/gpu/drm/radeon/radeon_fbdev.c Imre Deak 2025-08-05 226 format_info = drm_get_format_info(rdev_to_drm(rdev), mode_cmd.pixel_format,
c0a8e4443d768e5 drivers/gpu/drm/radeon/radeon_fbdev.c Imre Deak 2025-08-05 227 mode_cmd.modifier[0]);
c0a8e4443d768e5 drivers/gpu/drm/radeon/radeon_fbdev.c Imre Deak 2025-08-05 228 ret = radeon_fbdev_create_pinned_object(fb_helper, format_info, &mode_cmd, &gobj);
aaefcd4284a5399 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2012-03-06 229 if (ret) {
aaefcd4284a5399 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2012-03-06 230 DRM_ERROR("failed to create fbcon object %d\n", ret);
aaefcd4284a5399 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2012-03-06 231 return ret;
aaefcd4284a5399 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2012-03-06 232 }
7e4d15d90afe46d drivers/gpu/drm/radeon/radeon_fb.c Simona Vetter 2011-02-18 233 rbo = gem_to_radeon_bo(gobj);
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 234
c4aab3499be2abd drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 235 fb = kzalloc(sizeof(*fb), GFP_KERNEL);
c4aab3499be2abd drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 236 if (!fb) {
c4aab3499be2abd drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 237 ret = -ENOMEM;
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 238 goto err_radeon_fbdev_destroy_pinned_object;
c4aab3499be2abd drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 239 }
c0a8e4443d768e5 drivers/gpu/drm/radeon/radeon_fbdev.c Imre Deak 2025-08-05 240 ret = radeon_framebuffer_init(rdev_to_drm(rdev), fb, format_info, &mode_cmd, gobj);
aaefcd4284a5399 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2012-03-06 241 if (ret) {
8b513d0cf603c0a drivers/gpu/drm/radeon/radeon_fb.c Masanari Iida 2013-05-21 242 DRM_ERROR("failed to initialize framebuffer %d\n", ret);
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 243 goto err_kfree;
aaefcd4284a5399 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2012-03-06 244 }
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 245
386516744ba45d5 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 246 /* setup helper */
41d48e557e01582 drivers/gpu/drm/radeon/radeon_fbdev.c Thomas Zimmermann 2024-09-24 247 fb_helper->funcs = &radeon_fbdev_fb_helper_funcs;
041f5c416217e37 drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 248 fb_helper->fb = fb;
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 249
041f5c416217e37 drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 250 info->fbops = &radeon_fbdev_fb_ops;
40e324e0d859d76 drivers/gpu/drm/radeon/radeon_fbdev.c Thomas Zimmermann 2023-07-15 251
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 252 /* radeon resume is fragile and needs a vt switch to help it along */
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 253 info->skip_vt_switch = false;
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 254
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 255 drm_fb_helper_fill_info(info, fb_helper, sizes);
785b93ef8c30973 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2009-08-28 256
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 257 tmp = radeon_bo_gpu_offset(rbo) - rdev->mc.vram_start;
f92e93eb5f4d56d drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-22 258 info->fix.smem_start = rdev->mc.aper_base + tmp;
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 259 info->fix.smem_len = radeon_bo_size(rbo);
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 260 info->screen_base = (__force void __iomem *)rbo->kptr;
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 261 info->screen_size = radeon_bo_size(rbo);
785b93ef8c30973 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2009-08-28 262
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 263 memset_io(info->screen_base, 0, info->screen_size);
ed8f0d9e708a1a7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2009-07-29 264
fb2a99e15ff0d34 drivers/gpu/drm/radeon/radeon_fb.c Sascha Hauer 2012-02-06 265 /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */
4abe35204af82a0 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 266
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 267 DRM_INFO("fb mappable at 0x%lX\n", info->fix.smem_start);
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 268 DRM_INFO("vram apper at 0x%lX\n", (unsigned long)rdev->mc.aper_base);
8be48d924c307e7 drivers/gpu/drm/radeon/radeon_fb.c Dave Airlie 2010-03-30 269 DRM_INFO("size %lu\n", (unsigned long)radeon_bo_size(rbo));
b00c600e91531df drivers/gpu/drm/radeon/radeon_fb.c Ville Syrjälä 2016-12-14 270 DRM_INFO("fb depth is %d\n", fb->format->depth);
01f2c7730e18807 drivers/gpu/drm/radeon/radeon_fb.c Ville Syrjälä 2011-12-20 271 DRM_INFO(" pitch is %d\n", fb->pitches[0]);
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 272
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 273 return 0;
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 274
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 @275 err_drm_framebuffer_unregister_private:
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 276 fb_helper->fb = NULL;
362063619cf67c2 drivers/gpu/drm/radeon/radeon_fb.c Simona Vetter 2012-12-10 277 drm_framebuffer_unregister_private(fb);
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 278 drm_framebuffer_cleanup(fb);
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 279 err_kfree:
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 280 kfree(fb);
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 281 err_radeon_fbdev_destroy_pinned_object:
3a745f6ac13216f drivers/gpu/drm/radeon/radeon_fb.c Thomas Zimmermann 2023-03-16 282 radeon_fbdev_destroy_pinned_object(gobj);
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 283 return ret;
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 284 }
771fe6b912fca54 drivers/gpu/drm/radeon/radeon_fb.c Jerome Glisse 2009-06-05 285
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/fb-helper: Allocate and release fb_info in single place
2025-10-26 17:18 [PATCH] drm/fb-helper: Allocate and release fb_info in single place Thomas Zimmermann
2025-10-26 23:41 ` kernel test robot
@ 2025-10-27 0:46 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-10-27 0:46 UTC (permalink / raw)
To: Thomas Zimmermann, javierm, airlied, simona, linux,
maarten.lankhorst, mripard, inki.dae, sw0312.kim, kyungmin.park,
patrik.r.jakobsson, jani.nikula, rodrigo.vivi, robin.clark, lumag,
abhinav.kumar, sean, marijn.suijten, tomi.valkeinen,
alexander.deucher, christian.koenig, thierry.reding, mperttunen,
jonathanh
Cc: llvm, oe-kbuild-all, dri-devel, intel-gfx, intel-xe,
linux-arm-msm, freedreno, amd-gfx, linux-tegra
Hi Thomas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-exynos/exynos-drm-next]
[also build test WARNING on drm-i915/for-linux-next drm-i915/for-linux-next-fixes tegra/for-next linus/master v6.18-rc2 next-20251024]
[cannot apply to rmk-arm/drm-armada-devel rmk-arm/drm-armada-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-fb-helper-Allocate-and-release-fb_info-in-single-place/20251027-014054
base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
patch link: https://lore.kernel.org/r/20251026173944.219373-1-tzimmermann%40suse.de
patch subject: [PATCH] drm/fb-helper: Allocate and release fb_info in single place
config: arm-randconfig-002-20251027 (https://download.01.org/0day-ci/archive/20251027/202510270856.L1iU6js4-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project e1ae12640102fd2b05bc567243580f90acb1135f)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251027/202510270856.L1iU6js4-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510270856.L1iU6js4-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/drm_fbdev_ttm.c:208:26: warning: variable 'info' is uninitialized when used here [-Wuninitialized]
208 | drm_fb_helper_fill_info(info, fb_helper, sizes);
| ^~~~
drivers/gpu/drm/drm_fbdev_ttm.c:180:22: note: initialize the variable 'info' to silence this warning
180 | struct fb_info *info;
| ^
| = NULL
1 warning generated.
--
>> drivers/gpu/drm/armada/armada_fbdev.c:111:2: warning: unused label 'err_fballoc' [-Wunused-label]
111 | err_fballoc:
| ^~~~~~~~~~~~
1 warning generated.
--
>> drivers/gpu/drm/radeon/radeon_fbdev.c:275:1: warning: unused label 'err_drm_framebuffer_unregister_private' [-Wunused-label]
275 | err_drm_framebuffer_unregister_private:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
vim +/info +208 drivers/gpu/drm/drm_fbdev_ttm.c
8ab59da26bc0ae drivers/gpu/drm/drm_fbdev_generic.c Thomas Zimmermann 2022-11-03 169
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 170 /*
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 171 * struct drm_driver
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 172 */
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 173
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 174 int drm_fbdev_ttm_driver_fbdev_probe(struct drm_fb_helper *fb_helper,
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 175 struct drm_fb_helper_surface_size *sizes)
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 176 {
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 177 struct drm_client_dev *client = &fb_helper->client;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 178 struct drm_device *dev = fb_helper->dev;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 179 struct drm_client_buffer *buffer;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 180 struct fb_info *info;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 181 size_t screen_size;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 182 void *screen_buffer;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 183 u32 format;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 184 int ret;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 185
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 186 drm_dbg_kms(dev, "surface width(%d), height(%d) and bpp(%d)\n",
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 187 sizes->surface_width, sizes->surface_height,
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 188 sizes->surface_bpp);
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 189
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 190 format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp,
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 191 sizes->surface_depth);
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 192 buffer = drm_client_framebuffer_create(client, sizes->surface_width,
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 193 sizes->surface_height, format);
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 194 if (IS_ERR(buffer))
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 195 return PTR_ERR(buffer);
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 196
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 197 fb_helper->funcs = &drm_fbdev_ttm_helper_funcs;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 198 fb_helper->buffer = buffer;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 199 fb_helper->fb = buffer->fb;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 200
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 201 screen_size = buffer->gem->size;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 202 screen_buffer = vzalloc(screen_size);
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 203 if (!screen_buffer) {
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 204 ret = -ENOMEM;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 205 goto err_drm_client_framebuffer_delete;
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 206 }
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 207
c7c1b9e1d52b0a drivers/gpu/drm/drm_fbdev_ttm.c Thomas Zimmermann 2024-09-24 @208 drm_fb_helper_fill_info(info, fb_helper, sizes);
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-27 0:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-26 17:18 [PATCH] drm/fb-helper: Allocate and release fb_info in single place Thomas Zimmermann
2025-10-26 23:41 ` kernel test robot
2025-10-27 0:46 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).