AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Timur Kristóf" <timur.kristof@gmail.com>
To: "Christian König" <christian.koenig@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	amd-gfx@lists.freedesktop.org
Cc: "Timur Kristóf" <timur.kristof@gmail.com>
Subject: [PATCH 00/10] drm/amdgpu: Improve page fault handling on GMC v6-8
Date: Wed, 26 Nov 2025 14:29:42 +0100	[thread overview]
Message-ID: <20251126132952.150452-1-timur.kristof@gmail.com> (raw)

Enable the soft IRQ handler ring on SI, CIK, VI and
delegate the processing of all VM faults to the soft
IRQ handler ring.

Why?

On old GPUs, it may be an issue that handling the interrupts from
VM faults is too slow and the interrupt handler (IH) ring may
overflow, which can cause an eventual hang. This is a concern
especially on SI and CIK where there are some HW limitations
regarding robustness features with some shader instructions,
which in practice means that users can see thousands of VM faults
during normal gaming use even when the game or the UMD don't do
anything wrong.

With this series, we spend much less time in the IRQ handler that
interacts with the HW IH ring, which significantly reduces the
chance of hangs.

There are also a few misc improvements to the GMC v6 code.

Timur Kristóf (10):
  drm/amdgpu/si_ih: Enable soft IRQ handler ring
  drm/amdgpu/cik_ih: Enable soft IRQ handler ring
  drm/amdgpu/iceland_ih: Enable soft IRQ handler ring
  drm/amdgpu/tonga_ih: Enable soft IRQ handler ring
  drm/amdgpu/cz_ih: Enable soft IRQ handler ring
  drm/amdgpu/gmc6: Don't print MC client as it's unknown
  drm/amdgpu/gmc6: Cache VM fault info
  drm/amdgpu/gmc6: Delegate VM faults to soft IRQ handler ring
  drm/amdgpu/gmc7: Delegate VM faults to soft IRQ handler ring
  drm/amdgpu/gmc8: Delegate VM faults to soft IRQ handler ring

 drivers/gpu/drm/amd/amdgpu/cik_ih.c     | 12 ++++++++++++
 drivers/gpu/drm/amd/amdgpu/cz_ih.c      | 10 ++++++++++
 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c   | 20 ++++++++++++++------
 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c   |  6 ++++++
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c   |  6 ++++++
 drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 10 ++++++++++
 drivers/gpu/drm/amd/amdgpu/si_ih.c      | 12 ++++++++++++
 drivers/gpu/drm/amd/amdgpu/tonga_ih.c   | 10 ++++++++++
 8 files changed, 80 insertions(+), 6 deletions(-)

-- 
2.51.1


             reply	other threads:[~2025-11-26 13:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26 13:29 Timur Kristóf [this message]
2025-11-26 13:29 ` [PATCH 01/10] drm/amdgpu/si_ih: Enable soft IRQ handler ring Timur Kristóf
2025-11-26 13:29 ` [PATCH 02/10] drm/amdgpu/cik_ih: " Timur Kristóf
2025-11-26 13:29 ` [PATCH 03/10] drm/amdgpu/iceland_ih: " Timur Kristóf
2025-11-26 13:29 ` [PATCH 04/10] drm/amdgpu/tonga_ih: " Timur Kristóf
2025-11-26 13:29 ` [PATCH 05/10] drm/amdgpu/cz_ih: " Timur Kristóf
2025-11-26 13:29 ` [PATCH 06/10] drm/amdgpu/gmc6: Don't print MC client as it's unknown Timur Kristóf
2025-11-26 13:29 ` [PATCH 07/10] drm/amdgpu/gmc6: Cache VM fault info Timur Kristóf
2025-11-26 13:29 ` [PATCH 08/10] drm/amdgpu/gmc6: Delegate VM faults to soft IRQ handler ring Timur Kristóf
2025-11-26 13:29 ` [PATCH 09/10] drm/amdgpu/gmc7: " Timur Kristóf
2025-11-26 13:29 ` [PATCH 10/10] drm/amdgpu/gmc8: " Timur Kristóf
2025-11-26 14:22 ` [PATCH 00/10] drm/amdgpu: Improve page fault handling on GMC v6-8 Christian König
2025-11-26 14:46   ` Alex Deucher
2025-11-26 15:04     ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251126132952.150452-1-timur.kristof@gmail.com \
    --to=timur.kristof@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox