AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Wang <kevinyang.wang@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <hawking.zhang@amd.com>, <alexander.deucher@amd.com>
Subject: [PATCH 2/4] drm/amd/pm: fix pp_dpm_pcie wrong state issue for smu v14.0.2
Date: Thu, 11 Dec 2025 13:15:53 +0800	[thread overview]
Message-ID: <20251211051555.652129-2-kevinyang.wang@amd.com> (raw)
In-Reply-To: <20251211051555.652129-1-kevinyang.wang@amd.com>

put wrong value into incorrect data into following function,
which caused it to fail to match the correct item on smu v14.0.2:
smu_cmn_print_pcie_levels()

Fixes: 55fc561a1955 ("drm/amd/pm: Use common helper for smuv14.0.2 dpm")

Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c
index d996ff69c60a..4a2a56758bc2 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c
@@ -1095,8 +1095,10 @@ static int smu_v14_0_2_emit_clk_levels(struct smu_context *smu,
 			return ret;
 
 		pcie_table = &(dpm_context->dpm_tables.pcie_table);
-		return smu_cmn_print_pcie_levels(smu, pcie_table, gen_speed,
-						 lane_width, buf, offset);
+		return smu_cmn_print_pcie_levels(smu, pcie_table,
+						 SMU_DPM_PCIE_GEN_IDX(gen_speed),
+						 SMU_DPM_PCIE_WIDTH_IDX(lane_width),
+						 buf, offset);
 
 	case SMU_OD_SCLK:
 		if (!smu_v14_0_2_is_od_feature_supported(smu,
-- 
2.34.1


  reply	other threads:[~2025-12-11  5:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-11  5:15 [PATCH 1/4] drm/amd/pm: add smu pcie dpm cap & width convert helper Yang Wang
2025-12-11  5:15 ` Yang Wang [this message]
2025-12-11  5:15 ` [PATCH 3/4] drm/amd/pm: fix pp_dpm_pcie wrong state issue for smu v13.0.0 Yang Wang
2025-12-11  5:15 ` [PATCH 4/4] drm/amd/pm: fix pp_dpm_pcie wrong state issue for smu v13.0.7 Yang Wang
2025-12-11  7:46 ` [PATCH 1/4] drm/amd/pm: add smu pcie dpm cap & width convert helper Lazar, Lijo
2025-12-11  7:51   ` Wang, Yang(Kevin)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251211051555.652129-2-kevinyang.wang@amd.com \
    --to=kevinyang.wang@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=hawking.zhang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox