From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4832D74960 for ; Fri, 19 Dec 2025 07:13:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0248810EE3C; Fri, 19 Dec 2025 07:13:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="VGZK/s+C"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67EB510EE2F; Fri, 19 Dec 2025 07:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1766128378; x=1797664378; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=l6tQ61PY49V14D2GFNf2ZWG1cSVvC9o+jThxs8XO4a0=; b=VGZK/s+CsB148f3NNEZzJGAKP5ZstifkP9LymCJZ0XI+k7YLQbVuWcOS H9IvY/BQG6B9v9bLoXhaU9Dv9DYHylcyU6vkHdHDbVT6r93NExqvrTX5Y ZJmKfBFwYz8Wy4RfIWq6M4o+0u9h5BYRqi0uEmmnWuJ0hUa2SRvMT7/FJ rrEMVp+AC25FAgsRyQB7Tfyfl7jNEZS/nfStFLkkUBa/m/XiDN8UeklkK 0hsu7ceAHbe+uINckL87MUd0jyxnciAbTk5KWPxE2spuVtxkvocNNhy5I okFwlDzvm/cHg3Y5iViHZyoV/Pn1Vf1U8J+CufMlN4d8tJ6jin+Yogyju w==; X-CSE-ConnectionGUID: ok5PmrYJQjuk+Ujg3NpR9g== X-CSE-MsgGUID: vaUvx7LSStWyikeaMLJBzg== X-IronPort-AV: E=McAfee;i="6800,10657,11646"; a="93562270" X-IronPort-AV: E=Sophos;i="6.21,159,1763452800"; d="scan'208";a="93562270" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2025 23:12:58 -0800 X-CSE-ConnectionGUID: ehlmLq8RQd2ulsLScpO5gg== X-CSE-MsgGUID: tmngKEg8QLq9e6rSl6ttBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,159,1763452800"; d="scan'208";a="222209418" Received: from dut-2a59.iind.intel.com ([10.190.239.113]) by fmviesa002.fm.intel.com with ESMTP; 18 Dec 2025 23:12:54 -0800 From: Chaitanya Kumar Borah To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Cc: harry.wentland@amd.com, jani.nikula@linux.intel.com, louis.chauvet@bootlin.com, mwen@igalia.com, contact@emersion.fr, alex.hung@amd.com, daniels@collabora.com, uma.shankar@intel.com, suraj.kandpal@intel.com, nfraprado@collabora.com, ville.syrjala@linux.intel.com, matthew.d.roper@intel.com Subject: [PATCH 00/13] drm: Color pipeline teardown and follow-up fixes/improvements Date: Fri, 19 Dec 2025 12:26:01 +0530 Message-Id: <20251219065614.190834-1-chaitanya.kumar.borah@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" This series contains follow-up fixes and improvements for the DRM color pipeline infrastructure that was introduced in v6.19.[1][2] The central handling of clean up of colorop from the mode_config list is missing. While vkms calls drm_colorop_pipeline_destroy() in vkms_destroy(), amd driver calls it only during failure of the init path and i915/xe driver does not call it at all. This means amd and intel leaks these objects on driver removal. This series adds the teardown of mode_config.colorop_list in drm_mode_config_cleanup(). Since, i915/xe sub-classes the drm_colorop within intel_colorop it was not enough to just use drm_colorop_pipeline_destroy(). Therefore, this series - Introduces driver-managed destruction for drm_colorop objects and updates core helpers to use driver-provided destroy callbacks. - Ensures all colorop objects are correctly torn down during mode_config cleanup and driver removal. In addition to that following changes are made in the series - Fixes enum name lifetime leaks in color pipeline init in i915, amdgpu_dm, and vkms - Corrects the ordering of the 3D LUT block in the i915 plane color pipeline - Refactors i915 plane color pipeline initialization to reliably clean up partially constructed pipelines on failure. Thanks for taking a look. Feedback is welcome. [1] https://lore.kernel.org/dri-devel/cbe00ac4-a535-47d3-813a-e2eda7e9b991@amd.com/ [2] https://lore.kernel.org/intel-gfx/20251203085211.3663374-1-uma.shankar@intel.com/ == Chaitanya Cc: Jani Nikula Cc: Uma Shankar Cc: Suraj Kandpal Cc: Ville Syrjälä Cc: Matt Roper Cc: Harry Wentland Cc: Alex Hung Cc: Louis Chauvet Cc: Melissa Wen Cc: Simon Ser Cc: Daniel Stone Cc: Nícolas F. R. A. Prado Chaitanya Kumar Borah (13): drm/i915/color: Place 3D LUT after CSC in plane color pipeline drm/amd/display: Fix color pipeline enum name leak drm/vkms: Fix color pipeline enum name leak drm/i915/display: Fix color pipeline enum name leak drm: Allow driver-managed destruction of colorop objects drm/colorop: Add destroy helper for colorop objects drm/amd/display: Hook up colorop destroy helper for plane pipelines drm/vkms: Hook up colorop destroy helper for plane pipelines drm/i915/display: Hook up intel_colorop_destroy drm: Clean up colorop objects during mode_config cleanup drm/vkms: Remove drm_colorop_pipeline_destroy() from vkms_destroy() drm/colorop: Use destroy callback for color pipeline teardown drm/i915/color: Add failure handling in plane color pipeline init .../amd/display/amdgpu_dm/amdgpu_dm_colorop.c | 31 +++- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 13 +- drivers/gpu/drm/drm_colorop.c | 46 +++-- drivers/gpu/drm/drm_mode_config.c | 6 + .../drm/i915/display/intel_color_pipeline.c | 161 +++++++++++++----- drivers/gpu/drm/i915/display/intel_colorop.c | 6 + drivers/gpu/drm/i915/display/intel_colorop.h | 1 + drivers/gpu/drm/vkms/vkms_colorop.c | 31 ++-- drivers/gpu/drm/vkms/vkms_drv.c | 1 - include/drm/drm_colorop.h | 40 ++++- 10 files changed, 249 insertions(+), 87 deletions(-) -- 2.25.1