From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 626F1C88E41 for ; Tue, 27 Jan 2026 08:19:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05AA910E4E1; Tue, 27 Jan 2026 08:19:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="K6oAUhRU"; dkim-atps=neutral Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 13C3210E47B for ; Mon, 26 Jan 2026 19:43:45 +0000 (UTC) Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-432d2c7dd52so5013007f8f.2 for ; Mon, 26 Jan 2026 11:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769456623; x=1770061423; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PP34zip0q8gk27TkCvRw7z7MtmFir2U2vp8I+qSycPQ=; b=K6oAUhRUdlGL7E50Ms3FgH5Fw3WAjEn+coD0K1fC2qSc7YD6o3EpIehW2So+z4t4J+ tefr8+q/Z31olEQ7wB6npVKEyP9UoV/Xap2PNYEHhIA2ZiARD0D9hJL27D8wlJekeBuk /3K6gxx6dvilE+kwdSSe9A6ZqTR0V07jhFvObVLR54WoZsf0CYwD1AXxplrHLiny7SOV IRHH6Lwcl0mnduYto+M1o4qgaDgEOkyDNPnYS6mqxfM99VUugRbrLQHR3TV4beUjsLjt +egGZobbRATiVp4PcH4Q19nRg5q8c1/jcryNwExiYq5nk8jtbdp7Je1E2t63yuc78kgb e9Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769456623; x=1770061423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PP34zip0q8gk27TkCvRw7z7MtmFir2U2vp8I+qSycPQ=; b=aEYzjUDuTdn4TfWvHTQHy3YzqAr1q7J+KoKjsxFVjZNHXvwr13eto1/Sw0KmH0dsJ4 gkbE1ftL9lUuT/rJGwofDLST67FJ6GPl8VQEN+1RfkJGhMJaInIg72QCOappirXm106O SRYlyFj+p1ZKMsNQ1kH85wiir6IdOCGmEf1PPUu/EJk/D0ZFNFAiBPdkEOAawk8bMfYC bu7lj9qyidYdiF0HBZU0difOwI548MLg6opAtgzogEJQTot+/K1IvvPrxr7Otct14qRg sexzgpJd2GwQkZqEqS1tFOtdrIp2Coi3tsU879kaYfxxiDY+w8qW13v8OsFqtXL2RxEO K/Yg== X-Forwarded-Encrypted: i=1; AJvYcCXnFZSY8a0prrM3rDHGaiwyCgZ8ImeWwZxWESjEXg6vRfhoq6rm4vPwTqD9LFXGeOYv+K/nQZ/w@lists.freedesktop.org X-Gm-Message-State: AOJu0Yx7IAEfvHGTAI1CovJG45PjBt89skwNZVwMem2VnWX4ULik1PeE 5sc/1OF2uFhUm1pZvEI8hFlqnoJMhSEIdvuQ/Joc0A4VMK+VRLV1CSOm X-Gm-Gg: AZuq6aIoszQIMXmsxFFbbjS4I/LPEJI4x977ySR9q/ONCerYfeHqEoW5zcXHuwoGMZ6 cbG+blH1yVTjd3SDmec0H5VPFclF1PHRbYIO71+y5hx9fduNupe36jCN+DDcW2nf7L716G/hbEi fYXRyFCfBQtJujIJSwT/T75iCAgrmYTJ2hkZySMIbnYBwOMf2ypwA/GRFBzzY6KJz/FXfFIYzyC aMrx/jGzzdPMANow895OiHtIHvpacmEsu6+sFEHgpuTtP7w29ys3NnHhgNynv0NUez+IagDhfdk pGCje10Ejk2bdNCNSBK8d1WTx6FGzYoBWbDQjmNRy3KrFQsHLbwWAenyzhfxY3zufuTrmObV12w PV1akjuQ+Kghfh/Me8VFclxmwnvpGoKF9vtxf7rnwCjbJGS5K/o9nI+koMHC8WzIJ36klxt0oGt W5d4qhUd4NFq3v+DcLSw83UpIeS1vcw+Nzo5nZDg== X-Received: by 2002:a05:6000:2912:b0:435:9691:d525 with SMTP id ffacd0b85a97d-435ca0ecc77mr8258197f8f.13.1769456623344; Mon, 26 Jan 2026 11:43:43 -0800 (PST) Received: from ionutnechita-arz2022.local ([2a02:2f0e:c30b:500:c472:222f:bc60:d893]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1c02cd8sm30838006f8f.8.2026.01.26.11.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 11:43:42 -0800 (PST) From: "Ionut Nechita (Sunlight Linux)" To: christian.koenig@amd.com Cc: alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, ionut_n2001@yahoo.com, linux-kernel@vger.kernel.org, sunlightlinux@gmail.com, superm1@kernel.org Subject: Re: [PATCH 1/1] drm/amdgpu: Fix TLB flush failures after hibernation resume Date: Mon, 26 Jan 2026 21:40:48 +0200 Message-ID: <20260126194057.7376-2-sunlightlinux@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <77fa0344-3507-420e-9d77-d454ace55cfd@amd.com> References: <20260106125929.25214-6-sunlightlinux@gmail.com> <77fa0344-3507-420e-9d77-d454ace55cfd@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 27 Jan 2026 08:19:15 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" From: Ionut Nechita On Thu, Jan 8 2026 at 13:36, Christian König wrote: > Question is why the KIQ is not up and running before we do anything with it? Thank you for the feedback. I completely understand that my patch is just a workaround and not proper engineering - you're absolutely right that the real issue is KIQ being marked as ready before it's actually functional. I don't have experience with GPU drivers and video subsystems, so I'm not familiar with the proper initialization sequence for KIQ. I'd prefer not to keep a workaround for this issue in my tree. Is there a proper fix available, or could you point me in the right direction? I'm happy to test any patches on my AMD Cezanne (Renoir) hardware where I can reliably reproduce the issue after hibernation. Also, regarding hibernation support: you mentioned that hibernation is not generally supported with the driver. Should I expect other issues beyond this TLB flush problem, or is this the main blocker? Thanks for your time, Ionut