AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexander.deucher@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Yifan Zhang <yifan1.zhang@amd.com>
Subject: [PATCH 12/12] drm/amdgpu/sdma7.1: handle gfxoff in interrupt set functions
Date: Mon, 26 Jan 2026 15:07:47 -0500	[thread overview]
Message-ID: <20260126200747.13527-12-alexander.deucher@amd.com> (raw)
In-Reply-To: <20260126200747.13527-1-alexander.deucher@amd.com>

Need to make sure gfxoff is disallowed when we touch GC
registers over MMIO.

Cc: Yifan Zhang <yifan1.zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c b/drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c
index d8167ce18dbd8..38bc0e9edd86e 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c
@@ -1482,13 +1482,14 @@ static int sdma_v7_1_set_trap_irq_state(struct amdgpu_device *adev,
 					enum amdgpu_interrupt_state state)
 {
 	u32 sdma_cntl;
-
 	u32 reg_offset = sdma_v7_1_get_reg_offset(adev, type, regSDMA0_SDMA_CNTL);
 
+	amdgpu_gfx_off_ctrl(adev, false);
 	sdma_cntl = RREG32(reg_offset);
 	sdma_cntl = REG_SET_FIELD(sdma_cntl, SDMA0_SDMA_CNTL, TRAP_ENABLE,
 		       state == AMDGPU_IRQ_STATE_ENABLE ? 1 : 0);
 	WREG32(reg_offset, sdma_cntl);
+	amdgpu_gfx_off_ctrl(adev, true);
 
 	return 0;
 }
-- 
2.52.0


  parent reply	other threads:[~2026-01-26 20:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 20:07 [PATCH 01/12] drm/amdgpu/gfx9: handle gfxoff in interrupt set functions Alex Deucher
2026-01-26 20:07 ` [PATCH 02/12] drm/amdgpu/gmc9: " Alex Deucher
2026-01-26 20:07 ` [PATCH 03/12] drm/amdgpu/gfx10: " Alex Deucher
2026-01-26 20:07 ` [PATCH 04/12] drm/amdgpu/gmc9: " Alex Deucher
2026-01-26 20:48   ` Alex Deucher
2026-01-27  0:34     ` Zhang, Yifan
2026-01-26 20:07 ` [PATCH 05/12] drm/amdgpu/sdma5: " Alex Deucher
2026-01-26 20:07 ` [PATCH 06/12] drm/amdgpu/sdma5.2: " Alex Deucher
2026-01-26 20:07 ` [PATCH 07/12] drm/amdgpu/gfx11: " Alex Deucher
2026-01-26 20:07 ` [PATCH 08/12] drm/amdgpu/sdma6: " Alex Deucher
2026-01-26 20:07 ` [PATCH 09/12] drm/amdgpu/gfx12: " Alex Deucher
2026-01-26 20:07 ` [PATCH 10/12] drm/amdgpu/gfx12.1: " Alex Deucher
2026-01-26 20:07 ` [PATCH 11/12] drm/amdgpu/sdma7: " Alex Deucher
2026-01-26 20:07 ` Alex Deucher [this message]
2026-01-27  4:52 ` [PATCH 01/12] drm/amdgpu/gfx9: " Lazar, Lijo
2026-01-30 14:48   ` Alex Deucher
2026-01-30 15:05     ` Lazar, Lijo
2026-01-30 15:49       ` Alex Deucher
2026-01-31  6:04         ` Lazar, Lijo
2026-02-02  6:33           ` Zhang, Yifan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260126200747.13527-12-alexander.deucher@amd.com \
    --to=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=yifan1.zhang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox