From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 009FEF589B3 for ; Thu, 23 Apr 2026 12:42:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E96110F0F5; Thu, 23 Apr 2026 12:42:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dyVdK1ub"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id B01A310E404; Thu, 23 Apr 2026 11:22:26 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 4BB056001A; Thu, 23 Apr 2026 11:22:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC05EC2BCAF; Thu, 23 Apr 2026 11:22:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1776943345; bh=v5vX1VJ6hD3zefByaEKuGLyZr08vT7W1KOhrYxlfQpg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dyVdK1ubOcAXp+YKP2Nghh5b/q+AZL8CUbkno1W4J6qFNzaRqb5Q/cGxj/9xWlcd8 7AxDYHjbbuAeZ602YL4l7KQtxwNJV5hiOAXeP+xksDwbqUadzxLW1nwN09P+rAPuXm mH4xhcZbwkWaUlxpVc7/06VwsgosoKeUjjkzTOoo= Date: Thu, 23 Apr 2026 13:22:22 +0200 From: Greg Kroah-Hartman To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: Timur =?iso-8859-1?Q?Krist=F3f?= , stable@vger.kernel.org, Robert Garcia , Alex Deucher , Pan Xinhui , David Airlie , Daniel Vetter , Yifan Zha , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6.1.y] drm/amdgpu: remove two invalid BUG_ON()s Message-ID: <2026042335-probation-heftiness-7399@gregkh> References: <20260417074010.1607496-1-rob_garcia@163.com> <7260936.9J7NaK4W3v@timur-hyperion> <6064b45a-b8de-4848-856f-383d2d06680d@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6064b45a-b8de-4848-856f-383d2d06680d@amd.com> X-Mailman-Approved-At: Thu, 23 Apr 2026 12:42:22 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, Apr 22, 2026 at 04:11:15PM +0200, Christian König wrote: > Those points are certainly valid. > > I've also up-streamed a patch which completely rejects userspace submissions who try to use the CE. > > The problem is that those BUG_ON() can lead to a deny of service because they crash the whole kernel. > > A BUG_ON() is only justified if it prevents even worse things to happen, e.g. data corruption or it would crash later on anyway just not so obvious on what is wrong. > > Otherwise we should use WARN_ON(). WARN_ON() crashes the kernel as well when panic-on-warn is enabled, as it is in a few billion Linux systems :( As this commit is upstream, and in other stable trees, I'll apply this as it's not nice to have a simple way for userspace to crash the system. thanks, greg k-h